From: Stephen Boyd <sboyd@kernel.org>
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-clk@vger.kernel.org
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
mturquette@baylibre.com, linux-imx@nxp.com,
kernel@pengutronix.de, fabio.estevam@nxp.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree
Date: Fri, 06 Sep 2019 10:13:22 -0700 [thread overview]
Message-ID: <20190906171323.8847820640@mail.kernel.org> (raw)
In-Reply-To: <1566299605-15641-9-git-send-email-aisheng.dong@nxp.com>
Quoting Dong Aisheng (2019-08-20 04:13:22)
> Add parsing clocks from device tree.
Please describe some more here.
> diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> index c0aff7c..90326e5 100644
> --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
> +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
> @@ -157,6 +158,101 @@ static const struct imx8qxp_ss_lpcg imx8qxp_ss_lsio = {
> .num_max = IMX_LSIO_LPCG_CLK_END,
> };
>
> +#define IMX_LPCG_MAX_CLKS 8
> +
> +static struct clk_hw *imx_lpcg_of_clk_src_get(struct of_phandle_args *clkspec,
> + void *data)
> +{
> + struct clk_hw_onecell_data *hw_data = data;
> + unsigned int idx = clkspec->args[0] / 4;
> +
> + if (idx >= hw_data->num) {
> + pr_err("%s: invalid index %u\n", __func__, idx);
> + return ERR_PTR(-EINVAL);
> + }
> +
> + return hw_data->hws[idx];
> +}
> +
> +static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
> + struct device_node *np)
> +{
> + const char *output_names[IMX_LPCG_MAX_CLKS];
> + const char *parent_names[IMX_LPCG_MAX_CLKS];
> + unsigned int bit_offset[IMX_LPCG_MAX_CLKS];
> + struct clk_hw_onecell_data *clk_data;
> + struct clk_hw **clk_hws;
> + struct resource *res;
> + void __iomem *base;
> + int count;
> + int idx;
> + int ret;
> + int i;
> +
> + if (!of_device_is_compatible(np, "fsl,imx8qxp-lpcg"))
> + return -EINVAL;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(base))
> + return PTR_ERR(base);
> +
> + count = of_property_count_u32_elems(np, "clock-indices");
> + if (count < 0) {
> + dev_err(&pdev->dev, "failed to count clocks\n");
> + return -EINVAL;
> + }
Is 'count' expected to be equal to IMX_LPCG_MAX_CLKS? Because later on
in this function we set the num of clks to the MAX instead of the count
from clock-indices.
> +
> + clk_data = devm_kzalloc(&pdev->dev, struct_size(clk_data, hws, IMX_LPCG_MAX_CLKS),
This line is too long.
> + GFP_KERNEL);
> + if (!clk_data)
> + return -ENOMEM;
> +
> + clk_data->num = IMX_LPCG_MAX_CLKS;
> + clk_hws = clk_data->hws;
> +
> + ret = of_property_read_u32_array(np, "clock-indices", bit_offset,
> + count);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to read clocks bit-offset\n");
This isn't called bit-offset anymore.
> + return -EINVAL;
> + }
> +
> + ret = of_clk_parent_fill(np, parent_names, count);
> + if (ret != count) {
> + dev_err(&pdev->dev, "failed to get clock parent names\n");
> + return -EINVAL;
return count?
> + }
> +
> + ret = of_property_read_string_array(np, "clock-output-names",
> + output_names, count);
> + if (ret != count) {
> + dev_err(&pdev->dev, "failed to read clock-output-names\n");
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < count; i++) {
> + idx = bit_offset[i] / 4;
> + if (idx > IMX_LPCG_MAX_CLKS) {
> + dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
> + i);
> + return -EINVAL;
> + }
> +
> + clk_hws[idx] = imx_clk_lpcg_scu(output_names[i],
> + parent_names[i], 0, base,
> + bit_offset[i], false);
> + if (IS_ERR(clk_hws[idx])) {
> + dev_warn(&pdev->dev, "failed to register clock %d\n",
> + idx);
> + return -EINVAL;
> + }
> + }
> +
> + return devm_of_clk_add_hw_provider(&pdev->dev, imx_lpcg_of_clk_src_get,
> + clk_data);
If this fails does imx_clk_lpcg_scu() need to be unwound and unregister
clks?
> +}
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-06 17:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 11:13 [PATCH V4 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 01/11] dt-bindings: firmware: imx-scu: new binding to parse clocks from device tree Dong Aisheng
2019-08-24 19:19 ` Shawn Guo
2019-08-26 3:24 ` Aisheng Dong
2019-08-27 17:04 ` Rob Herring
2019-09-06 16:56 ` Stephen Boyd
2019-08-20 11:13 ` [PATCH V4 02/11] dt-bindings: clock: imx-lpcg: add support " Dong Aisheng
2019-08-24 19:21 ` Shawn Guo
2019-08-26 3:14 ` Aisheng Dong
2019-08-26 3:21 ` Aisheng Dong
2019-08-27 17:05 ` Rob Herring
2019-09-06 17:00 ` Stephen Boyd
2019-08-20 11:13 ` [PATCH V4 03/11] clk: imx: scu: add two cells binding support Dong Aisheng
2019-09-06 17:06 ` Stephen Boyd
2019-09-09 10:23 ` Dong Aisheng
2019-09-16 18:44 ` Stephen Boyd
2019-11-17 12:07 ` Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains Dong Aisheng
2019-09-06 17:07 ` Stephen Boyd
2019-09-09 10:24 ` Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 05/11] clk: imx: scu: allow scu clk to take device pointer Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 06/11] clk: imx: scu: add runtime pm support Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 07/11] clk: imx: scu: add suspend/resume support Dong Aisheng
2019-09-06 17:09 ` Stephen Boyd
2019-09-09 10:35 ` Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree Dong Aisheng
2019-09-06 17:13 ` Stephen Boyd [this message]
2019-09-09 11:23 ` Dong Aisheng
2019-09-16 18:45 ` Stephen Boyd
2019-11-17 12:08 ` Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 09/11] clk: imx: lpcg: allow lpcg clk to take device pointer Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support Dong Aisheng
2019-08-20 11:13 ` [PATCH V4 11/11] clk: imx: lpcg: add suspend/resume support Dong Aisheng
2019-09-06 17:14 ` Stephen Boyd
2019-09-09 11:39 ` Dong Aisheng
2019-09-09 12:21 ` [PATCH V4 00/11] clk: imx8: add new clock binding for better pm support Oliver Graute
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906171323.8847820640@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).