From: Mark Brown <broonie@kernel.org>
To: Luhua Xu <luhua.xu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] spi: mediatek: support large PA
Date: Wed, 11 Sep 2019 11:03:07 +0100 [thread overview]
Message-ID: <20190911100307.GR2036@sirena.org.uk> (raw)
In-Reply-To: <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 341 bytes --]
On Wed, Sep 11, 2019 at 05:55:31AM -0400, Luhua Xu wrote:
> + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(addr_bits));
> + if (ret)
> + dev_notice(&pdev->dev, "SPI dma_set_mask(%d) failed, ret:%d\n",
> + addr_bits, ret);
Not sure why you picked dev_notice() over dev_err() here?
Otherwise this looks good so I'll go ahead and apply.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-09-11 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1568195731-3239-1-git-send-email-luhua.xu@mediatek.com>
[not found] ` <1568195731-3239-4-git-send-email-luhua.xu@mediatek.com>
2019-09-11 10:03 ` Mark Brown [this message]
2019-09-13 9:42 ` Applied "spi: mediatek: support large PA" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911100307.GR2036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=luhua.xu@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).