From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: atmel: Fix crash when using more than 4 gpio CS
Date: Fri, 20 Sep 2019 11:51:01 +0100 [thread overview]
Message-ID: <20190920105101.GA3822@sirena.co.uk> (raw)
In-Reply-To: <20190919172350.GZ21254@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 652 bytes --]
On Thu, Sep 19, 2019 at 07:23:50PM +0200, Alexandre Belloni wrote:
> On 19/09/2019 17:03:15+0100, Mark Brown wrote:
> > This is going to break any system where we use both a GPIO chip select
> > and chip select 0. Ideally we'd try to figure out an unused chip select
> > to use here...
> The point is that this use case is already broken and this patch fixes
> the crash and is easily backportable.
> Fixing the CS + gpio CS should probably be done in a separate patch.
If the GPIO is overlaid on any of the existing slots (except GPIO 0)
then it'll cause GPIO 0 to start toggling. I'm not convinced that the
code doesn't currently support that.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-20 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 15:38 [PATCH] spi: atmel: Fix crash when using more than 4 gpio CS Gregory CLEMENT
2019-09-19 16:03 ` Mark Brown
2019-09-19 17:23 ` Alexandre Belloni
2019-09-20 10:51 ` Mark Brown [this message]
2019-09-20 15:27 ` Gregory CLEMENT
2019-09-20 15:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920105101.GA3822@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).