From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-arch@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com,
linus.walleij@linaro.org, linux-pm@vger.kernel.org,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
bgolaszewski@baylibre.com, lukas@wunner.de, geert@linux-m68k.org,
akpm@linux-foundation.org, preid@electromag.com.au,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v18 10/14] gpio: 74x164: Utilize the for_each_set_clump8 macro
Date: Thu, 10 Oct 2019 16:16:35 +0300 [thread overview]
Message-ID: <20191010131635.GR32742@smile.fi.intel.com> (raw)
In-Reply-To: <7ea2df7182a50a1136ca36edc46dffcb2446fd27.1570641097.git.vilhelm.gray@gmail.com>
On Wed, Oct 09, 2019 at 01:14:46PM -0400, William Breathitt Gray wrote:
> Replace verbose implementation in set_multiple callback with
> for_each_set_clump8 macro to simplify code and improve clarity.
>
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Phil Reid <preid@electromag.com.au>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> drivers/gpio/gpio-74x164.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index e81307f9754e..05637d585152 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -6,6 +6,7 @@
> * Copyright (C) 2010 Miguel Gaio <miguel.gaio@efixo.com>
> */
>
> +#include <linux/bitops.h>
> #include <linux/gpio/consumer.h>
> #include <linux/gpio/driver.h>
> #include <linux/module.h>
> @@ -72,20 +73,18 @@ static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask,
> unsigned long *bits)
> {
> struct gen_74x164_chip *chip = gpiochip_get_data(gc);
> - unsigned int i, idx, shift;
> - u8 bank, bankmask;
> + unsigned long offset;
> + unsigned long bankmask;
> + size_t bank;
> + unsigned long bitmask;
>
> mutex_lock(&chip->lock);
> - for (i = 0, bank = chip->registers - 1; i < chip->registers;
> - i++, bank--) {
> - idx = i / sizeof(*mask);
> - shift = i % sizeof(*mask) * BITS_PER_BYTE;
> - bankmask = mask[idx] >> shift;
> - if (!bankmask)
> - continue;
> + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) {
> + bank = chip->registers - 1 - offset / 8;
> + bitmask = bitmap_get_value8(bits, offset) & bankmask;
>
> chip->buffer[bank] &= ~bankmask;
> - chip->buffer[bank] |= bankmask & (bits[idx] >> shift);
> + chip->buffer[bank] |= bitmask;
> }
> __gen_74x164_write_config(chip);
> mutex_unlock(&chip->lock);
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-10 13:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 17:14 [PATCH v18 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 01/14] bitops: " William Breathitt Gray
2019-10-09 21:18 ` Andrew Morton
2019-10-10 13:18 ` Andy Shevchenko
2019-10-09 17:14 ` [PATCH v18 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-10 13:16 ` Andy Shevchenko [this message]
2019-10-09 17:14 ` [PATCH v18 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 12/14] gpio: pisosr: Utilize the " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 13/14] gpio: max3191x: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 14/14] gpio: pca953x: " William Breathitt Gray
2019-10-10 13:16 ` Andy Shevchenko
2019-10-09 17:38 ` [PATCH v18 00/14] Introduce " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010131635.GR32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=preid@electromag.com.au \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).