From: Jonathan Cameron <jic23@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lars@metafoo.de, alexandre.torgue@st.com,
linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org,
u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, thierry.reding@gmail.com, pmeerw@pmeerw.net,
knaack.h@gmx.de, fabrice.gasnier@st.com, lee.jones@linaro.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger bindings to json-schema
Date: Sun, 3 Nov 2019 11:08:41 +0000 [thread overview]
Message-ID: <20191103110841.3ad3ecfb@archlinux> (raw)
In-Reply-To: <20191031123040.26316-3-benjamin.gaignard@st.com>
On Thu, 31 Oct 2019 13:30:38 +0100
Benjamin Gaignard <benjamin.gaignard@st.com> wrote:
> Convert the STM32 IIO trigger binding to DT schema format using json-schema
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
I'm far from great on these as still haven't taken the time I should to learn
the yaml syntax properly. A few comments inline however based mostly on this
doesn't quite look like other ones I've seen recently.
Thanks,
Jonathan
> ---
> .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++
> .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------
> 2 files changed, 44 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> new file mode 100644
> index 000000000000..1c8c8b55e8cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 Timers IIO timer bindings
> +
> +maintainers:
> + - Benjamin Gaignard <benjamin.gaignard@st.com>
> + - Fabrice Gasnier <fabrice.gasnier@st.com>
> +
> +properties:
> + $nodemane:
nodename?
> + pattern: "^timer@[0-9]+$"
> + type: object
> +
> + description:
> + must be a sub-node of an STM32 Timer device tree node
> +
> + properties:
> + compatible:
> + oneOf:
enum is I think preferred for these.
> + - const: st,stm32-timer-trigger
> + - const: st,stm32h7-timer-trigger
> +
> + reg: true
Normally some info for what the reg value is..
> +
> + required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + timers2: timer@40000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + timer@0 {
> + compatible = "st,stm32-timer-trigger";
> + reg = <0>;
> + };
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
> deleted file mode 100644
> index b8e8c769d434..000000000000
> --- a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -STMicroelectronics STM32 Timers IIO timer bindings
> -
> -Must be a sub-node of an STM32 Timers device tree node.
> -See ../mfd/stm32-timers.txt for details about the parent node.
> -
> -Required parameters:
> -- compatible: Must be one of:
> - "st,stm32-timer-trigger"
> - "st,stm32h7-timer-trigger"
> -- reg: Identify trigger hardware block.
> -
> -Example:
> - timers@40010000 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - compatible = "st,stm32-timers";
> - reg = <0x40010000 0x400>;
> - clocks = <&rcc 0 160>;
> - clock-names = "int";
> -
> - timer@0 {
> - compatible = "st,stm32-timer-trigger";
> - reg = <0>;
> - };
> - };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-03 11:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:30 [PATCH 0/4] Convert STM32 Timer mdf bindings to yaml Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 1/4] dt-bindings: counter: Convert stm32 counter bindings to json-schema Benjamin Gaignard
2019-11-06 4:10 ` Rob Herring
2019-11-06 4:16 ` Rob Herring
2019-11-06 19:58 ` Benjamin GAIGNARD
2019-10-31 12:30 ` [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger " Benjamin Gaignard
2019-11-03 11:08 ` Jonathan Cameron [this message]
2019-11-05 10:07 ` Benjamin Gaignard
2019-11-06 4:06 ` Rob Herring
2019-11-06 19:51 ` Benjamin GAIGNARD
2019-11-06 23:35 ` Rob Herring
2019-11-09 12:43 ` Jonathan Cameron
2019-10-31 12:30 ` [PATCH 3/4] dt-bindings: pwm: Convert stm32 pwm " Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 4/4] dt-bindings: mfd: Convert stm32 timers " Benjamin Gaignard
2019-11-06 4:15 ` Rob Herring
2019-11-06 19:57 ` Benjamin GAIGNARD
2019-11-06 23:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103110841.3ad3ecfb@archlinux \
--to=jic23@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).