From: Will Deacon <will@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>, robin.murphy@arm.com
Cc: Lingyan Huang <huanglingyan2@huawei.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH v4] arm64: lib: accelerate do_csum
Date: Wed, 8 Jan 2020 17:20:41 +0000 [thread overview]
Message-ID: <20200108172040.GA20541@willie-the-truck> (raw)
In-Reply-To: <1573006806-12037-1-git-send-email-zhangshaokun@hisilicon.com>
On Wed, Nov 06, 2019 at 10:20:06AM +0800, Shaokun Zhang wrote:
> From: Lingyan Huang <huanglingyan2@huawei.com>
>
> Function do_csum() in lib/checksum.c is used to compute checksum,
> which is turned out to be slowly and costs a lot of resources.
> Let's accelerate the checksum computation for arm64.
>
> While we test its performance on Huawei Kunpeng 920 SoC, as follow:
> 1cycle general(ns) csum_128(ns) csum_64(ns)
> 64B: 160 80 50
> 256B: 120 70 60
> 1023B: 350 140 150
> 1024B: 350 130 140
> 1500B: 470 170 180
> 2048B: 630 210 240
> 4095B: 1220 390 430
> 4096B: 1230 390 430
>
> Cc: Will Deacon <will@kernel.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Originally-from: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Lingyan Huang <huanglingyan2@huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> Hi,
> Apologies that we post this version so later, because we want to
> optimise it better, Lingyan tested it performance which is attached
> in commit log. Both(128 and 64) are much better than the initial
> code.
> ChangeLog:
> based on Robin's code and change strides from 64 to 128.
>
> arch/arm64/include/asm/checksum.h | 3 ++
> arch/arm64/lib/Makefile | 2 +-
> arch/arm64/lib/csum.c | 81 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 85 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/lib/csum.c
Robin -- any chance you could look at this please? If it's based on your
code then hopefully it's straightforward to review ;)
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-08 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 2:20 [PATCH v4] arm64: lib: accelerate do_csum Shaokun Zhang
2020-01-08 17:20 ` Will Deacon [this message]
2020-01-11 8:09 ` Shaokun Zhang
2020-01-14 12:18 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108172040.GA20541@willie-the-truck \
--to=will@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=huanglingyan2@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).