From: Catalin Marinas <catalin.marinas@arm.com>
To: Hoan Tran <hoan@os.amperecomputing.com>
Cc: patches@os.amperecomputing.com, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA
Date: Wed, 11 Mar 2020 11:27:00 +0000 [thread overview]
Message-ID: <20200311112700.GD3216816@arrakis.emea.arm.com> (raw)
In-Reply-To: <c85dbc06-a72b-9c98-fe41-b25069114b2f@os.amperecomputing.com>
On Thu, Feb 06, 2020 at 12:01:19PM -0800, Hoan Tran wrote:
> Hi Will,
>
> On 2/6/20 2:23 AM, Will Deacon wrote:
> > On Mon, Feb 03, 2020 at 11:55:14AM -0800, Hoan Tran wrote:
> > > Some NUMA nodes have memory ranges that span other nodes.
> > > Even though a pfn is valid and between a node's start and end pfns,
> > > it may not reside on that node.
> > >
> > > This patch enables NODES_SPAN_OTHER_NODES config for NUMA to support
> > > this type of NUMA layout.
> > >
> > > Signed-off-by: Hoan Tran <Hoan@os.amperecomputing.com>
> > > ---
> > > arch/arm64/Kconfig | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > > index e688dfa..939d28f 100644
> > > --- a/arch/arm64/Kconfig
> > > +++ b/arch/arm64/Kconfig
> > > @@ -959,6 +959,13 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
> > > config HOLES_IN_ZONE
> > > def_bool y
> > > +# Some NUMA nodes have memory ranges that span other nodes.
> > > +# Even though a pfn is valid and between a node's start and end pfns,
> > > +# it may not reside on that node.
> > > +config NODES_SPAN_OTHER_NODES
> > > + def_bool y
> > > + depends on ACPI_NUMA
> > > +
> >
> > I thought we agreed to do this in the core code?
> >
> > https://lore.kernel.org/lkml/1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com
>
> Yes, but it looks like Thomas didn't agree to apply this patch into
> x86.
>
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1907152042110.1767@nanos.tec.linutronix.de/
Was it a clear statement that such change will not make it to x86 or a
request for improving the patch or the description? I'd suggest you
update the x86 patch comment to include the rationale as per your reply
to Thomas and post a new version of the generic series. If Thomas (or
the mm folk) reject it again, we'll revisit the arm64-specific thread.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-11 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 19:55 [PATCH] arm64: Kconfig: Enable NODES_SPAN_OTHER_NODES config for NUMA Hoan Tran
2020-02-06 10:23 ` Will Deacon
2020-02-06 20:01 ` Hoan Tran
2020-02-25 23:20 ` Hoan Tran
2020-03-11 6:31 ` Hoan Tran
2020-03-11 11:27 ` Catalin Marinas [this message]
2020-03-28 18:36 ` Hoan Tran
-- strict thread matches above, loose matches on Subject: below --
2019-06-24 14:38 Hoan Tran OS
2019-06-25 10:12 ` Will Deacon
2019-06-25 14:55 ` Hoan Tran OS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311112700.GD3216816@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=hoan@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).