From: "Pali Rohár" <pali@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "Tomasz Maciej Nowak" <tmn505@gmail.com>,
linux-pci@vger.kernel.org, Xogium <contact@xogium.me>,
linux-kernel@vger.kernel.org, "Marek Behún" <marek.behun@nic.cz>,
"Remi Pommarel" <repk@triplefau.lt>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
"Andrew Murray" <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected
Date: Tue, 21 Jul 2020 10:57:13 +0200 [thread overview]
Message-ID: <20200721085713.p2rbmucpk5ra3quw@pali> (raw)
In-Reply-To: <20200715162108.GB3432@e121166-lin.cambridge.arm.com>
On Wednesday 15 July 2020 17:21:08 Lorenzo Pieralisi wrote:
> On Wed, Jul 15, 2020 at 02:17:26PM +0200, Pali Rohár wrote:
> > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote:
> > > On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote:
> > > > On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote:
> > > > > On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote:
> > > > > > > I understand that but the bridge bus resource can be trimmed to just
> > > > > > > contain the root bus because that's the only one where there is a
> > > > > > > chance you can enumerate a device.
> > > > > >
> > > > > > It is possible to register only root bridge without endpoint?
> > > > >
> > > > > It is possible to register the root bridge with a trimmed IORESOURCE_BUS
> > > > > so that you don't enumerate anything other than the root port.
> > > >
> > > > Hello Lorenzo! I really do not know how to achieve it. From code it
> > > > looks like that pci/probe.c scans child buses unconditionally.
> > > >
> > > > pci-aardvark.c calls pci_host_probe() which calls functions
> > > > pci_scan_root_bus_bridge() which calls pci_scan_child_bus() which calls
> > > > pci_scan_child_bus_extend() which calls pci_scan_bridge_extend() (bridge
> > > > needs to be reconfigured) which then try to probe child bus via
> > > > pci_scan_child_bus_extend() because bridge is not card bus.
> > > >
> > > > In function pci_scan_bridge_extend() I do not see a way how to skip
> > > > probing for child buses which would avoid enumerating aardvark root
> > > > bridge when PCIe device is not connected.
> > > >
> > > > dmesg output contains:
> > > >
> > > > advk-pcie d0070000.pcie: link never came up
> > > > advk-pcie d0070000.pcie: PCI host bridge to bus 0000:00
> > > > pci_bus 0000:00: root bus resource [bus 00-ff]
> > >
> > > This resource can be limited to the root bus number only before calling
> > > pci_host_probe() (ie see pci_parse_request_of_pci_ranges() and code in
> > > pci_scan_bridge_extend() that programs primary/secondary/subordinate
> > > busses) but I think that only papers over the issue, it does not fix it.
> >
> > I looked at the code in pci/probe.c again and I do not think it is
> > possible to avoid scanning devices. pci_scan_child_bus_extend() is
> > unconditionally calling pci_scan_slot() for devfn=0 as the first thing.
> > And this function unconditionally calls pci_scan_device() which is
> > directly trying to read vendor id from config register.
> >
> > So for me it looks like that kernel expects that can read vendor id and
> > device id from config register for device which is not connected.
>
> Not if it is connected to a bus that the root port does not decode,
> that's what I am saying.
>
> > And trying to read config register would cause those timeouts in
> > aardvark.
>
> The root port (which effectively works as PCI bridge from this
> standpoint) does not issue config cycles for busses that aren't within
> its decoded bus range, which in turn is determined by the firmware
> IORESOURCE_BUS resource.
>
> This issue is caused by devices that are connected downstream to
> the root port.
>
> Anyway - patch merged
Could you send me a link to git commit? I have looked into
lpieralisi/pci.git repository, but I do not see it here.
> but I would be happy to keep this discussion going, somehow.
Ok, no problem. As I said if anybody has any idea or would like to see
some tests from me, I can do it and provide results.
> If the LPC20 VFIO/IOMMU/PCI microconference is approved it can be a
> good venue for this to happen.
>
> Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-21 8:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:31 [PATCH] PCI: aardvark: Don't touch PCIe registers if no card connected Pali Rohár
2020-05-28 16:26 ` Bjorn Helgaas
2020-05-28 16:38 ` Pali Rohár
2020-05-28 16:49 ` Bjorn Helgaas
2020-05-29 8:30 ` Pali Rohár
2020-06-30 12:31 ` Pali Rohár
2020-06-30 13:51 ` Bjorn Helgaas
2020-06-30 14:04 ` Pali Rohár
2020-06-30 14:58 ` Bjorn Helgaas
2020-07-01 8:08 ` Pali Rohár
2020-07-01 8:20 ` [PATCH v2] " Pali Rohár
2020-07-01 21:34 ` Bjorn Helgaas
2020-07-02 8:23 ` Pali Rohár
2020-07-02 8:30 ` [PATCH v3] " Pali Rohár
2020-07-09 11:35 ` Lorenzo Pieralisi
2020-07-09 12:22 ` Pali Rohár
2020-07-09 14:47 ` Lorenzo Pieralisi
2020-07-09 15:09 ` Pali Rohár
2020-07-10 9:18 ` Lorenzo Pieralisi
2020-07-10 15:44 ` Pali Rohár
2020-07-10 16:08 ` Bjorn Helgaas
2020-07-10 19:30 ` Pali Rohár
2020-07-10 20:08 ` Bjorn Helgaas
2020-07-13 8:27 ` Pali Rohár
2020-07-13 11:23 ` Lorenzo Pieralisi
2020-07-13 14:50 ` Pali Rohár
2020-07-13 16:41 ` Lorenzo Pieralisi
2020-07-14 7:38 ` Pali Rohár
2020-07-15 12:17 ` Pali Rohár
2020-07-15 16:21 ` Lorenzo Pieralisi
2020-07-21 8:57 ` Pali Rohár [this message]
2020-07-21 10:48 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721085713.p2rbmucpk5ra3quw@pali \
--to=pali@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=contact@xogium.me \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.behun@nic.cz \
--cc=repk@triplefau.lt \
--cc=thomas.petazzoni@bootlin.com \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).