linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com
Subject: [boot-wrapper][PATCH] aarch64: Enable SPE for the non-secure world
Date: Fri, 31 Jul 2020 10:44:43 +0100	[thread overview]
Message-ID: <20200731094443.11564-1-alexandru.elisei@arm.com> (raw)

MDCR_EL3.NSPB resets to an UNKNOWN value. Configure it to allow the
profiling buffer to use non-secure memory and to permit direct register
accesses from the non-secure world.

So far, we haven't programmed MDCR_EL3 explicitly even though there are
other fields which reset to an UNKNOWN value. The majority of those, when
cleared, allow lower exception levels to use the features they control; for
the other fields we don't have support yet.  Reset the register to zero
with the exception of MDCR_EL3.NSPB.

Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
---
Tested on the model, with ARMv8.2 enabled and disabled (no SPE present).

 arch/aarch64/boot.S | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S
index 74705cded338..f821b0175d4b 100644
--- a/arch/aarch64/boot.S
+++ b/arch/aarch64/boot.S
@@ -55,6 +55,17 @@ _start:
 
 	msr	cptr_el3, xzr			// Disable copro. traps to EL3
 
+	mov	x0, xzr
+	mrs	x1, id_aa64dfr0_el1
+	ubfx	x1, x1, #32, #4
+	cbz	x1, 1f
+
+	// Enable SPE for the non-secure world.
+	ldr	x1, =(0x3 << 12)
+	orr	x0, x0, x1
+
+1:	msr	mdcr_el3, x0			// Disable traps to EL3
+
 	mrs	x0, id_aa64pfr0_el1
 	ubfx	x0, x0, #32, #4			// SVE present?
 	cbz	x0, 1f				// Skip SVE init if not
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-07-31  9:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  9:44 Alexandru Elisei [this message]
2020-08-06 10:42 ` [boot-wrapper][PATCH] aarch64: Enable SPE for the non-secure world André Przywara
2020-08-12 12:10 ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731094443.11564-1-alexandru.elisei@arm.com \
    --to=alexandru.elisei@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).