linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Device Tree Mailing List <devicetree@vger.kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Sekhar Nori <nsekhar@ti.com>, Tero Kristo <t-kristo@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/4] arm64: Initial support for Texas Instrument's J7200 Platform
Date: Mon, 7 Sep 2020 09:14:27 -0500	[thread overview]
Message-ID: <20200907141427.ti6r3h6namv2hezw@akan> (raw)
In-Reply-To: <de8d64eb-05fd-ed7d-61b8-1d8e13649ae8@ti.com>

On 17:32-20200907, Lokesh Vutla wrote:
> Hi,
> 
> On 27/08/20 12:21 pm, Lokesh Vutla wrote:
> > This series adds initial support for latest new SoC, J7200, from Texas Instruments.
> > 
> > The J7200 SoC is a part of the K3 Multicore SoC architecture platform.
> > It is targeted for for automotive gateway, vehicle compute systems,
> > Vehicle-to-Vehicle (V2V) and Vehicle-to-Everything (V2X) applications.
> > The SoC aims to meet the complex processing needs of modern embedded products.
> > 
> > See J7200 Technical Reference Manual (SPRUIU1, June 2020)
> > for further details: https://www.ti.com/lit/pdf/spruiu1
> > 
> > Changes since v1:
> > - Swapped Patch 1 and 2 as suggested by Nishanth.
> > - Added description for each SoC in yaml bindings.
> > 
> > Testing:
> > - ./scripts/checkpatch --strict
> > 	- Few warningns about Line length exceeding 100 columns.
> > 	  But these are corresponding to comments
> > - v8make dtbs_check
> > - DT_SCHEMA_FLAGS="-u"
> >   DT_SCHEMA_FILES="Documentation/devicetree/bindings/arm/ti/k3.yaml"
> >   v8make dtbs_check
> > - DT_SCHEMA_FLAGS="-u"
> >   DT_SCHEMA_FILES="Documentation/devicetree/bindings/arm/ti/k3.yaml"
> >   v8make dt_binding_check
> 
> This series has been lying around for soo long with no major comments. It will
> be nice to get this merged. I understand we are waiting for Acks on yaml
> documentation but it would be bad to miss a merge window for a new platform
> because we are waiting for Acks on yaml conversion.

I do require Rob / DT maintainer to ack the DT yaml conversion and the
j7200 binding addition.

Besides yaml and compatibility acks, there are a few ancillary
comments to fix up.. Kconfig -> I think we should either stay with
status quo and create a new config option per SoC OR rename the
config to be generic (using j7200 with j721e SoC config is not very
consistent). In addition, around the stuff that is going to next in
parallel, the dts is generating additional warnings as well (DSS
etc). I think it might be easier if we wait for DT maintainer ack on
bindings prior to giving further cosmetic comments (To allow for any
additional changes to come in to -next).

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-07 14:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  6:51 [PATCH v2 0/4] arm64: Initial support for Texas Instrument's J7200 Platform Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 1/4] dt-bindings: arm: ti: Convert K3 board/soc bindings to DT schema Lokesh Vutla
2020-08-28  0:41   ` Nishanth Menon
2020-08-28  3:14     ` Lokesh Vutla
2020-08-28  3:47       ` Suman Anna
2020-08-28 13:07       ` Nishanth Menon
2020-09-04 11:55       ` Nishanth Menon
2020-09-04  7:15   ` Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 2/4] dt-bindings: arm: ti: Add bindings for J7200 SoC Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 3/4] arm64: dts: ti: Add support " Lokesh Vutla
2020-08-27 17:04   ` Suman Anna
2020-09-08 11:47     ` Nishanth Menon
2020-08-31  9:13   ` Peter Ujfalusi
2020-09-02  3:51     ` Lokesh Vutla
2020-08-27  6:51 ` [PATCH v2 4/4] arm64: dts: ti: Add support for J7200 Common Processor Board Lokesh Vutla
2020-09-08 11:57   ` Nishanth Menon
2020-08-27  9:09 ` [PATCH v2 0/4] arm64: Initial support for Texas Instrument's J7200 Platform Grygorii Strashko
2020-09-07 12:02 ` Lokesh Vutla
2020-09-07 14:14   ` Nishanth Menon [this message]
2020-09-07 14:23     ` Lokesh Vutla
2020-09-07 23:48       ` Nishanth Menon
2020-09-08  9:55         ` Tero Kristo
2020-09-08 11:25           ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907141427.ti6r3h6namv2hezw@akan \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).