From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "kernelci-results@groups.io" <kernelci-results@groups.io>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Nicolas Pitre <nico@fluxnic.net>,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: next/master bisection: baseline.login on rk3288-rock2-square
Date: Thu, 4 Feb 2021 10:47:15 +0000 [thread overview]
Message-ID: <20210204104714.GU1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAMj1kXFog3=5zD7+P=cRfRLj1xfD1h1kU58iifASBSXkRe-E6g@mail.gmail.com>
On Thu, Feb 04, 2021 at 11:27:16AM +0100, Ard Biesheuvel wrote:
> Hi Russell,
>
> If Guillaume is willing to do the experiment, and it fixes the issue,
> it proves that rk3288 is relying on the flush before the MMU is
> disabled, and so in that case, the fix is trivial, and we can just
> apply it.
>
> If the experiment fails (which would mean rk3288 does not tolerate the
> cache maintenance being performed after cache off), it is going to be
> hairy, and so it will definitely take more time.
>
> So in the latter case (or if Guillaume does not get back to us), I
> think reverting my queued fix is the only sane option. But in that
> case, may I suggest that we queue the revert of the original by-VA
> change for v5.12 so it gets lots of coverage in -next, and allows us
> an opportunity to come up with a proper fix in the same timeframe, and
> backport the revert and the subsequent fix as a pair? Otherwise, we'll
> end up in the situation where v5.10.x until today has by-va, v5.10.x-y
> has set/way, and v5.10y+ has by-va again. (I don't think we care about
> anything before that, given that v5.4 predates any of this)
I'm suggesting dropping your fix (9052/1) and reverting
"ARM: decompressor: switch to by-VA cache maintenance for v7 cores"
which gets us to a point where _both_ regressions are fixed.
I'm of the opinion that the by-VA patch was incorrect when it was
merged (it caused a regression), and it's only a performance
improvement. Our attempts so far to fix it are just causing other
regressions. So, I think it is reasonable to revert both back to a
known good point which has worked over a decade. If doing so causes
regressions (which I think is unlikely), then that would be unfortunate
but alas is a price that's worth paying to get back to a known good
point - since then we're not stacking regression fixes on top of other
regression fixes.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-04 10:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <601b773a.1c69fb81.9f381.a32a@mx.google.com>
2021-02-04 8:43 ` next/master bisection: baseline.login on rk3288-rock2-square Guillaume Tucker
2021-02-04 9:07 ` Ard Biesheuvel
2021-02-04 10:06 ` Russell King - ARM Linux admin
2021-02-04 10:27 ` Ard Biesheuvel
2021-02-04 10:33 ` Guillaume Tucker
2021-02-04 11:32 ` Guillaume Tucker
2021-02-04 11:44 ` Russell King - ARM Linux admin
2021-02-04 12:09 ` Ard Biesheuvel
2021-02-04 15:42 ` Ard Biesheuvel
2021-02-04 15:53 ` Guillaume Tucker
2021-02-04 16:01 ` Ard Biesheuvel
2021-02-04 18:06 ` Nick Desaulniers
2021-02-04 18:12 ` Nathan Chancellor
2021-02-04 18:23 ` Nick Desaulniers
2021-02-04 21:31 ` Guillaume Tucker
2021-02-04 21:50 ` Russell King - ARM Linux admin
2021-02-05 8:21 ` Ard Biesheuvel
2021-02-05 12:05 ` Ard Biesheuvel
2021-02-06 13:10 ` Guillaume Tucker
2021-02-06 13:12 ` Ard Biesheuvel
2021-02-04 21:09 ` Guillaume Tucker
2021-02-04 10:47 ` Russell King - ARM Linux admin [this message]
2021-02-04 10:55 ` Ard Biesheuvel
2021-02-04 12:26 ` Marc Zyngier
2021-02-04 14:09 ` Russell King - ARM Linux admin
2021-02-04 14:25 ` Ard Biesheuvel
2021-02-04 14:36 ` Russell King - ARM Linux admin
2021-02-04 15:52 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204104714.GU1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=geert+renesas@glider.be \
--cc=guillaume.tucker@collabora.com \
--cc=kernelci-results@groups.io \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).