From: Nathan Chancellor <nathan@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Robin Murphy <robin.murphy@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Maxime Ripard <maxime@cerno.tech>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] ARM: keystone: fix integer overflow warning
Date: Tue, 23 Mar 2021 11:24:36 -0700 [thread overview]
Message-ID: <20210323182436.5uxkjtgee3eoldvo@archlinux-ax161> (raw)
In-Reply-To: <20210323131814.2751750-1-arnd@kernel.org>
On Tue, Mar 23, 2021 at 02:18:05PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang warns about an impossible condition when building with 32-bit
> phys_addr_t:
>
> arch/arm/mach-keystone/keystone.c:79:16: error: result of comparison of constant 51539607551 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> mem_end > KEYSTONE_HIGH_PHYS_END) {
> ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~
> arch/arm/mach-keystone/keystone.c:78:16: error: result of comparison of constant 34359738368 with expression of type 'phys_addr_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare]
> if (mem_start < KEYSTONE_HIGH_PHYS_START ||
> ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
>
> Change the temporary variable to a fixed-size u64 to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/arm/mach-keystone/keystone.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
> index cd711bfc591f..2c647bdf8d25 100644
> --- a/arch/arm/mach-keystone/keystone.c
> +++ b/arch/arm/mach-keystone/keystone.c
> @@ -65,7 +65,7 @@ static void __init keystone_init(void)
> static long long __init keystone_pv_fixup(void)
> {
> long long offset;
> - phys_addr_t mem_start, mem_end;
> + u64 mem_start, mem_end;
>
> mem_start = memblock_start_of_DRAM();
> mem_end = memblock_end_of_DRAM();
> @@ -78,7 +78,7 @@ static long long __init keystone_pv_fixup(void)
> if (mem_start < KEYSTONE_HIGH_PHYS_START ||
> mem_end > KEYSTONE_HIGH_PHYS_END) {
> pr_crit("Invalid address space for memory (%08llx-%08llx)\n",
> - (u64)mem_start, (u64)mem_end);
> + mem_start, mem_end);
> return 0;
> }
>
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-23 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:18 [PATCH] ARM: keystone: fix integer overflow warning Arnd Bergmann
2021-03-23 17:56 ` Santosh Shilimkar
2021-03-23 18:24 ` Nathan Chancellor [this message]
2021-04-01 10:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323182436.5uxkjtgee3eoldvo@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=maxime@cerno.tech \
--cc=ndesaulniers@google.com \
--cc=robin.murphy@arm.com \
--cc=soc@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).