From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF229C433ED for ; Fri, 16 Apr 2021 19:26:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 177AE611AF for ; Fri, 16 Apr 2021 19:26:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 177AE611AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=vSvg09z0MsGzYXSRzQJA2YSzxQK5zN1f/rXQY8uZaqs=; b=oyHz7AOjBSAt/IYYwFfhNvzKi u7pClZZt2iMNBqrFhPl8VXDt3jBL9yfD0k4LPEANhmHUEKvIqS008q4d2oGEGoyuqloVVEAEU8gjo Qbq7XLoS1trZErQD+0zBHRY0IYt2v15f8vpinszOhjswmSWufXAB84LMjRXjNABKVsLCtOlq82MTC epY2UmnHdTAw0UJ8Aif/aQKL4t8UqtRvL5ooPpF2USUb3q+ywYVnNVAsSRcUPtG/SGVAqsNKzgvbo Kj408VY5Y9Y0RXIgQGcdU4mVhZflqjfwjiBLzLLDAWNggOOTeefymRxoj2mgFELxnw2w3QSJZ9li7 AHcUFT+vg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXU4e-003D7b-Ck; Fri, 16 Apr 2021 19:24:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXU4b-003D7M-Hm; Fri, 16 Apr 2021 19:24:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To :Content-ID:Content-Description:References; bh=Y4CGOQ3VVzVOoh+l3/YBmQlewKvatoJkaq/GIU/YJuU=; b=JHJWc0gvVaN9uvkH+msk4TWR/K 5xx/ZwG8xYt2ZVQJXDxlu2/omLX0XkKhLbkwzSLdQhZ3hbWk8Mj/rsdYNVS5DkmnUuyrVo5JbK5Ra Jvn6H0wGXkqDPdXpyLkJsfNuuVtkeJRWaZ5cavWL9OOrM/KZbMiYzHRWopiqfbLqf13PHeLHY5AcZ J9T56B8s4JIPSAQ9CKpWIfI0Vh56oMN+5GfkHrXrAfaCHOMF4nonIGHBdzQ7LyfHy5xC//wjub0G+ 3Mi/J+qgrVtg9zq+4S2eXGY+v1agV/lcU7ID0p0KDfc0lsBG68pGrsbjawNM3xYMAA7BkAxqw3K1E gC2yPo/w==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXU4Z-009ecW-2W; Fri, 16 Apr 2021 19:24:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B84B6137D; Fri, 16 Apr 2021 19:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618601050; bh=qHawK0oSTOLvJhEkLLbelkvEtYDRemD5y/71PvXJsow=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=i+nsE09tHA0GPcdM2/MeTaNM0szdQ0WdGtOryocd2mlqAtBAPS//L0i0bzZXsO8/u fkLV7Gvab0QGNzDId6j792QJPu/gog3Dicsi9l6jZFfqUa3Plj723IeLds1pJpEKyr 6OgPJZied02D4CRJM27ck/2DbUH0P6noqZEX7ncjo7RzthjBNAzaObjGEgxy17r7VL +SzfZO2eKYv3O9Q0TMm2hz5GTNKJ/yfV2ONFoik610B/49nvK59V7cy8m7CfnUYsqV 5lioX2gDeS8C6LthsG8R30YIzz9snIrCPJCSf5aLBXNxUvo3ks8yjt+OS6lELHHJwv 0hfkytCmujThA== Date: Fri, 16 Apr 2021 14:24:09 -0500 From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Bjorn Helgaas , Jianjun Wang , Rob Herring , Marc Zyngier , Ryder Lee , Philipp Zabel , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com, drinkcat@chromium.org, Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com, Krzysztof Wilczyski Subject: Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use Message-ID: <20210416192409.GA2744791@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210413095257.GA21802@lpieralisi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_122411_172698_600CB567 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 10:53:05AM +0100, Lorenzo Pieralisi wrote: > On Wed, Mar 24, 2021 at 10:09:42AM +0100, Pali Roh=E1r wrote: > > On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote: > > > This interface will be used by PCI host drivers for PIO translation, > > > export it to support compiling those drivers as kernel modules. > > > = > > > Signed-off-by: Jianjun Wang > > > --- > > > drivers/pci/pci.c | 1 + > > > 1 file changed, 1 insertion(+) > > > = > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > > index 16a17215f633..12bba221c9f2 100644 > > > --- a/drivers/pci/pci.c > > > +++ b/drivers/pci/pci.c > > > @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pi= o) > > > = > > > return address; > > > } > > > +EXPORT_SYMBOL(pci_pio_to_address); > > = > > Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0 > > header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe > > other people would know what is correct? > = > I think this should be EXPORT_SYMBOL_GPL(), I can make this change > but this requires Bjorn's ACK to go upstream (Bjorn, it is my fault, > it was assigned to me on patchwork, now updated, please have a look). Yep, looks good to me, and I agree it should be EXPORT_SYMBOL_GPL(). Acked-by: Bjorn Helgaas > > > = > > > unsigned long __weak pci_address_to_pio(phys_addr_t address) > > > { > > > -- = > > > 2.25.1 > > > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel