From: Catalin Marinas <catalin.marinas@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ardb@kernel.org>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: Force SPARSEMEM_VMEMMAP as the only memory management model
Date: Wed, 21 Apr 2021 14:02:37 +0100 [thread overview]
Message-ID: <20210421130235.GC18635@arm.com> (raw)
In-Reply-To: <fe4bb655-80bb-d142-f352-89e9c52a90c5@arm.com>
On Wed, Apr 21, 2021 at 10:18:56AM +0530, Anshuman Khandual wrote:
> On 4/20/21 3:05 PM, Catalin Marinas wrote:
> > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
> > index b943879c1c24..15018dc59554 100644
> > --- a/arch/arm64/include/asm/memory.h
> > +++ b/arch/arm64/include/asm/memory.h
> > @@ -329,7 +329,7 @@ static inline void *phys_to_virt(phys_addr_t x)
> > */
> > #define ARCH_PFN_OFFSET ((unsigned long)PHYS_PFN_OFFSET)
> >
> > -#if !defined(CONFIG_SPARSEMEM_VMEMMAP) || defined(CONFIG_DEBUG_VIRTUAL)
> > +#if defined(CONFIG_DEBUG_VIRTUAL)
>
> A small nit. Should this be #ifdef CONFIG_DEBUG_VIRTUAL instead ?
Yeah, for consistency I changed it to #ifdef.
> This is
> an user selectable config and the conditional check here does not have an
> #elseif part either. But then there are similar such instances else where
> on arm64 platform as well.
I'm not sure I get it. What would an #elseif need to check? We already
have an #else block for this #ifdef.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-21 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:35 [PATCH] arm64: Force SPARSEMEM_VMEMMAP as the only memory management model Catalin Marinas
2021-04-20 10:19 ` Will Deacon
2021-04-20 10:28 ` Ard Biesheuvel
2021-04-20 10:47 ` Marc Zyngier
2021-04-21 4:48 ` Anshuman Khandual
2021-04-21 13:02 ` Catalin Marinas [this message]
2021-04-22 3:04 ` Anshuman Khandual
2021-04-22 10:08 ` Mike Rapoport
2021-04-23 17:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421130235.GC18635@arm.com \
--to=catalin.marinas@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).