From: Mark Brown <broonie@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Robin Gong <yibin.gong@nxp.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, Takashi Iwai <tiwai@suse.com>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe
Date: Wed, 21 Apr 2021 18:46:29 +0100 [thread overview]
Message-ID: <20210421174629.GD4617@sirena.org.uk> (raw)
In-Reply-To: <18fbdc4bf0574a722134400ad9e4510d3cbcb767.camel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]
On Wed, Apr 21, 2021 at 07:43:18PM +0200, Lucas Stach wrote:
> If your driver code drops the rpm refcount to 0 and starts the
> autosuspend timer while a cyclic transfer is still in flight this is
> clearly a bug. Autosuspend is not there to paper over driver bugs, but
> to amortize cost of actually suspending and resuming the hardware. Your
> driver code must still work even if the timeout is 0, i.e. the hardware
> is immediately suspended after you drop the rpm refcount to 0.
> If you still have transfers queued/in-flight the driver code must keep
> a rpm reference.
Right, failing to do that is a clear bug.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-21 17:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 9:41 [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe Shengjiu Wang
2020-05-19 10:01 ` Lucas Stach
2020-05-20 8:20 ` Shengjiu Wang
2020-05-20 9:42 ` Lucas Stach
2020-05-20 11:22 ` Shengjiu Wang
2020-05-20 12:38 ` Mark Brown
2020-05-21 11:30 ` Shengjiu Wang
2020-05-22 13:12 ` Mark Brown
2021-04-14 14:33 ` Robin Gong
2021-04-14 15:33 ` Lucas Stach
2021-04-19 7:17 ` Robin Gong
2021-04-19 9:46 ` Lucas Stach
2021-04-20 13:47 ` Robin Gong
2021-04-20 14:00 ` Lucas Stach
2021-04-21 14:54 ` Robin Gong
2021-04-21 17:43 ` Lucas Stach
2021-04-21 17:46 ` Mark Brown [this message]
2021-04-22 3:33 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421174629.GD4617@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=sumit.semwal@linaro.org \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).