From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE10C433B4 for ; Mon, 26 Apr 2021 15:48:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE4896044F for ; Mon, 26 Apr 2021 15:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4896044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qj2OugRr05BmJv2uODYHeBOl44JNlY8/YbZgM0rZgpA=; b=qcG/m2Rd9BtuZvPJDZ2P3WWa7 57T0vfdpjjk1iT6Ga5qsmF2+lai2XYpSralF81FBWz3cRAUhb6EkYuqXCxR/Jn02vcZEPYGLwyQn1 d+9v3fS/V/iPN3/75fOh7sotVVZnR2VnXIxFJV7iL/SrqbiZb2Y10qa/ZdI6XagOpnO1/Ksa4Ew4t gKKOF5dAE/EK3/Tj68dbenwokKzUrOICRtMHp29Yy2uJHtoId1YMxtmcPeY2rlLg4QR3MlyLhltmj XgX1d6WCZhLOAKyysBNgmjBmm9YPCbFyqWydeuCj35KpXqS17Ei5DD/aUrUCcC4eqRj7w6kncgH8X ATayXPRvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb3RU-007zzi-8x; Mon, 26 Apr 2021 15:46:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb3RS-007zzT-KW for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 15:46:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XboSkOHKR9/omD6ZttgG6rHiaNOqxSSs13MhhHHn3Q8=; b=MgIz3yVjhEWHkpGHYIeYdXOfRV Kqho0giVjlxA1sLlekIf/N2UV6y0yuJTshA/llgRtQlK75fcnmJDrh1Ah6y645KK7rylL/5Wd+072 eSrnlqFshwjw3s0Zou4mZY+Qm7RJ5jvna37KoZBWlcYzbLNr/nZ8OoNW8AAFgZ4WUfBc3yuOrJPhB r7Jip2301svve3CZ+mqKyshcbuWdEp68Wa4YH21z1nvFVSzFsH7JukoYqbVyke3SXFqsQJM7GSRCL l07Gwc8TxDx5Yu1Te/IyaRzHcVv66mnt5Pia/i0hOSMAAJskolO1X5OxX+L2Yv++dBcuR0M2RlVM+ 8g/0jwZQ==; Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb3RP-00G3bL-8P for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 15:46:33 +0000 Received: by mail-pj1-x102e.google.com with SMTP id gq23-20020a17090b1057b0290151869af68bso5426997pjb.4 for ; Mon, 26 Apr 2021 08:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XboSkOHKR9/omD6ZttgG6rHiaNOqxSSs13MhhHHn3Q8=; b=UEXS2RhtQolFovqX/XpJa76Q2uluJRmWviDsMo0fYexASUQ/ezJkgmKgTVryWlIjrz chfHnMTbX7evnziBTSHx6XHxj8o3eTCPblueemJosyU0FVomdoyXVZPBp2UhyYQRZGsl CZls1NpVRWdlhJe1h0KNqg7D10LOwJ8VGVNl2vTC49vo4Ab8Y1/2P3TU1YEyswdPWOHL AbzL1D4gzqwF1nDF1A/WoR7eOL6T+dy0YXiYfW2Cl7eSiejrcjx7RfjriEPQoXVLIgtE tPhiLqfy+Lq/zQvzSakB9skJqXWynsd9/ukdDmMD3FF7goWvCblhXgyYpSg3U5XxKGHv 394Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XboSkOHKR9/omD6ZttgG6rHiaNOqxSSs13MhhHHn3Q8=; b=lva785mrr7mBTqNn/pAbAFkZqQ8PFtWP7rjmXJuNtXwJ9qTGBpnxK8gdBllcMlqUVe iI+UrBBtucOlA81qxd5wCbgIogGb+vFoJh1fL0vIDTCWEyJ9sSFy1xTtDPdNCbef0h9I tzC5tmECaFfFnLYHLpQaT37NlHqRU7fthwYeHuF6jG95CmjVNaXC5ow8uvpMVwZO9+TD /xTgs4D84o7DI49E1Z9bX+ku3OkrdHJxJQQEnf9421ht35IHAGoabXa4bZ5l218MHFoQ v3yKTlX6LnVDjAbNmvxd8jFVgVsHVQ4QNXxNWhvQaF6w0CKdVKkp4OY2TnAsfbgPsWBK P0/w== X-Gm-Message-State: AOAM5337FxkK8FPWC03cYcdrSU3SgNCHhVfheyD+A8mRutokiLYefnEg P6cQdnuydx3OjbrwLi4g8QQKLQ== X-Google-Smtp-Source: ABdhPJy9MuB/wX9vtocSRPHn1bJgP98qSCnlf713nL2qGwOuiFCiq9/GIdHNktP7TMmxwgegzvZiwA== X-Received: by 2002:a17:902:e993:b029:ec:7cc0:9390 with SMTP id f19-20020a170902e993b02900ec7cc09390mr19195578plb.27.1619451987215; Mon, 26 Apr 2021 08:46:27 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 20sm151931pfw.40.2021.04.26.08.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 08:46:26 -0700 (PDT) Date: Mon, 26 Apr 2021 09:46:23 -0600 From: Mathieu Poirier To: Peng Fan Cc: "Peng Fan (OSS)" , "ohad@wizery.com" , "bjorn.andersson@linaro.org" , "o.rempel@pengutronix.de" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP Message-ID: <20210426154623.GA1390475@xps15> References: <1618971622-30539-1-git-send-email-peng.fan@oss.nxp.com> <20210422165634.GD1256950@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_084631_328323_DC0C110C X-CRM114-Status: GOOD ( 37.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 23, 2021 at 11:28:00PM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support > > i.MX7ULP/8MN/8MP > > > > On Thu, 22 Apr 2021 at 19:01, Peng Fan wrote: > > > > > > Hi Mathieu, > > > > > > > Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support > > > > i.MX7ULP/8MN/8MP > > > > > > > > On Wed, Apr 21, 2021 at 10:20:14AM +0800, peng.fan@oss.nxp.com > > wrote: > > > > > From: Peng Fan > > > > > > > > > > V5: > > > > > Add R-b tag > > > > > Move the change in detect mode of patch 5 to patch 7 Per > > > > > Mathieu's comments > > > > > > > > > > V4: > > > > > Typo fix > > > > > patch 4: take state as a check condition patch 5: move regmap > > > > > lookup/attach to imx_rproc_detect_mode patch 6: add > > > > > imx_rproc_clk_enable for optional clk patch 8: use switch/case in > > > > > imx_rproc_detect_mode > > > > > V3: > > > > > Add A-b tag for Patch 1/2 > > > > > Fix the checkpatch warning for Patch 6,8 > > > > > > > > > > V2: > > > > > Patch 1/8, use fsl as vendor, typo fix Because patchset [1] has > > > > > v2 version, patch 5,6,7,8 are adapted that change. > > > > > > > > > > This patchset is to support i.MX7ULP/8MN/8MP, also includes a > > > > > patch to parse fsl,auto-boot > > > > > > > > > > > > > One of the request I had from the last revision was to explicitly > > > > list what other patchset this work depends on and what branch it is > > > > based of, something I can't find here. > > > > > > Sorry, that patchset has been merged, so I remove that line. > > > I should mention that that patchset has been merged into Linux-next tree. > > > > > > > And what branch this set should be applied to is missing. > > I take latest linux-next/master for my upstream new feature work. > > > > > > > > > > > As such I am dropping this set and won't look at another revision > > > > before May 22nd. > > > > > > Ah. Is it just because that the dependency patchset not been mentioned > > > or you have issue applying the patchset that delay the patchset for one > > month? > > > > > > > Both. > > I replay my flow: > git fetch linux-next > git checkout linux-next/master -b master-next-4-24-2021 > pwclient list -w "Peng Fan (OSS)" -s New | grep V5 | awk '{print $1}' | xargs -I {} pwclient git-am {} > > It could successfully apply the patchset. > Applying patch #12215291 using 'git am' > Description: [V5,1/8] dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property > Applying: dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property > Applying patch #12215293 using 'git am' > Description: [V5,2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support > Applying: dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support > Applying patch #12215295 using 'git am' > Description: [V5,3/8] dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P > Applying: dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P > Applying patch #12215297 using 'git am' > Description: [V5,4/8] remoteproc: imx_rproc: parse fsl,auto-boot > Applying: remoteproc: imx_rproc: parse fsl,auto-boot > Applying patch #12215299 using 'git am' > Description: [V5,5/8] remoteproc: imx_rproc: initial support for mutilple start/stop method > Applying: remoteproc: imx_rproc: initial support for mutilple start/stop method > Applying patch #12215301 using 'git am' > Description: [V5,6/8] remoteproc: imx_rproc: make clk optional > Applying: remoteproc: imx_rproc: make clk optional > Applying patch #12215303 using 'git am' > Description: [V5,7/8] remoteproc: imx_rproc: support i.MX7ULP > Applying: remoteproc: imx_rproc: support i.MX7ULP > Applying patch #12215305 using 'git am' > Description: [V5,8/8] remoteproc: imx_rproc: support i.MX8MN/P > Applying: remoteproc: imx_rproc: support i.MX8MN/P > > > If anything wrong my work flow conflicts with Linux remoteproc subsystem upstream flow, > please correct me, and I'll follow. > > Thanks for your time and patience on reviewing my patches. Sorry for the inconvince > that I bring in. > > Anyway please share me your flow to apply patches, I will try to avoid unhappy things > in following patches. > All I asked is that you list the branch your work is based on _and_ any dependencies, something you did not do. I review hundreds of patchsets every year and knowing exactly how to work with a series goes a long way in saving precious time, time that can be used to review other people's submissions. I am not angry at you but at the same time I can't review your patches if you are not ready to help me do so. > Thanks, > Peng. > > > > > > Thanks, > > > Peng. > > > > > > > > > > > > Peng Fan (8): > > > > > dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property > > > > > dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support > > > > > dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P > > > > > remoteproc: imx_rproc: parse fsl,auto-boot > > > > > remoteproc: imx_rproc: initial support for mutilple start/stop method > > > > > remoteproc: imx_rproc: make clk optional > > > > > remoteproc: imx_rproc: support i.MX7ULP > > > > > remoteproc: imx_rproc: support i.MX8MN/P > > > > > > > > > > .../bindings/remoteproc/fsl,imx-rproc.yaml | 11 +- > > > > > drivers/remoteproc/imx_rproc.c | 196 > > > > +++++++++++++++--- > > > > > 2 files changed, 173 insertions(+), 34 deletions(-) > > > > > > > > > > -- > > > > > 2.30.0 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel