From: Catalin Marinas <catalin.marinas@arm.com>
To: Luo Longjun <luolongjun@huawei.com>
Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sangyan@huawei.com,
ningyu9@huawei.com, luchunhua@huawei.com,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP
Date: Tue, 11 May 2021 18:20:20 +0100 [thread overview]
Message-ID: <20210511172020.GB21033@arm.com> (raw)
In-Reply-To: <20210507182410.10515-1-luolongjun@huawei.com>
On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote:
> When I compile kernel in ARM64, it produces the following output:
>
> *** Default configuration is based on 'defconfig'
> arch/arm64/configs/defconfig:1018:warning: override: reassigning to
> symbol MTK_PMIC_WRAP
>
> After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options.
>
> Signed-off-by: Luo Longjun <luolongjun@huawei.com>
> ---
> arch/arm64/configs/defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 08c6f769df9a..9907a431db0d 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y
> CONFIG_SPI_SH_MSIOF=m
> CONFIG_SPI_SUN6I=y
> CONFIG_SPI_SPIDEV=m
> -CONFIG_MTK_PMIC_WRAP=m
> CONFIG_SPMI=y
> CONFIG_PINCTRL_SINGLE=y
> CONFIG_PINCTRL_MAX77620=y
Adding Matthias and Enric. This change looks fine to me but I think it
should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m
option while commit fbbe38309d56 introduced the =y variant.
You could add:
Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb")
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-11 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:24 [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP Luo Longjun
2021-05-11 17:20 ` Catalin Marinas [this message]
2021-05-11 20:04 ` Enric Balletbo i Serra
2021-05-14 7:42 ` Matthias Brugger
2021-06-11 21:39 ` Petr Vorel
2021-06-14 8:58 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511172020.GB21033@arm.com \
--to=catalin.marinas@arm.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luchunhua@huawei.com \
--cc=luolongjun@huawei.com \
--cc=matthias.bgg@gmail.com \
--cc=ningyu9@huawei.com \
--cc=sangyan@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).