From: Alain Volmat <alain.volmat@foss.st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: <linux-kernel@vger.kernel.org>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues
Date: Fri, 21 May 2021 16:17:57 +0200 [thread overview]
Message-ID: <20210521141757.GA17641@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20210520190105.3772683-14-lee.jones@linaro.org>
Thanks for the fix. I was about to propose it ;)
On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead
> drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead
>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/i2c/busses/i2c-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index faa81a95551fe..30089b38044b5 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev)
> }
>
> /**
> - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read
> + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read
Could you also fix the typo enmpty -> empty at the same time ?
> * @i2c_dev: Controller's private data
> */
> static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev)
> @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev)
> }
>
> /**
> - * st_i2c_isr() - Interrupt routine
> + * st_i2c_isr_thread() - Interrupt routine
> * @irq: interrupt number
> * @data: Controller's private data
> */
> --
> 2.31.1
>
Regards,
Alain
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-21 14:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210520190105.3772683-1-lee.jones@linaro.org>
2021-05-20 19:00 ` [PATCH 01/16] i2c: busses: i2c-nomadik: Fix formatting issue pertaining to 'timeout' Lee Jones
2021-05-27 0:21 ` Linus Walleij
2021-05-27 19:28 ` Wolfram Sang
2021-05-28 7:58 ` Lee Jones
2021-05-28 8:00 ` Wolfram Sang
2021-05-28 8:17 ` Lee Jones
2021-05-20 19:00 ` [PATCH 06/16] i2c: busses: i2c-cadence: Fix incorrectly documented 'enum cdns_i2c_slave_mode' Lee Jones
2021-05-24 6:49 ` Michal Simek
2021-05-20 19:00 ` [PATCH 09/16] i2c: busses: i2c-mxs: Demote barely half complete kernel-doc header Lee Jones
2021-06-03 20:29 ` Wolfram Sang
2021-06-04 8:47 ` Lee Jones
2021-06-04 9:06 ` Wolfram Sang
2021-06-04 9:32 ` Lee Jones
2021-05-20 19:01 ` [PATCH 11/16] i2c: busses: i2c-pnx: Provide descriptions for 'alg_data' data structure Lee Jones
2021-05-21 6:24 ` Vladimir Zapolskiy
2021-05-20 19:01 ` [PATCH 12/16] i2c: busses: i2c-rk3x: Demote unworthy headers and help more complete ones Lee Jones
2021-05-20 21:52 ` Heiko Stübner
2021-05-21 6:56 ` Lee Jones
2021-06-19 22:07 ` Heiko Stuebner
2021-05-20 19:01 ` [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function misnaming issues Lee Jones
2021-05-21 14:17 ` Alain Volmat [this message]
2021-05-21 14:23 ` Alain Volmat
2021-05-27 19:35 ` Wolfram Sang
2021-05-20 19:01 ` [PATCH 14/16] i2c: busses: i2c-stm32f4: Remove incorrectly placed ' ' from function name Lee Jones
2021-05-21 14:20 ` Alain Volmat
2021-05-27 19:35 ` Wolfram Sang
2021-05-20 19:01 ` [PATCH 16/16] i2c: busses: i2c-st: trivial: Fix spelling issue 'enmpty => empty' Lee Jones
2021-05-21 14:23 ` Alain Volmat
2021-05-27 19:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521141757.GA17641@gnbcxd0016.gnb.st.com \
--to=alain.volmat@foss.st.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).