Re: [PATCH v7 4/5] firmware: arm_ffa: Setup in-kernel users of FFA partitions

From: Sudeep Holla <sudeep.holla@arm.com>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: "Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Arve Hjønnevåg" <arve@google.com>,
	"Andrew Walbran" <qwandor@google.com>,
	"David Hartley" <dhh@qti.qualcomm.com>,
	"Achin Gupta" <Achin.Gupta@arm.com>,
	"Arunachalam Ganapathy" <arunachalam.ganapathy@arm.com>,
	"Marc Bonnici" <marc.bonnici@arm.com>
Subject: Re: [PATCH v7 4/5] firmware: arm_ffa: Setup in-kernel users of FFA partitions
Date: Tue, 25 May 2021 10:02:34 +0100	[thread overview]
Message-ID: <20210525090225.eup3nyszigxepyj5@bogus> (raw)
In-Reply-To: <CAHUa44FqpTq87snH+yowQwVXbLE-tzfMCvK01L+uCv=XbPoJJg@mail.gmail.com>

On Tue, May 25, 2021 at 08:29:42AM +0200, Jens Wiklander wrote:
> On Fri, May 21, 2021 at 5:10 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > Parse the FFA nodes from the device-tree and register all the partitions
> > whose services will be used in the kernel.
> >
> > In order to also enable in-kernel users of FFA interface, let us add
> > simple set of operations for such devices.
> >
> > The in-kernel users are registered without the character device interface.
> >
> > Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
> > Tested-by: Jens Wiklander <jens.wiklander@linaro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> >  drivers/firmware/arm_ffa/bus.c    |   9 ++
> >  drivers/firmware/arm_ffa/common.h |   3 +
> >  drivers/firmware/arm_ffa/driver.c | 220 ++++++++++++++++++++++++++++++
> >  include/linux/arm_ffa.h           |  38 +++++-
> >  4 files changed, 269 insertions(+), 1 deletion(-)
> >
> [snip]
> > --- a/include/linux/arm_ffa.h
> > +++ b/include/linux/arm_ffa.h
> > @@ -6,7 +6,6 @@
> >  #ifndef _LINUX_ARM_FFA_H
> >  #define _LINUX_ARM_FFA_H
> >
> > -#include <linux/cdev.h>
> >  #include <linux/device.h>
> >  #include <linux/module.h>
> >  #include <linux/types.h>
> > @@ -15,6 +14,7 @@
> >  /* FFA Bus/Device/Driver related */
> >  struct ffa_device {
> >         int vm_id;
> > +       bool mode_32bit;
> >         uuid_t uuid;
> >         struct device dev;
> >  };
> > @@ -48,6 +48,7 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner,
> >                         const char *mod_name);
> >  void ffa_driver_unregister(struct ffa_driver *driver);
> >  bool ffa_device_is_valid(struct ffa_device *ffa_dev);
> > +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev);
> >
> >  #else
> >  static inline
> > @@ -70,6 +71,10 @@ static inline void ffa_driver_unregister(struct ffa_driver *driver) {}
> >  static inline
> >  bool ffa_device_is_valid(struct ffa_device *ffa_dev) { return false; }
> >
> > +const struct ffa_dev_ops *ffa_dev_ops_get(struct ffa_device *dev)
> 
> I believe this should be static inline.

Thanks for pointing this out, indeed. I blame copy paste 😄. 

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel