From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39246C4320A for ; Wed, 28 Jul 2021 11:43:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 210B360F9D for ; Wed, 28 Jul 2021 11:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iy8Ahjro72EUQHnLvuKWcbt81HKvF2xprohpr6yQLeo=; b=LxkAVx9BL/J21/ m+IhZyGN5itM4vYh0JY4wJTSlYdnK/J7F5R9SzCAIwrqLZXeMjqELle4nXlMUtUF8KQ/PnIFnpkdA 196Cnjk0HRyMK/eWATHycL8XkoP7Q1z3MHbPV1ejN30ZDrQFaIpTBsBemljKWhzk4diLzG77PdRhX kwXkFjAA+IFdIortw/l1gBjN1/OivT8x2atQHVSOlsxANJ1vjC/HTqN3oftoH32Lm51MvvYTErIz0 lKSnD6mdONfGWZYk6c9jXSzipDhS8E30fInCLTVqJcEJ+idaTwAALlbzvgXtIbk+umJcb5j7ElwqD H5nxoOlBEr3X93pkhi5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8hwc-000YZ7-MZ; Wed, 28 Jul 2021 11:41:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8hwY-000YYT-Kc for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 11:41:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A75D31B; Wed, 28 Jul 2021 04:41:38 -0700 (PDT) Received: from bogus (unknown [10.57.37.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BEEA33F66F; Wed, 28 Jul 2021 04:41:34 -0700 (PDT) Date: Wed, 28 Jul 2021 12:40:18 +0100 From: Sudeep Holla To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Sudeep Holla , Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 05/17] firmware: arm_scmi: Add transport optional init/exit support Message-ID: <20210728114018.i7fquzpgfl4qv6tm@bogus> References: <20210712141833.6628-1-cristian.marussi@arm.com> <20210712141833.6628-6-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210712141833.6628-6-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_044146_821883_54608B08 X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 12, 2021 at 03:18:21PM +0100, Cristian Marussi wrote: > Some SCMI transport could need to perform some transport specific setup > before they can be used by the SCMI core transport layer: typically this > early setup consists in registering with some other kernel subsystem. > > Add the optional capability for a transport to provide a couple of .init > and .exit functions that are assured to be called early during the SCMI > core initialization phase, well before the SCMI core probing step. > > [ Peter: Adapted RFC patch by Cristian for submission to upstream. ] > Signed-off-by: Peter Hilber > [ Cristian: Fixed scmi_transports_exit point of invocation ] > Signed-off-by: Cristian Marussi > --- > v4 --> V5 > - removed useless pr_debug > - moved scmi_transport_exit() invocation > --- > drivers/firmware/arm_scmi/common.h | 8 +++++ > drivers/firmware/arm_scmi/driver.c | 56 ++++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 7c2b9fd7e929..6bb734e0e3ac 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -321,6 +321,12 @@ struct scmi_device *scmi_child_dev_find(struct device *parent, > /** > * struct scmi_desc - Description of SoC integration > * > + * @init: An optional function that a transport can provide to initialize some > + * transport-specific setup during SCMI core initialization, so ahead of > + * SCMI core probing. > + * @exit: An optional function that a transport can provide to de-initialize > + * some transport-specific setup during SCMI core de-initialization, so > + * after SCMI core removal. > * @ops: Pointer to the transport specific ops structure > * @max_rx_timeout_ms: Timeout for communication with SoC (in Milliseconds) > * @max_msg: Maximum number of messages that can be pending > @@ -328,6 +334,8 @@ struct scmi_device *scmi_child_dev_find(struct device *parent, > * @max_msg_size: Maximum size of data per message that can be handled. > */ > struct scmi_desc { > + int (*init)(void); > + void (*exit)(void); Does it make sense to rename scmi_desc as scmi_transport or scmi_transport_desc ? I reason I ask is plain init/exit here doesn't make sense. You can change it to transport_init/exit if we don't want to rename the structure. > const struct scmi_transport_ops *ops; I assume we don't want init/exit inside ops as it is shared with protocols ? Looks good other than the above comment. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel