From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC80C4338F for ; Wed, 28 Jul 2021 17:28:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E12461039 for ; Wed, 28 Jul 2021 17:28:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E12461039 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Js7sGn0IHFTx8jybLk/XwRlW3zEHBPU3wWew5jbdt00=; b=pgV34kwOv9uQZq OvIaXI3EJuVqz2xxvijGYDOBPLnpAAwld7b1U7za4hEst7ji9Lmh6B5++cC5jRn6kscL8Owo9O/IP Rb78QncqEMZ1kox8mf0/JTKdDqcymRv2FY0xQa+76SrvED8DU/ovvlFb6DR3aSwaOsx5OGmI0OTaB PGDw+n6klffTTecxM7pwu8XZl+g6l7D+M27YP3F7Zl5y162Sy0GA8qIA760G79hLR+iJziuKy/TQg J+0Bt+uSQKGdO1Qoj9ZDlnibLyLBsuesoS+umSIW9+4CeLCLqU/ke6sCUr8+ypsR9jJlySsCkSj1d kpYa9alGxeVMxp38BiZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8nJl-001okQ-F3; Wed, 28 Jul 2021 17:26:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8nJg-001oi0-Fg for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 17:26:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26C8F6D; Wed, 28 Jul 2021 10:25:56 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DFF63F66F; Wed, 28 Jul 2021 10:25:53 -0700 (PDT) Date: Wed, 28 Jul 2021 18:25:46 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 08/17] firmware: arm_scmi: Add priv parameter to scmi_rx_callback Message-ID: <20210728172546.GL6592@e120937-lin> References: <20210712141833.6628-1-cristian.marussi@arm.com> <20210712141833.6628-9-cristian.marussi@arm.com> <20210728142625.zbx7zbeffwsksjl5@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728142625.zbx7zbeffwsksjl5@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_102600_671405_5B249FDE X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 03:26:25PM +0100, Sudeep Holla wrote: > On Mon, Jul 12, 2021 at 03:18:24PM +0100, Cristian Marussi wrote: > > Add a new opaque void *priv parameter to scmi_rx_callback which can be > > optionally provided by the transport layer when invoking scmi_rx_callback > > and that will be passed back to the transport layer in xfer->priv. > > > > This can be used by transports that needs to keep track of their specific > > data structures together with the valid xfers. > > Hi, > > This change looks simple but doesn't make sense on its own. I assume you don't > want to add all these in the patch making use of priv which makes sense. Not > sure if the next patch uses it, but I prefer to keep them as close as possible > if it is not too much of a hassle. > Right, yes I'll move it close to 17/17 which is the actual user of this at the end. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel