From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F77C4338F for ; Sat, 31 Jul 2021 06:52:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90AF660F12 for ; Sat, 31 Jul 2021 06:52:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90AF660F12 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ux9+UPyNsT3BP4d+licqhx26UQMpGNbCTNimaCBsjYU=; b=uPVmfTC61SV/gI mwT/dn+wbvBloUEQ0+AeD2XC6TXj6QwI4QS1zeqGJh06vLxg/3+E0E85WpCxi1zCe93f2+DF/89HE +NCgcXucCH5j2FvZu6xnkD+Lv44jhUm9H+k36TB5QPZFRU0dHgWPZlbTVMV5M1FGQRFC4vcVjZd0U vjgonOYLujp0LrO6a6Kg8iJ1J5pBMSNDCEILoECjQFIKBGdWwG253CXsjHwTAw+jSqMt/it7AcEwf 7UZxR9F79CEwPbkrHWSUlgQBV/XkvdLLR1DkqRQIBYnArjqBTRJ4GnJGnnzetv3FQziuv31lLJ7eQ 7SNtFnJ2ixBW9hdxtEIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9ipI-00B5WG-29; Sat, 31 Jul 2021 06:50:28 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9ipD-00B5Vr-VQ for linux-arm-kernel@lists.infradead.org; Sat, 31 Jul 2021 06:50:25 +0000 Received: by mail-pj1-x1036.google.com with SMTP id o44-20020a17090a0a2fb0290176ca3e5a2fso17567098pjo.1 for ; Fri, 30 Jul 2021 23:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Scp0XsH/8g/xK4xKxJDwfK0sTyUpWpPn5qW5XBp4RlQ=; b=t5KuRMuqXwprgBmPyYSxKUd9krVCGGA1/xFNfgaXMbWzxfPTXEG3OEi+Pa0OSrxk51 HD841NZ6TGnggbZXbFfK5Y96Vg6U+w2CtczwKpMsaRA83Qylg6Vmi98cFMDopiEq9Qjv HMnOZNaLE4Oe6e2uXI+ElUBf9dSqD55l6oE470aYX0v0oyAxBcp/Q/Ty/sCsy6RQnekk 6HWpWqrmzvVtxiG4c5ckM0DvM06cAd6/R6JXBGbSrwnp3MVCosssqU/vcmJc/ltpCh9K tcQK8ZganY6dzHe0CwjEduNH4rxJLjM9STZUSvURpuIDdqz62OobXT3en/qIocQjLoUN vFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Scp0XsH/8g/xK4xKxJDwfK0sTyUpWpPn5qW5XBp4RlQ=; b=hoAAiBJ+vAY1ng88LBwun1S8kkj8pwfrBKDapHJ0e0zvjXEz1N6ja3eJ8yb9RXmkQn h2VaxW57sEdtGxzymKStYS5EC95dwEKYyeTqtztiCf583YwXkW7vtt94K1i1Zetwqzl2 jynFpfB7ns6LAERDJjLSOxY7CDiTtIpSk+Zf+e4h2/A7G0aIS1d6t9kr/llKfbNUirVu 2pNv8sok6UDHQXF/XyaoLJI740YpCDTVgDdP9iHdVKG+520AWEhO5kwE+m9UKGpvGkfD QX6sMnK63Ko4Tcyhg4vZ+uKTtX4MCgJ6EVByf+eMr1Ni/lXwPp+HmUHoeinvOPljnS24 tztQ== X-Gm-Message-State: AOAM531s0E2jEH/ds+0gPTOj0Hbk/eBNsavVarVUSRVVIz6QfY8yTzay RKF4xfPRmgu0y7FJFYjykVPMyg== X-Google-Smtp-Source: ABdhPJyPuhbQY1xaqyLCuAYgPVh0gLGVPKGQCpoB6z7QVm3rnjclpY3xMn1x90IcjsEf9JHsoC15nQ== X-Received: by 2002:a17:902:76cb:b029:12b:2fb8:7c35 with SMTP id j11-20020a17090276cbb029012b2fb87c35mr5751825plt.16.1627714223124; Fri, 30 Jul 2021 23:50:23 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([204.124.181.43]) by smtp.gmail.com with ESMTPSA id g3sm4423116pfi.197.2021.07.30.23.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 23:50:22 -0700 (PDT) Date: Sat, 31 Jul 2021 14:50:12 +0800 From: Leo Yan To: James Clark Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 4/6] perf cs-etm: Update OpenCSD decoder for ETE Message-ID: <20210731065012.GD7437@leoy-ThinkPad-X240s> References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-5-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210721090706.21523-5-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_235024_062415_7E2261E7 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 21, 2021 at 10:07:03AM +0100, James Clark wrote: > OpenCSD v1.1.1 has a bug fix for the installation of the ETE decoder > headers. This also means that including headers separately for each > decoder is unnecessary so remove these. > > Signed-off-by: James Clark IIUC, only the later patches in this patch set are dependent on OpenCSD v1.1.1. After I checked OpenCSD latest header, this change LGTM: Reviewed-by: Leo Yan > --- > tools/build/feature/test-libopencsd.c | 4 ++-- > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 2 -- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/build/feature/test-libopencsd.c b/tools/build/feature/test-libopencsd.c > index 52c790b0317b..eb6303ff446e 100644 > --- a/tools/build/feature/test-libopencsd.c > +++ b/tools/build/feature/test-libopencsd.c > @@ -4,9 +4,9 @@ > /* > * Check OpenCSD library version is sufficient to provide required features > */ > -#define OCSD_MIN_VER ((1 << 16) | (0 << 8) | (0)) > +#define OCSD_MIN_VER ((1 << 16) | (1 << 8) | (1)) > #if !defined(OCSD_VER_NUM) || (OCSD_VER_NUM < OCSD_MIN_VER) > -#error "OpenCSD >= 1.0.0 is required" > +#error "OpenCSD >= 1.1.1 is required" > #endif > > int main(void) > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 5972a8afcc6b..60147c908425 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -13,8 +13,6 @@ > #include > #include > #include > -#include > -#include > > #include "cs-etm.h" > #include "cs-etm-decoder.h" > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel