From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98F7C4338F for ; Mon, 2 Aug 2021 15:19:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6A8E60FF2 for ; Mon, 2 Aug 2021 15:19:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6A8E60FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jT4whAQGSXt8ypId0xbB5qfzf4aV8JTtAEC4P15Ls9s=; b=KPq5qT6qF2amIv MxjIim7jw1tejyfbEMF1KP4Ibjje+ysXN6Q4U0WOfRPev2Z7uPfQ5Lacj3HR3ygG+hchpA7peu/YF GPihknUM0Ct3UFdR4+MJPdM0fzFE3rHibHJPMWjpyvls2iFdyQFw/n+vK7uiMAInE0p0z9+jOnZY3 oCXxnLiTxqPUvIAO8+VL3GHy9GhDnIYH6KMQjkmmin0utmF3gUafc03RxGzftpcfB9EubpiAIqoMC Y4eSK+yW7kg/qJMv6uX93N5fCdUmS9r4XnBMn2F5YEMZugESJZ4JDD83jpeq0tIJn8vN7iGYvhmkd 8cPV21PGVAE972p9eJeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZgx-00Gtgc-R6; Mon, 02 Aug 2021 15:17:24 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZgt-00Gtel-El for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 15:17:20 +0000 Received: by mail-pj1-x1032.google.com with SMTP id dw2-20020a17090b0942b0290177cb475142so6315855pjb.2 for ; Mon, 02 Aug 2021 08:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xb8HOmuPTAxJ7T5xR6e4z7KGNGhgi+GnOoQmDeQ4d8E=; b=na3fYEqx7lUMrXT+mnoG9cExJCmY7bgYn1X9PTL4Z+t+jgYKxyFGxtez2PzJryo/Ju /d7t/KfU4tJUV0+GAyyMOtV+eLLzIbd4QQD47k//k614s6b1Kt3EYhNBACa7DtCwBCgi JNZzflIJlWqU/QxMO6p3psckER771ekSUWgal7glI5podLFNQCWt851uwpcsVgpQLQkn n6BhgaNPGOnPMj++ntzDueAEYl2ATgLFQr5leH1Y1GLcaHEwgg8QQXMIO6pK4KU7KwJx MBJThA7+/ff7ugTwiLkwfIm3xDRUU8HnkJJkl1Bxwjq81pvKLniFNAA+X1DdpVWegRYS WfIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xb8HOmuPTAxJ7T5xR6e4z7KGNGhgi+GnOoQmDeQ4d8E=; b=FGsFwIN9GopQ2ObB8sgfTnUXa9rwSKJSKhnrw2ucYIxBEnbPGhJ/HE8w6h/xCZQkfy G+la/emVypHt7ReBPc/HzN4+XIjsbcpyDY4iSSiflKgK1QH/NuicpfRCAULs1JGebyvi +VMwr7PN599Zvwz5Hy5tVCmlTJ1c5FqfAGy7EmOJ0ApLKVVuDkPVkhl3insGjgqtZNsN NJM7da8RQkM9lQSe2x52rHbC+MhlUUPPbyJNFyx+O0XLbIXExyq39eevE+o7kR8k0hNF PqmRY+CZ6voPYR/SolE3+b389ijnuEZ3okbKvLm8ZGC391wG8t1/v8Wq0Bx+4bEtHozk c5Zw== X-Gm-Message-State: AOAM5331IOPuuN8fFm40D7n9oPSw0I11/y2gpr2wC8GFfv96kZNhfJ6M SSD8JH3wVj0wlXyG0Q+2h87KdA== X-Google-Smtp-Source: ABdhPJw+6FnSBQB8oQaVjz+nnBTezKYAPlod64rZDb5S+XFBEYmGXWsaE98+V1M2xlQL5POiXS+9aw== X-Received: by 2002:a17:90a:fd10:: with SMTP id cv16mr1865144pjb.134.1627917438233; Mon, 02 Aug 2021 08:17:18 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id j19sm12306155pfr.82.2021.08.02.08.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 08:17:17 -0700 (PDT) Date: Mon, 2 Aug 2021 23:17:10 +0800 From: Leo Yan To: James Clark Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 5/6] perf cs-etm: Improve Coresight zero timestamp warning Message-ID: <20210802151710.GB148327@leoy-ThinkPad-X240s> References: <20210729155805.2830-1-james.clark@arm.com> <20210729155805.2830-6-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729155805.2830-6-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_081719_557186_3A9925DB X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 29, 2021 at 04:58:04PM +0100, James Clark wrote: > Only show the warning if the user hasn't already set timeless mode and > improve the text because there was ambiguity around the meaning of '...' > > Change the warning to a UI warning instead of printing straight to > stderr because this corrupts the UI when perf report TUI is used. The UI > warning function also handles printing to stderr when in perf script > mode. > > Suggested-by: Leo Yan > Signed-off-by: James Clark Reviewed-by: Leo Yan > --- > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 3e1a05bc82cc..5084bd2ca6eb 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -324,8 +324,11 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq, > * underflow. > */ > packet_queue->cs_timestamp = 0; > - WARN_ONCE(true, "Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > - ". Decoding may be improved with --itrace=Z...\n", indx); > + if (!cs_etm__etmq_is_timeless(etmq)) > + pr_warning_once("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > + ". Decoding may be improved by prepending 'Z' to your current --itrace arguments.\n", > + indx); > + > } else if (packet_queue->instr_count > elem->timestamp) { > /* > * Sanity check that the elem->timestamp - packet_queue->instr_count would not > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel