From: Vladimir Oltean <olteanv@gmail.com>
To: DENG Qingfang <dqfext@gmail.com>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Eric Woudstra" <ericwouds@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Ilya Lipnitskiy" <ilya.lipnitskiy@gmail.com>
Subject: Re: [PATCH net-next 3/4] net: dsa: mt7530: set STP state on filter ID 1
Date: Tue, 3 Aug 2021 17:43:45 +0300 [thread overview]
Message-ID: <20210803144345.jmucndmrflnqlfo3@skbuf> (raw)
In-Reply-To: <20210803124022.2912298-4-dqfext@gmail.com>
On Tue, Aug 03, 2021 at 08:40:21PM +0800, DENG Qingfang wrote:
> As filter ID 1 is the only one used for bridges, set STP state on it.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> RFC -> v1: only set FID 1's state
>
> drivers/net/dsa/mt7530.c | 3 ++-
> drivers/net/dsa/mt7530.h | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 12f449a54833..8d84d7ddad38 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -1147,7 +1147,8 @@ mt7530_stp_state_set(struct dsa_switch *ds, int port, u8 state)
> break;
> }
>
> - mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK, stp_state);
> + mt7530_rmw(priv, MT7530_SSP_P(port), FID1_PST_MASK,
> + FID1_PST(stp_state));
> }
>
> static int
> diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h
> index a308886fdebc..53b7bb1f5368 100644
> --- a/drivers/net/dsa/mt7530.h
> +++ b/drivers/net/dsa/mt7530.h
> @@ -181,8 +181,8 @@ enum mt7530_vlan_egress_attr {
>
> /* Register for port STP state control */
> #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100))
> -#define FID_PST(x) ((x) & 0x3)
> -#define FID_PST_MASK FID_PST(0x3)
> +#define FID1_PST(x) (((x) & 0x3) << 2)
> +#define FID1_PST_MASK FID1_PST(0x3)
Not a reason to resend, but I still would have expected a macro:
#define FID_PST(fid, state) ((state) & 0x3) << ((fid) * 2)
#define FID_PST_MASK(fid) FID_PST(fid, 0x3)
#define FID_STANDALONE 0
#define FID_BRIDGED 1
and called with:
mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK(FID_BRIDGED),
FID_PST(FID_BRIDGED, stp_state));
>
> enum mt7530_stp_state {
> MT7530_STP_DISABLED = 0,
> --
> 2.25.1
>
Anyhow.
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-03 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:40 [PATCH net-next 0/4] mt7530 software fallback bridging fix DENG Qingfang
2021-08-03 12:40 ` [PATCH net-next 1/4] net: dsa: mt7530: enable assisted learning on CPU port DENG Qingfang
2021-08-03 12:40 ` [PATCH net-next 2/4] net: dsa: mt7530: use independent VLAN learning on VLAN-unaware bridges DENG Qingfang
2021-08-03 12:40 ` [PATCH net-next 3/4] net: dsa: mt7530: set STP state on filter ID 1 DENG Qingfang
2021-08-03 14:43 ` Vladimir Oltean [this message]
2021-08-03 12:40 ` [PATCH net-next 4/4] net: dsa: mt7530: always install FDB entries with IVL and FID 1 DENG Qingfang
2021-08-03 14:45 ` Vladimir Oltean
2021-08-03 15:29 ` DENG Qingfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803144345.jmucndmrflnqlfo3@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=ericwouds@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=ilya.lipnitskiy@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).