From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FA3C4338F for ; Wed, 4 Aug 2021 04:04:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C29E60ED6 for ; Wed, 4 Aug 2021 04:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C29E60ED6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eLHkZlR8rBPEQ86ES0mC86JPlZDaof/8J+Hd3lZQW3Y=; b=g41/Dzdqxfqsx/ SE+N1j3kaIz8aCd+6/G82qlftKj6rou9EQ+MQQIqQsMuA9Xva3caE0rnXTwMqtL6+4UqoAFcuneYf SIHxrpnnOWIfU0Hm32Yo+g+uys4bJzDVOv+9J5HL05LEUYGlNUQSY8Yso0MJh8DojnvG3AgTLLRPV 3UJhZNPomF4qXmUCecM32TthKTKFJTI390k2kxbX4KmtcjczQAa5niY9B2bNkAUOCMBBVBy2hixpc h5a2LFBYXGD4XI4xP1/eMesKhYqdjc7rtVx+y7I4Yk5uaI5+GNew4jzhKcdR23Gd6X+giYpgVb77W gVGTBefdUS7ATaTAAQ9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mB879-004iui-Bo; Wed, 04 Aug 2021 04:02:43 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mB876-004iuO-5M for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 04:02:41 +0000 Received: by mail-pj1-x102c.google.com with SMTP id o44-20020a17090a0a2fb0290176ca3e5a2fso1785648pjo.1 for ; Tue, 03 Aug 2021 21:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZB8hSYRKOrLl+E7loPd/8HK8c+ZXrxlOogYwUY2eSfs=; b=xuIYEBsn2ryqdGX+FkuwetInmokALqieaEGMa8kT90J0hA64MKJqN0LJ878I/0lb0v tkhcV8blLh+C1rmWsmvy+Aux/jdhiT9Z2rmcDr7uPC1+pfCN/TZGCpfWTV0diARD4xwW UItWZf4bsjcUCjL2MGH5HHjx8MZY17xbW0F97PHlpCMA5NvJM5uemsbs9K81DN50Eu5A XzbRGMyFC8HsaYITWy9qRAGTQ3aa158OQn+jl4R4IlsMlUWJ2m4LjsxYsCN0UCHOnM2/ 4aCgBGoeHSX9jDDlyxsLDysGL9MslKaWc4w2pOpAODcJrvOQigULv7OqP4th2UBSFISU hbfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZB8hSYRKOrLl+E7loPd/8HK8c+ZXrxlOogYwUY2eSfs=; b=uCqNBd3qp9KejcDJeF+jTstFYHUCmhG+Wdzdom1U0VykbLMPzuTlb8OYe5g8ngD8tZ ta8m/vjoMD9aWehbp1wObcXAQxtOeWdrdGe2ahHa6GZ0+R9KSybit78qXu6CrGvC27l2 hM8CgPLhxmbw/2yaXQEoOFeY8m4HkZPse5TLRPlV0fWYA+kuWiALjM67fYjI+ZfaKNBk U9WB1IH4snyMWniKx+NtT82/kxf+3tRoTwMa3jWhZrl1UalKdra0JA/8JhcfEEXSPyuZ upqF58JuceRhcAxNzyiA62Fvxm7O80QZ0OcpxGudwW2KXi9YJff0yuc1lhKQjqovg0Hm YH8A== X-Gm-Message-State: AOAM5333UCMw4cwwU+m13OIF7NIK6LjmSVUYjTmGfUXHlNCADVOphav2 7XEcO8OLIEgyBsUXO1TpLDF2MySRcipVEw== X-Google-Smtp-Source: ABdhPJy3dsyNIt/AZvz2RkHKRr3vR7DVqumnZSQuCTMohgzQ/9WXO5p0bWhT04eDCNmAyiuOnAi//g== X-Received: by 2002:a17:902:ce8f:b029:12c:c4e7:682d with SMTP id f15-20020a170902ce8fb029012cc4e7682dmr7288244plg.58.1628049759151; Tue, 03 Aug 2021 21:02:39 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id g20sm723281pfv.88.2021.08.03.21.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 21:02:38 -0700 (PDT) Date: Wed, 4 Aug 2021 09:32:37 +0530 From: Viresh Kumar To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com, rjw@rjwysocki.net, nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed Message-ID: <20210804040237.ssrba26jpe572mjf@vireshk-i7> References: <20210803090744.12143-1-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210803090744.12143-1-lukasz.luba@arm.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_210240_270094_E96C9159 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03-08-21, 10:07, Lukasz Luba wrote: > Stop the initialization when cpumask allocation failed and return an > error. > > Fixes: 80a064dbd556 ("scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM") > Signed-off-by: Lukasz Luba > --- > changes: > v2: > - removed dev_warn() since it's not needed in this case > - adjusted the patch description > > drivers/cpufreq/scmi-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index ec9a87ca2dbb..75f818d04b48 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > } > > if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL)) > - ret = -ENOMEM; > + return -ENOMEM; > > /* Obtain CPUs that share SCMI performance controls */ > ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus); Applied. Thanks. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel