From: Sascha Hauer <s.hauer@pengutronix.de>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel@pengutronix.de, "Andy Yan" <andy.yan@rock-chips.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support
Date: Wed, 6 Apr 2022 16:58:47 +0200 [thread overview]
Message-ID: <20220406145847.GX4012@pengutronix.de> (raw)
In-Reply-To: <BA4C591F-D115-43D2-BF59-A75B29889E50@gmail.com>
On Wed, Apr 06, 2022 at 11:47:22AM +0200, Piotr Oniszczuk wrote:
>
>
> > Wiadomość napisana przez Piotr Oniszczuk <piotr.oniszczuk@gmail.com> w dniu 01.04.2022, o godz. 15:05:
> >
> >
> >
> >> Wiadomość napisana przez Sascha Hauer <s.hauer@pengutronix.de> w dniu 01.04.2022, o godz. 14:52:
> >>
> >> Based on the discussion with Andy please try the following patch, it
> >> should fix your green screen issue. Note that with this patch the
> >> CRTC and plane ids will change, so the modetest commands need to be
> >> adjusted accordingly.
> >>
> >> Sascha
> >>
> >> -------------------------8<---------------------------
> >>
> >> --
> >> From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001
> >> From: Sascha Hauer <s.hauer@pengutronix.de>
> >> Date: Fri, 1 Apr 2022 14:48:49 +0200
> >> Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver
> >>
> >> ---
> >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++
> >> 1 file changed, 14 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> >> index 7dba7b9b63dc6..1421bf2f133f1 100644
> >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> >> @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2)
> >> }
> >> }
> >>
> >> + if (vop2->data->soc_id == 3566) {
> >> + /*
> >> + * On RK3566 these windows don't have an independent
> >> + * framebuffer. They share the framebuffer with smart0,
> >> + * esmart0 and cluster0 respectively.
> >> + */
> >> + switch (win->data->phys_id) {
> >> + case ROCKCHIP_VOP2_SMART1:
> >> + case ROCKCHIP_VOP2_ESMART1:
> >> + case ROCKCHIP_VOP2_CLUSTER1:
> >> + continue;
> >> + }
> >> + }
> >> +
> >> if (win->type == DRM_PLANE_TYPE_OVERLAY)
> >> possible_crtcs = (1 << nvps) - 1;
> >>
> >> --
> >> 2.30.2
> >>
> >> Pengutronix e.K. | |
> >> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> >
> > Sascha
> >
> > Now works perfectly!
> > (hd playback with 3.5...5.5% cpu while rendering to drm plane)
> >
> > Fantastic work of You!
>
> Sascha,
>
> Having vop2 finally working with drm planes rendering i discovered another issue: overlay osd is invisible at playback.
>
> context: player draws video on plane #X and osd on overlay plane #Y
> When user do i.e. seek at playback - app uses overlay OSD plane to display OSD to user. This approach is used by majority of players (KODI, etc.)
>
> This works well on all platforms i have - except rk3566
>
> For me it looks like z-order vop2 issue or alpha blending issue.
> As this is only on rk3566 and only on drm-planes mode - issue is vop2 related imho.
During my testing I haven't seen any z-order issues, but that doesn't
mean much. With Weston I can currently only use the AFBC enabled cluster
windows and with modetest I can only use the non-cluster windows. Are
you able to find out which window is used for the OSD?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-06 15:00 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 15:10 [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-03-28 15:10 ` [PATCH v9 01/23] clk: rk3568: Mark hclk_vo as critical Sascha Hauer
2022-03-29 13:22 ` Dmitry Osipenko
2022-04-06 11:15 ` Robin Murphy
2022-03-28 15:10 ` [PATCH v9 02/23] drm/rockchip: Embed drm_encoder into rockchip_decoder Sascha Hauer
2022-03-28 15:10 ` [PATCH v9 03/23] drm/rockchip: Add crtc_endpoint_id to rockchip_encoder Sascha Hauer
2022-03-28 15:10 ` [PATCH v9 04/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-03-28 15:10 ` [PATCH v9 05/23] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-03-28 15:10 ` [PATCH v9 06/23] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 07/23] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 08/23] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 09/23] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 10/23] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 11/23] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 12/23] drm/rockchip: dw_hdmi: drop mode_valid hook Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 13/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 14/23] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 15/23] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 16/23] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 17/23] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 18/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 19/23] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-03-29 11:56 ` Andy Yan
2022-03-30 6:39 ` Sascha Hauer
2022-03-30 12:50 ` Andy Yan
2022-03-31 7:06 ` Sascha Hauer
2022-03-31 7:20 ` Andy Yan
2022-03-31 8:18 ` Sascha Hauer
2022-03-31 11:00 ` Andy Yan
2022-04-01 12:55 ` Sascha Hauer
2022-04-02 1:25 ` Andy Yan
2022-04-05 9:05 ` Sascha Hauer
2022-04-06 1:43 ` Andy Yan
2022-04-06 7:04 ` Sascha Hauer
2022-04-06 7:47 ` Andy Yan
2022-04-06 8:00 ` Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 22/23] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-03-28 15:11 ` [PATCH v9 23/23] dt-bindings: display: rockchip: dw-hdmi: fix ports description Sascha Hauer
2022-03-29 7:31 ` [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Piotr Oniszczuk
2022-03-30 7:28 ` Sascha Hauer
2022-03-30 8:41 ` piotro.oniszczuk@google.com
2022-03-30 9:45 ` Sascha Hauer
2022-03-30 10:01 ` piotro.oniszczuk@google.com
2022-03-30 10:20 ` Sascha Hauer
2022-03-30 14:52 ` Piotr Oniszczuk
2022-03-30 19:20 ` Sascha Hauer
2022-03-30 19:35 ` Piotr Oniszczuk
2022-03-30 19:59 ` Sascha Hauer
2022-03-31 12:13 ` Andy Yan
2022-03-31 12:19 ` Sascha Hauer
2022-03-31 14:53 ` Piotr Oniszczuk
2022-03-31 15:00 ` Sascha Hauer
2022-03-31 15:06 ` Piotr Oniszczuk
2022-03-31 15:19 ` Piotr Oniszczuk
[not found] ` <622c8786-2c3f-13ff-66b7-ad9c8cb9425e@rock-chips.com>
2022-04-01 7:06 ` Sascha Hauer
[not found] ` <041d7795-fdec-8e7d-a9ee-aa79c0faa6f3@rock-chips.com>
2022-04-01 12:53 ` Piotr Oniszczuk
2022-04-01 12:52 ` Sascha Hauer
2022-04-01 13:05 ` Piotr Oniszczuk
2022-04-06 9:47 ` Piotr Oniszczuk
2022-04-06 14:58 ` Sascha Hauer [this message]
2022-04-06 16:00 ` Piotr Oniszczuk
2022-04-07 10:16 ` Sascha Hauer
2022-04-07 15:02 ` Piotr Oniszczuk
2022-04-08 8:07 ` Sascha Hauer
2022-04-08 12:00 ` Sascha Hauer
2022-04-08 15:54 ` Piotr Oniszczuk
2022-04-11 9:08 ` Sascha Hauer
2022-04-11 11:07 ` Piotr Oniszczuk
2022-04-12 7:50 ` Sascha Hauer
2022-04-12 8:10 ` Lucas Stach
2022-04-12 10:14 ` Piotr Oniszczuk
2022-04-12 11:30 ` Daniel Stone
2022-04-15 11:11 ` Piotr Oniszczuk
2022-04-25 14:54 ` Daniel Stone
2022-04-12 9:28 ` Piotr Oniszczuk
2022-04-02 1:37 ` Andy Yan
2022-04-05 9:37 ` Sascha Hauer
2022-04-06 2:02 ` Andy Yan
2022-04-06 8:13 ` Sascha Hauer
2022-04-06 8:36 ` Andy Yan
2022-04-06 14:54 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406145847.GX4012@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=piotr.oniszczuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).