From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15729C4338F for ; Fri, 30 Jul 2021 06:12:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF82C61008 for ; Fri, 30 Jul 2021 06:12:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF82C61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Cc:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+TXji9yr3Hrb1alg8gWENhrAqgdj9QjEh4SIOgj5Bug=; b=xVuNw8k9lymEMESO/GECnkz1bb hEJ0ZOt1HjkJKpdaJk19/0AHX7brRElQECc2PtEQESYv4T/1IwmAgRgS7eEJS/4yr1J3r3b3Jp+zF HfxcpH6EfN2Tu9ao0b7pmzliQXZGbUn7YlF0+obfANBJ39D0I4tYKG73+54iQsrl0Umie4d/WHV68 aXO5bRk+sJMw8UAyD40sEkCCMUHknXZ6W2AK1zkHqHh4J9EH8Rdq7bFjQZ8AB6yQRrARJQHz8M1In 1TbVWKmBbS3rsXmtOTbQnF/f3adLkRejPO70lPyw4u9HJipRudxuZ2oNDbtkgsGL2j6tvMfrqFGOu /iFNwPrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Lj7-007O5R-Ah; Fri, 30 Jul 2021 06:10:33 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Lj2-007O3N-7E for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 06:10:29 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="298623298" X-IronPort-AV: E=Sophos;i="5.84,281,1620716400"; d="scan'208";a="298623298" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 23:10:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,281,1620716400"; d="scan'208";a="465344879" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga008.jf.intel.com with ESMTP; 29 Jul 2021 23:10:19 -0700 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH v2 13/24] iommu/dma: Remove redundant "!dev" checks To: Robin Murphy , joro@8bytes.org, will@kernel.org References: <200af1d10b493a90aada6466b1f1938e1b16731f.1627468309.git.robin.murphy@arm.com> From: Lu Baolu Message-ID: <32647590-5957-5a54-71ed-fa6e6f2b1a5b@linux.intel.com> Date: Fri, 30 Jul 2021 14:08:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <200af1d10b493a90aada6466b1f1938e1b16731f.1627468309.git.robin.murphy@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_231028_331446_0A5A19FE X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/28/21 11:58 PM, Robin Murphy wrote: > iommu_dma_init_domain() is now only called from iommu_setup_dma_ops(), > which has already assumed dev to be non-NULL. > > Reviewed-by: John Garry > Signed-off-by: Robin Murphy > --- > drivers/iommu/dma-iommu.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c > index 10067fbc4309..e28396cea6eb 100644 > --- a/drivers/iommu/dma-iommu.c > +++ b/drivers/iommu/dma-iommu.c > @@ -363,7 +363,7 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base, > > init_iova_domain(iovad, 1UL << order, base_pfn); > > - if (!cookie->fq_domain && (!dev || !dev_is_untrusted(dev)) && > + if (!cookie->fq_domain && !dev_is_untrusted(dev) && > domain->ops->flush_iotlb_all && !iommu_get_dma_strict(domain)) { > if (init_iova_flush_queue(iovad, iommu_dma_flush_iotlb_all, > iommu_dma_entry_dtor)) > @@ -372,9 +372,6 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base, > cookie->fq_domain = domain; > } > > - if (!dev) > - return 0; > - > return iova_reserve_iommu_regions(dev, domain); > } > > Reviewed-by: Lu Baolu Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel