From: John Garry <john.garry@huawei.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] drivers/perf: hisi: Simplify hisi_read_sccl_and_ccl_id and its comment
Date: Mon, 11 Nov 2019 13:49:20 +0000 [thread overview]
Message-ID: <365e965d-b24b-1316-e818-a3d6ad7caf6e@huawei.com> (raw)
In-Reply-To: <1573267867-21991-1-git-send-email-zhangshaokun@hisilicon.com>
On 09/11/2019 02:51, Shaokun Zhang wrote:
> hisi_read_sccl_and_ccl_id is not readable
That's a little strong :)
and its comment is a little
> confused, so simplify the function and its comment as Mark's suggestion.
>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/perf/hisilicon/hisi_uncore_pmu.c | 58 ++++++++++++++++++--------------
> 1 file changed, 32 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> index 96183e31b96a..9e9625a1f388 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c
> @@ -337,38 +337,44 @@ void hisi_uncore_pmu_disable(struct pmu *pmu)
> hisi_pmu->ops->stop_counters(hisi_pmu);
> }
>
> +
> /*
> - * Read Super CPU cluster and CPU cluster ID from MPIDR_EL1.
> - * If multi-threading is supported, On Huawei Kunpeng 920 SoC whose cpu
> - * core is tsv110, CCL_ID is the low 3-bits in MPIDR[Aff2] and SCCL_ID
> - * is the upper 5-bits of Aff2 field; while for other cpu types, SCCL_ID
> - * is in MPIDR[Aff3] and CCL_ID is in MPIDR[Aff2], if not, SCCL_ID
> - * is in MPIDR[Aff2] and CCL_ID is in MPIDR[Aff1].
> + * The Super CPU Cluster (SCCL) and CPU Cluster (CCL) IDs can be
> + * determined from the MPIDR_EL1, but the encoding varies by CPU:
> + *
> + * - For MT variants of TSV110 (e.g. found in Kunpeng 920):
I wish that you would drop the "found in Kunpeng 920", as I find it
confusing/misleading.
Thanks,
John
> + * SCCL is Aff2[7:3], CCL is Aff2[2:0]
> + *
> + * - For other MT parts:
> + * SCCL is Aff3[7:0], CCL is Aff2[7:0]
> + *
> + * - For non-MT parts:
> + * SCCL is Aff2[7:0], CCL is Aff1[7:0]
> */
> -static void hisi_read_sccl_and_ccl_id(int *sccl_id, int *ccl_id)
> +static void hisi_read_sccl_and_ccl_id(int *scclp, int *cclp)
> {
> u64 mpidr = read_cpuid_mpidr();
> -
> - if (mpidr & MPIDR_MT_BITMASK) {
> - if (read_cpuid_part_number() == HISI_CPU_PART_TSV110) {
> - int aff2 = MPIDR_AFFINITY_LEVEL(mpidr, 2);
> -
> - if (sccl_id)
> - *sccl_id = aff2 >> 3;
> - if (ccl_id)
> - *ccl_id = aff2 & 0x7;
> - } else {
> - if (sccl_id)
> - *sccl_id = MPIDR_AFFINITY_LEVEL(mpidr, 3);
> - if (ccl_id)
> - *ccl_id = MPIDR_AFFINITY_LEVEL(mpidr, 2);
> - }
> + int aff3 = MPIDR_AFFINITY_LEVEL(mpidr, 3);
> + int aff2 = MPIDR_AFFINITY_LEVEL(mpidr, 2);
> + int aff1 = MPIDR_AFFINITY_LEVEL(mpidr, 1);
> + bool mt = mpidr & MPIDR_MT_BITMASK;
> + int sccl, ccl;
> +
> + if (mt && read_cpuid_part_number() == HISI_CPU_PART_TSV110) {
> + sccl = aff2 >> 3;
> + ccl = aff2 & 0x7;
> + } else if (mt) {
> + sccl = aff3;
> + ccl = aff2;
> } else {
> - if (sccl_id)
> - *sccl_id = MPIDR_AFFINITY_LEVEL(mpidr, 2);
> - if (ccl_id)
> - *ccl_id = MPIDR_AFFINITY_LEVEL(mpidr, 1);
> + sccl = aff2;
> + ccl = aff1;
> }
> +
> + if (scclp)
> + *scclp = sccl;
> + if (cclp)
> + *cclp = ccl;
> }
>
> /*
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 7:56 [PATCH] drivers/perf: hisi: update the sccl_id/ccl_id for certain HiSilicon platform Shaokun Zhang
2019-11-07 11:31 ` Mark Rutland
2019-11-07 11:40 ` Will Deacon
2019-11-07 11:50 ` John Garry
2019-11-07 11:56 ` Mark Rutland
2019-11-07 12:06 ` John Garry
2019-11-07 12:11 ` Mark Rutland
2019-11-07 13:04 ` John Garry
2019-11-07 13:09 ` Will Deacon
2019-11-08 1:25 ` Shaokun Zhang
2019-11-08 9:49 ` Will Deacon
2019-11-09 2:51 ` [PATCH] drivers/perf: hisi: Simplify hisi_read_sccl_and_ccl_id and its comment Shaokun Zhang
2019-11-11 13:49 ` John Garry [this message]
2019-11-12 0:50 ` Shaokun Zhang
2019-11-08 1:18 ` [PATCH] drivers/perf: hisi: update the sccl_id/ccl_id for certain HiSilicon platform Shaokun Zhang
2019-11-08 1:15 ` Shaokun Zhang
2019-11-08 1:28 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365e965d-b24b-1316-e818-a3d6ad7caf6e@huawei.com \
--to=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).