From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88AFC433B4 for ; Thu, 20 May 2021 01:09:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5039F6112F for ; Thu, 20 May 2021 01:09:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5039F6112F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4F2KsLg/FXlt0JbGgOSWFFcb6tAGPFr+1zOzIAZ8fJY=; b=lFwl66bk9c++LWKypOoFJoS4l WasqHFJJgdIgnOzrlyOwvuLX9kcmOIsjQUvPUQaopOlWcIKtJgOV7bAkJ/i9jz69be9pqrxyXsPMY M/G8WlxGR4cTtIveblQgcXM8f/tRyAg0L5gHMGSc2NnV0R9nPQr/JvA6kKt2mKUQa03DNn/+lors5 kCTK/feVQNB3G/2PsbbC6M930Sem55WYB17c62PQHltY8hsht32XhRisSLgaxui8NPU8MwFrpa4IA lon0Hdy2Mde9hrNBU/d0Q9SDs1TpnGQv/wT9xVPM/VJgwrSb1sQKwFmQHNGdjvY0w0dMNOUREBFeW Wso/608fw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljX9O-005WOM-C6; Thu, 20 May 2021 01:06:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljX9L-005WNs-Jt for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 01:06:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-Description; bh=Qc568JM3g4uZLAgs8GF3WlhNaCtaZ/vqh+8wA2yu9h8=; b=rCYGsy7yWHNz0QXJUb7vyJYdkF YRapM1XE4LTsO3oj9yItynhCrNJ/UEz7FXg27ZgpnRuH7I5Ac7QuUzjCq5Cb6qwC2b0HML4R5jCsa /ZNsAbJq9v4/opnH8NSgMETbq9bd2xV4XBEO87DtxxRILgQVXn/pb9MxiI+me5aX1/tmFp2QmPU2q bymRdAwdCYWzcMkU846Txg8vy9wE7bPUSP2odz7kKP4FqqiBLZ8ajM9tD/eb62Ku8Pn+oTfNhiBsu ibm1CelPmYwKNiSQe8pmffcJ6KXA24VZlEsHCjbT5i4alWZPrVujFhIMldKxZYSqix5dlEq3ngkUP Wqg6UNqg==; Received: from mail-eopbgr1310111.outbound.protection.outlook.com ([40.107.131.111] helo=APC01-SG2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljX9I-00FsSn-KH for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 01:06:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BoBrvTyXNLV8hIKhf17llJ9htz8zc2LbY0D66um1SegaMN2kYMwjy1iISkHxylM1z5AgEjp+RSGIM9tTK14fFpUsliF9Gm6vtxgQzmxSpy9fqINQQ21btMnKQUzQMd+xtkjc2n3Mpd0MNAntf6c7yp6hwTpKvAAmgwNBCNv2XvH9Sof+b4WtZrKCowknGttvUlnao3jg7/dKmZiAKl48IHVoPvOe3lXPG+lyh0Hh0y6b57Jlun++As6YeS/M59uw6SqNy6wCngSGnSL06j9zCxukcJrSNFYgV0Gi3jCXYkvxr9IP4oSIv+NrQg9OO4Dep/6tTylJArKFfx0Wuqqj7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qc568JM3g4uZLAgs8GF3WlhNaCtaZ/vqh+8wA2yu9h8=; b=TnOS9k8NIeqHdVfBT4/7JrbqVjTklY1gTwfrfqRmXhv8UqYDtn5e6ke11LDGc7G37Qurtk5ooZrwcOhxdO2lUwGFaixJz2/4IZhfxX3Bm47o8w6LIvaJqsT9dv8GpOA7snS5nEnCMMHgstFY7l8/tfKVKDI0XHrvF7kSGbSnhPrFrtAywAS+sJ3A8C4sARB3/gqWENGfZU+43UFFjFp0z7iW+Hpube2o1UZ+CYJa8WHBhlDd2Kju02iJ/d1dydxujx7mkwNstKyTnI01lIXmiX1G7yTakhC4rpIagJCHxVYcnzRepof3Q/RmfuvgynjBkK4vpNKhTiypn9ZYRLjfog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qc568JM3g4uZLAgs8GF3WlhNaCtaZ/vqh+8wA2yu9h8=; b=ZszyyV5gaednbDGLoXJh+W8kRa3PaQw4mv0823BE3hkZAuZdRMBRe9bMsCnomt0A+B9t4hZ6e5F5a0MjxPLjM6cFEcsSXj9rjGMkXs2B3BpgA7SIfgji2khjr6LIMhZgeDOwCH6RDXiAw9cz6ZZCqoLm9aeeCwnntOhvst4pi5jWidQaafEqJERLhWyiqDRJC5rTd7LoFeuFylhHsV01ZWDcG8ye59ZYipZJWNY81MV+G98pCMtc+B3SUBcB8SnZTBkxHouGoaKVGXHWcbo5cX9LF7rA/kDSZ5rNs6Z8FOuP5XX6v0kEzRmCICtgMkMvrghXcFSDw9jC4kU9pY+l/Q== Received: from HK0PR06MB3362.apcprd06.prod.outlook.com (2603:1096:203:8b::10) by HK2PR0601MB1891.apcprd06.prod.outlook.com (2603:1096:202:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Thu, 20 May 2021 01:06:43 +0000 Received: from HK0PR06MB3362.apcprd06.prod.outlook.com ([fe80::58:9144:f232:6918]) by HK0PR06MB3362.apcprd06.prod.outlook.com ([fe80::58:9144:f232:6918%7]) with mapi id 15.20.4129.032; Thu, 20 May 2021 01:06:43 +0000 From: Billy Tsai To: Rob Herring CC: "lee.jones@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "p.zabel@pengutronix.de" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , BMC-SW Subject: Re: [v6 1/2] dt-bindings: Add bindings for aspeed pwm-tach. Thread-Topic: [v6 1/2] dt-bindings: Add bindings for aspeed pwm-tach. Thread-Index: AQHXS4BqdB0ayjhGFUqmRwq8BhHU4qrrQbMAgADWMgA= Date: Thu, 20 May 2021 01:06:43 +0000 Message-ID: <37458AA4-17E4-4329-88A1-C18C0AFC47D5@aspeedtech.com> References: <20210518005517.9036-1-billy_tsai@aspeedtech.com> <20210518005517.9036-2-billy_tsai@aspeedtech.com> <20210519202004.GA3566127@robh.at.kernel.org> In-Reply-To: <20210519202004.GA3566127@robh.at.kernel.org> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=aspeedtech.com; x-originating-ip: [211.20.114.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a334a8d5-e6b6-4035-2bc8-08d91b2b8859 x-ms-traffictypediagnostic: HK2PR0601MB1891: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k9xDELfey79+KXBNwJWb7ehV0ceCszok21m/gUtnYcOOsTT85oaoCbbd1pAiV71I9n7UNhY1xZEU8nRsC0E4CWtcUjlMNJy32dIwaWZcyUJB0sOLTLdEx74h5P8/RXN8JZpIrpOwCB8vrTUJpf9fziR+JAeJJYtom54tDyhVc8FSl0TYA4EzVi2N08nsJcyJPHQYNe9e1BCIPj7lSfwkacyubK5HZipZxGUu+7AlKNmL3kfqKWMRikVsKyavFwNIlwK9Dkwp6+rH3jhz4AZ9GwVYGCbxemc6mzFEB4rtxFbonsbwtMM9mMItmVJpfeRU640bkTYuzc95mO0yq3ZPMORab0W8Vo9Y7xrBxsqzwpTPwocVMCWh+MAELuxRnk+C91SPG5OnAhOQCJCEKW9ajs1H0DldDxzQK9IsznQwP7YC63BCVM0JC72qIZosKoaxNFF6wXCtCfmw+zkJNZtDih3SZ5Bv9J2tWWFrZKW3RiWMebDVfjxOmJpeP8ISqAR7fPmHRzVvljFGPwFEzx66wdrqnnkvDjXVr7fKxAl08c9zy61YkvYIMH8/Hhf0E5n1AUw5Z1JU16zzDzlpuXkphcmBE8H+yIuqXSQ6iBRiHCJ8hX77/UGDiHOvUdo5UHtiXjdjb4T0ZkPHIR7uF1H7kdtzGiDiRTrfIj+1V3zk51Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(136003)(366004)(39830400003)(376002)(6486002)(33656002)(86362001)(76116006)(38100700002)(83380400001)(122000001)(7416002)(66946007)(478600001)(316002)(8936002)(6916009)(6506007)(4744005)(5660300002)(6512007)(55236004)(2616005)(107886003)(71200400001)(54906003)(4326008)(66476007)(186003)(64756008)(8676002)(66446008)(26005)(66556008)(2906002)(36756003)(45980500001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?utf-8?B?dUpUUEJIMVoyYTNXVnlzbTFhK2l1UXdaazBKdlNHZWVKMFB1OHl6ck1rOHcv?= =?utf-8?B?dHd2VmZWSlFpOGFZME5XWEl3TlpMN0E1eXpZU01GVjhBWG9UYktyU1lndkJT?= =?utf-8?B?RmlUekY2TXZGTkJlZm54NXZNYWxZMGlKZTEweEg4Sy9Ub3p0RlFwZjdoM2dP?= =?utf-8?B?OC9rek9XbXpBcml2djZkV1d5c25tRjBjL0lMcVBOMGNKV1BYWnVITXNrb24r?= =?utf-8?B?NWdmM05QVzdEME5FUzVrYStKTFZaNXdYVkppU04wbnZ2eEpLS0F0VGYxdk1s?= =?utf-8?B?V3VqblNLM3hackE3eVMzKzBKcWdCeGs2L2RkRU8wNDk0b2FnL0ZwZjJHOWh6?= =?utf-8?B?ejBYUWozVXBYclo1ZVVORSs4ejVuRE13UzB3QW9OMUpvWjNJRHR0cHFEckIx?= =?utf-8?B?Z1lyM0pCSzU5bmd4eTF6YkhiUE1lK1RqVzdjUDdQVUtuQlNqUlZLWmtZSFFR?= =?utf-8?B?RmpKanJ5Rmo0bDRtS2Qrd29SdGNzcFN3RTZ2S052aUh1TFpiRHl6QWdGZGdq?= =?utf-8?B?NTBvblhtaEJUbk5FQWxWTVpVTkdNbTBnNUVaY241YmpmemNrS2dKNFcxNW1V?= =?utf-8?B?TENMc3psZHJCMXZMWTNFenlOb2pzQ3V2OHBoSE9BckdsSmhDdHJ3KzE0SUhU?= =?utf-8?B?YlljSTB1R3I5Mk1NVXg0emtaS2o3N1pQZVU3WXpDVEROME94VEtUUURMRytB?= =?utf-8?B?TEhoRFIxejJEV2xSSUJVTmFNVFdDalV0cTd1ZlpQOTh2aHZ3QUNXenZ5MXRK?= =?utf-8?B?cXUvajFBYS9adUd1R2wvOU5zOWtIZ3MvUzVkMHFlUW5yYnYvYzhkWXpyZ3JK?= =?utf-8?B?UlN3dVJ1VDZ4THBTN3h3ak5DY3lFeXM0cFcwUmhCVUswWnJkWFVkbXorWHlL?= =?utf-8?B?SWQvbk02S0ZIem5zd0dwM1JCdllaaFNOUDJGRGdFY0QyYVRKeTY5Z05aZ05G?= =?utf-8?B?U0kzVnFVNU80NDl3cGh5Z0E0OW9BNWZhVlkvdzdqeWU1NkdDUnFBQ01ob1Ny?= =?utf-8?B?UnNQaVVWSGpNWVFwcm4yaExvQWxaaU1iUnR1SmpNNk84QlJBc1EzbUczV0hO?= =?utf-8?B?RWwvOTkrblJQcHA4NUQvMWlEM0puZW9qbkgxRFFKaHBLL0d5VHFkM1JUUnZ5?= =?utf-8?B?ckNxaTNNbGtJTTdySlVMaWlPcjNPQWVhSklLeitUUFF0SG5peld4dnd4QjJv?= =?utf-8?B?NnVmWU1LOFM3emlqc2drRWVaTmo4YkpSdWQ5clN6QTgvSDVBTElOZlNPK1dk?= =?utf-8?B?K3JtVS9LUjRXdmFScjVpQnlkeVlEa01VRTg1NW84WGhRZWdhb1hoaU9UYzNa?= =?utf-8?B?aU43NVZpK0ZqN0FYTm5CbU4vY3FIWVRyZUhTV2ZwUVFJazZIYkZsdXk0bERJ?= =?utf-8?B?bERZRlhGNUlXWC9uaC9XemFmdUJFb3U4RUVEMlBrVXB2eFhMSUkwMFdWKzB4?= =?utf-8?B?QU8ybS9yalNudW4rQXdTQVVxcXArKzNvR08yN0d6ZWVyWXlkdlJ2a3JqbDhm?= =?utf-8?B?bGI1VXVxWnJlWE9Yc1JhV1d6R1BsZ1FiVlRaaVIrTkJJdzEwK1FFN1E1RjVm?= =?utf-8?B?a3hlTDFVMjBTUlpYbW0vZ1NqZFJZUmt6UHlOS1NKY3VheTRzY1dXNDZ4S01I?= =?utf-8?B?RG1ldVFGVEh0KzR2VTdiK1c2RnIvaG1POSt6U2UvTHA1SjdOL3NycCtQTjVR?= =?utf-8?B?WXdVeG9wSmh4Nk43UEpPaTBST2FjK0xGZEZzcEpwT1RtTXlGL0o4RmhUaFNl?= =?utf-8?Q?5s8aZR9AT7P5miefVtxcVRxmyGegO5oS6tZfy1j?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a334a8d5-e6b6-4035-2bc8-08d91b2b8859 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2021 01:06:43.1786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2hSK+QvUETcoVxq85bqAFnHil5xA39NDJX8U03i0Gg1ftDhfsx7sPzm47suVSEDBKf6ap+vMYzaPuZzkAlWZ+24tvF9WWM0XmzYP2v9b+RU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1891 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_180652_687853_5035D665 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 2021/5/20, 4:20 AM,Rob Herringwrote: On Tue, May 18, 2021 at 08:55:16AM +0800, Billy Tsai wrote: > > + }; > > + }; > > + > > + tach: tach { > > + compatible = "aspeed,ast2600-tach"; > Are pwm and tach separate h/w blocks? Yes, they are the separate h/w blocks. > > + #address-cells = <1>; > > + #size-cells = <0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_tach0_default>; > > + fan@0 { > > + reg = <0>; > How does one configure which PWM is connected to each fan? > Existing bindings use 'reg' for PWM channel and another property for > tach channel. Please don't do something different. The fan node in this place specifically refers tach pin, maybe I need to change the naming to avoid confusion. We just focus on the fan properties on this tach channel has nothing to do with pwm. > + aspeed,min-rpm = <1000>; > + aspeed,pulse-pr = <2>; > + aspeed,tach-div = <5>; > + }; > + }; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel