From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Heiko Stuebner <heiko@sntech.de>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
kernel@collabora.com,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Subject: Re: [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver
Date: Sat, 18 Mar 2023 10:20:50 +0100 [thread overview]
Message-ID: <4586871.LvFx2qVVIh@archbox> (raw)
In-Reply-To: <20230309125651.23911-1-andrzej.p@collabora.com>
On Thursday, 9 March 2023 13:56:49 CET Andrzej Pietrasiewicz wrote:
> Dear All,
>
> This two-patch series adds uAPI for stateless VP8 encoding
> and an accompanying driver using it.
>
> It has been tested on an rk3399 board and there exists
> a gstreamer user:
>
> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3736
>
> example pipeline:
>
> gst-launch-1.0 videotestsrc num-buffers=500 !
> video/x-raw,width=640,height=480 \ ! v4l2slvp8enc ! queue ! matroskamux !
> filesink location=test_vp8.mkv
>
> I kindly ask for comments.
>
> Notably, the documentation for the added uAPI is missing,
> that is to be addressed when sending a patch series proper (not RFC).
>
> For the RFC I also did not care to replace a BUG_ON() in the boolean
> encoder.
>
> Rebased onto v6.2.
>
> Regards,
>
> Andrzej
Hello,
I can't offer much in terms on technical comments on the implementation,
but thank you for your work on this. A more general question: Is the
rate control done by the userspace component or the kernel or even the
hardware?
I tried this patchset (and the gstreamer merge request) out last night
and ran into quite noticable i-frame pulsing, and am wondering who the
culprit of that is. Looking at the vp8 encode params in the uAPI, it
looks like it'll be userspace in charge of rate control?
On a related side note, since I let this run all night with different
parameters I can happily report that it seems to be quite stable, no
problems encountered at all.
Kind regards,
Nicolas Frattaroli
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-18 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:56 [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Andrzej Pietrasiewicz
2023-03-09 12:56 ` [RFC 1/2] media: uapi: Add VP8 stateless encoder controls Andrzej Pietrasiewicz
2023-03-21 13:39 ` Hans Verkuil
2023-03-22 10:06 ` Andrzej Pietrasiewicz
2023-03-24 18:49 ` Nicolas Dufresne
2023-03-27 12:53 ` Andrzej Pietrasiewicz
2023-03-31 14:59 ` Nicolas Dufresne
2023-03-09 12:56 ` [RFC 2/2] media: rkvdec: Add VP8 encoder Andrzej Pietrasiewicz
2023-03-18 23:23 ` Daniel Almeida
2023-03-18 23:27 ` Dmitry Osipenko
2023-03-20 10:34 ` Andrzej Pietrasiewicz
2023-03-20 10:33 ` Andrzej Pietrasiewicz
2023-05-05 16:33 ` guan wentao
2023-05-20 18:57 ` Adam Ford
2023-05-23 6:42 ` Marco Felsch
2023-05-25 14:20 ` Nicolas Dufresne
2023-03-18 9:20 ` Nicolas Frattaroli [this message]
2023-03-20 10:07 ` [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Andrzej Pietrasiewicz
2023-03-20 14:37 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4586871.LvFx2qVVIh@archbox \
--to=frattaroli.nicolas@gmail.com \
--cc=andrzej.p@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).