From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900
Date: Mon, 11 Jul 2016 10:03:25 +0200 [thread overview]
Message-ID: <4765191.NGpMC1JR46@wuerfel> (raw)
In-Reply-To: <1468135649-19980-7-git-send-email-vw@iommu.org>
On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote:
> + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id);
> + if (ret)
> return -EINVAL;
> +
> + soc_dev_attr->machine = "NUC900EVB";
> + soc_dev_attr->family = "NUC900";
> + soc_dev = soc_device_register(soc_dev_attr);
> + if (IS_ERR(soc_dev)) {
> + kfree(soc_dev_attr);
> + return -ENODEV;
> + }
> +
> + ret = regmap_read(syscon_regmap, GCR_CHIPID, &nuc900_chipid);
> + if (ret)
> + return -ENODEV;
> +
> + device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr);
> + device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr);
> +
> + dev_info(&pdev->dev, "Nuvoton Chip ID: 0x%x, Version ID:0x%x\n",
> + nuc900_chipid & GCR_CHIPID_MASK,
> + (nuc900_chipid >> 24) & 0xff);
I'm still a bit unsure about the set of attributes here.
- The "soc_id" is read from the device tree from the field that contains
the board name, I think for consistency you should try to map the
GCR_CHIPID to the name of the SoC and assign that here
- The "machine" is hardcoded to "NUC900EVB", which in turn looks like
a particular board but not the one you are running on. Maybe read
that from the DT instead?
- The "revision" is not filled at all, I would suggest using something
derived from the GCR_CHIPID register here
- you have two nonstandard attributes "chipid" and "version", which
I'd hope to avoid -- the set of standard attributes is supposed to
give enough information about the machine, and platform independent
user space will never read those.
Arnd
next prev parent reply other threads:[~2016-07-11 8:03 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 7:27 [PATCH v2 00/10] ARM: NUC900: Add NUC970 SoC support Wan Zongshun
2016-07-10 7:27 ` [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support Wan Zongshun
2016-07-10 22:11 ` Arnd Bergmann
2016-07-11 16:04 ` Arnd Bergmann
2016-07-12 4:30 ` Wan Zongshun
2016-07-12 7:14 ` Wan Zongshun
2016-07-12 8:23 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 Wan Zongshun
2016-07-10 21:51 ` Paul Gortmaker
2016-07-11 2:19 ` Wan Zongshun
2016-07-11 15:46 ` Arnd Bergmann
2016-07-12 7:04 ` Wan Zongshun
2016-07-12 8:26 ` Arnd Bergmann
2016-07-14 8:52 ` Wan Zongshun
2016-07-14 11:09 ` Arnd Bergmann
2016-07-13 20:09 ` Jason Cooper
2016-07-14 3:36 ` Wan Zongshun
2016-07-14 13:54 ` Jason Cooper
2016-07-15 5:15 ` Wan Zongshun
2016-07-15 7:00 ` Arnd Bergmann
2016-07-15 9:44 ` Wan ZongShun
2016-07-15 10:02 ` Arnd Bergmann
2016-07-21 18:45 ` Jason Cooper
2016-07-15 15:45 ` Jason Cooper
2016-07-10 7:27 ` [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver Wan Zongshun
2016-07-11 15:36 ` Arnd Bergmann
2016-07-12 7:32 ` Wan Zongshun
2016-07-12 8:28 ` Arnd Bergmann
2016-07-21 12:52 ` Daniel Lezcano
2016-07-21 12:54 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 04/10] clk: add Clock driver for nuc970 Wan Zongshun
2016-07-11 22:14 ` Michael Turquette
2016-07-10 7:27 ` [PATCH v2 05/10] power/reset: Add reset driver support for nuc900 Wan Zongshun
2016-07-10 21:56 ` Paul Gortmaker
2016-07-11 2:30 ` Wan Zongshun
2016-07-11 2:58 ` Paul Gortmaker
2016-07-10 7:27 ` [PATCH v2 06/10] soc: Add SoC specific " Wan Zongshun
2016-07-11 8:03 ` Arnd Bergmann [this message]
2016-07-11 9:07 ` Wan Zongshun
2016-07-11 10:24 ` Arnd Bergmann
2016-07-11 10:28 ` Wan ZongShun
2016-07-11 10:36 ` Arnd Bergmann
2016-07-12 9:06 ` Wan Zongshun
2016-07-12 9:50 ` Arnd Bergmann
2016-07-10 7:27 ` [PATCH v2 07/10] ARM: dts: Add clock header file into dt-bindings Wan Zongshun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4765191.NGpMC1JR46@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).