From: Kishon Vijay Abraham I <kishon@ti.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Alan Douglas <adouglas@cadence.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: Jingoo Han <jingoohan1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features
Date: Mon, 11 Feb 2019 18:07:57 +0530 [thread overview]
Message-ID: <47f1a416-6f8b-0c29-21ed-756ba76fc3f5@ti.com> (raw)
In-Reply-To: <a0b12a7f-b341-28a2-edb8-b573d39f6e1b@synopsys.com>
On 11/02/19 3:49 PM, Gustavo Pimentel wrote:
> Hi,
>
> On 14/01/2019 11:14, Kishon Vijay Abraham I wrote:
>> Hi Lorenzo,
>>
>> The Endpoint controller driver uses features member in 'struct pci_epc'
>> to advertise the list of supported features to the endpoint function
>> driver.
>>
>> There are a few shortcomings with this approach.
>> *) Certain endpoint controllers support fixed size BAR (e.g. TI's
>> AM654 uses Designware configuration with fixed size BAR). The
>> size of each BARs cannot be passed to the endpoint function
>> driver.
>> *) Too many macros for handling EPC features.
>> (EPC_FEATURE_NO_LINKUP_NOTIFIER, EPC_FEATURE_BAR_MASK,
>> EPC_FEATURE_MSIX_AVAILABLE, EPC_FEATURE_SET_BAR,
>> EPC_FEATURE_GET_BAR)
>> *) Endpoint controllers are directly modifying struct pci_epc
>> members. (I have plans to move struct pci_epc to
>> drivers/pci/endpoint so that pci_epc members are referenced
>> only by endpoint core).
>>
>> To overcome the above shortcomings, introduced pci_epc_get_features()
>> API, pci_epc_features structure and a ->get_features() callback.
>>
>> Also added a patch to set BAR flags in pci_epf_alloc_space and
>> remove it from pci-epf-test function driver.
>>
>> Changes from v1:
>> *) Fixed helper function to return '0' (or BAR_0) for any incorrect
>> values in reserved BAR.
>> *) Do not set_bar or alloc space for BARs if the BARs are reserved
>> *) Fix incorrect check of epc_features in pci_epf_test_bind
>>
>> Tested on TI's DRA7xx platform and AM654 platform. Support for PCIe
>> in AM654 platform will be posted shortly.
>>
>> Kishon Vijay Abraham I (15):
>> PCI: endpoint: Add new pci_epc_ops to get EPC features
>> PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_ops
>> PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops
>> PCI: pci-dra7xx: Populate ->get_features() dw_pcie_ep_ops
>> PCI: rockchip: Populate ->get_features() dw_pcie_ep_ops
>> PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops
>> PCI: endpoint: Add helper to get first unreserved BAR
>> PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags
>> PCI: pci-epf-test: Remove setting epf_bar flags in function driver
>> PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is
>> 64Bit
>> PCI: pci-epf-test: Use pci_epc_get_features to get EPC features
>> PCI: cadence: Remove pci_epf_linkup from Cadence EP driver
>> PCI: rockchip: Remove pci_epf_linkup from Rockchip EP driver
>> PCI: designware-plat: Remove setting epc->features in Designware plat
>> EP driver
>> PCI: endpoint: Remove features member in struct pci_epc
>>
>> drivers/pci/controller/dwc/pci-dra7xx.c | 13 +++
>> .../pci/controller/dwc/pcie-designware-ep.c | 12 +++
>> .../pci/controller/dwc/pcie-designware-plat.c | 17 +++-
>> drivers/pci/controller/dwc/pcie-designware.h | 1 +
>> drivers/pci/controller/pcie-cadence-ep.c | 25 ++---
>> drivers/pci/controller/pcie-rockchip-ep.c | 16 +++-
>> drivers/pci/endpoint/functions/pci-epf-test.c | 93 ++++++++++++-------
>> drivers/pci/endpoint/pci-epc-core.c | 53 +++++++++++
>> drivers/pci/endpoint/pci-epf-core.c | 4 +-
>> include/linux/pci-epc.h | 31 +++++--
>> 10 files changed, 201 insertions(+), 64 deletions(-)
>>
>
> Sorry for the delay, I had a problem with my setup.
>
> Tested-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Thank you Gustavo!
-Kishon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 11:14 [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features Kishon Vijay Abraham I
2019-01-14 11:14 ` [PATCH v2 01/15] PCI: endpoint: Add new pci_epc_ops to get " Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 02/15] PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_ops Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 03/15] PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 04/15] PCI: pci-dra7xx: " Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 05/15] PCI: rockchip: " Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 06/15] PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 07/15] PCI: endpoint: Add helper to get first unreserved BAR Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags Kishon Vijay Abraham I
2019-02-11 17:37 ` Lorenzo Pieralisi
2019-02-13 13:47 ` Kishon Vijay Abraham I
2019-02-14 16:29 ` Lorenzo Pieralisi
2019-02-15 6:19 ` Kishon Vijay Abraham I
2019-02-15 9:52 ` Lorenzo Pieralisi
2019-01-14 11:15 ` [PATCH v2 09/15] PCI: pci-epf-test: Remove setting epf_bar flags in function driver Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 10/15] PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is 64Bit Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 11/15] PCI: pci-epf-test: Use pci_epc_get_features to get EPC features Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 12/15] PCI: cadence: Remove pci_epf_linkup from Cadence EP driver Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 13/15] PCI: rockchip: Remove pci_epf_linkup from Rockchip " Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 14/15] PCI: designware-plat: Remove setting epc->features in Designware plat " Kishon Vijay Abraham I
2019-01-14 11:15 ` [PATCH v2 15/15] PCI: endpoint: Remove features member in struct pci_epc Kishon Vijay Abraham I
2019-01-15 1:52 ` [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features Shawn Lin
2019-02-11 10:19 ` Gustavo Pimentel
2019-02-11 12:37 ` Kishon Vijay Abraham I [this message]
2019-02-15 10:09 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f1a416-6f8b-0c29-21ed-756ba76fc3f5@ti.com \
--to=kishon@ti.com \
--cc=adouglas@cadence.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).