From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Rob Herring <robh@kernel.org>
Cc: arnd@arndb.de, devicetree@vger.kernel.org, robh+dt@kernel.org,
maz@kernel.org, linux-arm-kernel@lists.infradead.org,
marcan@marcan.st, linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org, kettenis@openbsd.org
Subject: Re: [PATCH 1/2] dt-bindings: pci: Add DT bindings for apple,pcie
Date: Mon, 17 May 2021 10:17:21 +0200 (CEST) [thread overview]
Message-ID: <5612d6300212c4e1@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <1621218423.820656.1315835.nullmailer@robh.at.kernel.org> (message from Rob Herring on Sun, 16 May 2021 21:27:03 -0500)
> From: Rob Herring <robh@kernel.org>
> Date: Sun, 16 May 2021 21:27:03 -0500
>
> On Sun, 16 May 2021 23:18:46 +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@openbsd.org>
> >
> > The Apple PCIe host controller is a PCIe host controller with
> > multiple root ports present in Apple ARM SoC platforms, including
> > various iPhone and iPad devices and the "Apple Silicon" Macs.
> >
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> > .../devicetree/bindings/pci/apple,pcie.yaml | 150 ++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 151 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory
> 20 | #include <dt-bindings/pinctrl/apple.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/pci/apple,pcie.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1416: dt_binding_check] Error 2
While that header file is part of the dependency mentioned in the
cover letter, it isn't even needed. Will fix this when I spin v2.
Sorry for the noise.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-17 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 21:18 [PATCH 0/2] Apple M1 PCIe DT bindings Mark Kettenis
2021-05-16 21:18 ` [PATCH 1/2] dt-bindings: pci: Add DT bindings for apple,pcie Mark Kettenis
2021-05-17 2:27 ` Rob Herring
2021-05-17 8:17 ` Mark Kettenis [this message]
2021-05-17 14:16 ` Rob Herring
2021-05-17 19:41 ` Mark Kettenis
2021-05-17 20:21 ` Rob Herring
2021-05-18 14:10 ` Robin Murphy
2021-05-22 13:57 ` Mark Kettenis
2021-05-16 21:18 ` [PATCH 2/2] arm64: apple: Add PCIe node Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5612d6300212c4e1@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).