From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E605DC282C2 for ; Wed, 13 Feb 2019 14:42:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B21612075D for ; Wed, 13 Feb 2019 14:42:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tP3wO1Q0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21612075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hzl490+G+QXN1sG/Uap3sleodKRT9miHTCvlJLCASFw=; b=tP3wO1Q0JE7yq7 +alQDZDFdPowy5ToA9cBNPsToyY+xmG2LCcTWciPwFsQjmoiZ5fyhM4ub0NHsN7cq9LA5cq3f/Dh1 XtI6QAjAO1fh1dsYuNtTZAQV+/YWpnk8tZ2rqR7J+88PiPCN1tr7yduCkfthkfxCEzi9BjP2mNsmG V7g8Ew0FcgIM7LYsFTujfxtH+ZgNiY9QbgclBKuo/zvgsgPyYkKFbVQTH+oNIKvMzdOim7W9mFqOm zbQsfPT2jfDW6P1hgXor7ad7O2cGDgc/htkFDsPuB02AQu72U2cVJ/h2PyW9Jxe7+PO6bULBi1+V/ WpYEtGI/gRdWEPAta4/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtvjg-0003N1-S7; Wed, 13 Feb 2019 14:42:04 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtvjU-00037b-Nu for linux-arm-kernel@lists.infradead.org; Wed, 13 Feb 2019 14:41:56 +0000 X-Originating-IP: 90.88.30.68 Received: from aptenodytes (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3BA6BE0009; Wed, 13 Feb 2019 14:41:42 +0000 (UTC) Message-ID: <5ad700e4037a58a0621476299a0de02d2f24de11.camel@bootlin.com> Subject: Re: [PATCH v3 6/8] drm/sun4i: dsi: Rework a bit the hblk calculation From: Paul Kocialkowski To: Maxime Ripard , Maarten Lankhorst , Sean Paul Date: Wed, 13 Feb 2019 15:41:41 +0100 In-Reply-To: References: Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_064153_400983_4D8C458E X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > It turns out that the hblk calculation actually follows a similar pattern > than the other packets. Rework a bit the calculation and add a comment. This looks consistent with what the BSP is doing for video mode. Reviewed-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 8e6392831e9d..e0288e7dc64e 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -488,9 +488,13 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, > (mode->hsync_start - mode->hdisplay) * Bpp - HFP_PACKET_OVERHEAD); > > /* > - * hblk seems to be the line + porches length. > + * The blanking is set using a sync event (4 bytes) and a > + * blanking packet (4 bytes + payload + 2 bytes). Its minimal > + * size is therefore 10 bytes. > */ > - hblk = mode->htotal * Bpp - hsa; > +#define HBLK_PACKET_OVERHEAD 10 > + hblk = max((unsigned int)HBLK_PACKET_OVERHEAD, > + (mode->htotal - (mode->hsync_end - mode->hsync_start)) * Bpp - HBLK_PACKET_OVERHEAD); > > /* > * And I'm not entirely sure what vblk is about. The driver in -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel