From: Lokesh Vutla <lokeshvutla@ti.com>
To: Markus Elfring <Markus.Elfring@web.de>,
<linux-arm-kernel@lists.infradead.org>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tero Kristo <t-kristo@ti.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
Date: Mon, 11 Nov 2019 09:05:39 +0530 [thread overview]
Message-ID: <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com> (raw)
In-Reply-To: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de>
On 05/11/19 5:00 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 5 Nov 2019 12:19:39 +0100
>
> A coccicheck run provided information like the following.
>
> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used
> with vint_desc.
>
> Generated by: scripts/coccinelle/api/err_cast.cocci
>
> Thus adjust the exception handling in one if branch.
>
> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator
driver")
With this:
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/irqchip/irq-ti-sci-inta.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index ef4d625d2d80..8f6e6b08eadf 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -246,8 +246,8 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d
> /* No free bits available. Allocate a new vint */
> vint_desc = ti_sci_inta_alloc_parent_irq(domain);
> if (IS_ERR(vint_desc)) {
> - mutex_unlock(&inta->vint_mutex);
> - return ERR_PTR(PTR_ERR(vint_desc));
> + event_desc = ERR_CAST(vint_desc);
> + goto unlock;
> }
>
> free_bit = find_first_zero_bit(vint_desc->event_map,
> @@ -259,6 +259,7 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d
> if (IS_ERR(event_desc))
> clear_bit(free_bit, vint_desc->event_map);
>
> +unlock:
> mutex_unlock(&inta->vint_mutex);
> return event_desc;
> }
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 11:30 [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) Markus Elfring
2019-11-11 3:35 ` Lokesh Vutla [this message]
2019-11-11 10:15 ` Marc Zyngier
2019-11-13 11:05 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com \
--to=lokeshvutla@ti.com \
--cc=Markus.Elfring@web.de \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).