From: Angus Ainslie <angus@akkea.ca>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Jacky Bai" <ping.bai@nxp.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-pm-owner@vger.kernel.org,
"Alexandre Bailon" <abailon@baylibre.com>,
"Anson Huang" <anson.huang@nxp.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
dl-linux-imx <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Martin Kepplinger" <martink@posteo.de>,
linux-arm-kernel@lists.infradead.org,
"Aisheng Dong" <aisheng.dong@nxp.com>,
"Saravana Kannan" <saravanak@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
kernel@pengutronix.de, "Fabio Estevam" <fabio.estevam@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Georgi Djakov" <georgi.djakov@linaro.org>
Subject: Re: [RFCv3 3/3] interconnect: imx: Add platform driver for imx8mm
Date: Wed, 16 Oct 2019 07:09:20 -0700 [thread overview]
Message-ID: <68e456574e2072740f41fac8c9c2377b@akkea.ca> (raw)
In-Reply-To: <VI1PR04MB70231CD1535CBCB699F045D4EE930@VI1PR04MB7023.eurprd04.prod.outlook.com>
On 2019-10-15 07:05, Leonard Crestez wrote:
> On 10.10.2019 17:43, Angus Ainslie wrote:
>>
>> I've integrated your u-boot and ATF on our board and I have a couple
>> of
>> questions. Our board is running imx8mq B0 (Rev 2.0) silicon.
>>
>> It looks like this line limits the training frequencies to 800 MHz and
>> 166 MHz
>
> Yes! This is due to a hardware errata which was solved in B1: DRAM pll
> can't be disabled. This means that instead of 25/100/800 freqs are
> 166/800, and this requires code changes.
>
>> Does 100 MHz and 25 MHz not work on B0 ?
>
> No, lower rates require dram clk from a composite slice (dram_alt_root)
>
>> I added the ddrc_and noc opp as well as the 166MHz opp
>>
>> I also added the interconnects ( do we need them on imx8mq ? )
>
> The interconnect stuff is not required to switch dram frequency, it's
> for device to make minimum bandwidth requests. It an additional feature
> on top.
>
> As a hack I configured FEC to do so but a saner example would be to
> request bandwidth based on display resolution and color depth.
>
>> I had to add a hack as the PM QoS was limiting the bus speed to 399MHz
>> ,
>> if you have any ideas why that would be appreciated.
>
> You probably need to set ethernet down (which is awkward) or better
> just
> drop the interconnect properties and test using the devfreq userspace
> governor.
>
>> The driver is probing
>>
>> [ 12.136537] bus: 'platform': driver_probe_device: matched device
>> 3d400000.dram-controller with driver imx-ddrc-devfrq
>> [ 12.147259] bus: 'platform': really_probe: probing driver
>> imx-ddrc-devfreq with device 3d400000.dram-controller
>> [ 12.157382] imx-ddrc-devfreq 3d400000.dram-controller: no pinctrl
>> handle
>> [ 12.164197] arm_smcc rate 0 800000000
>> [ 12.167880] arm_smcc rate 1 166750000
>> [ 12.171778] of: _opp_add_static_v2: turbo:0 rate:25000000 uv:0
>> uvmin:0 uvmax:0 latency:0
>> [ 12.179994] of: _opp_add_static_v2: turbo:0 rate:100000000 uv:0
>> uvmin:0 uvmax:0 latency:0
>> [ 12.188311] of: _opp_add_static_v2: turbo:0 rate:166750000 uv:0
>> uvmin:0 uvmax:0 latency:0
>> [ 12.196606] of: _opp_add_static_v2: turbo:0 rate:800000000 uv:0
>> uvmin:0 uvmax:0 latency:0
>> [ 12.204930] imx-ddrc-devfreq 3d400000.dram-controller: events from
>> pmu imx8_ddr0
>> [ 12.212403] Added freq 0 25000000
>> [ 12.215742] Added freq 1 100000000
>> [ 12.219177] Added freq 2 166750000
>> [ 12.222648] Added freq 3 800000000
>> [ 12.226105] device: 'devfreq0': device_add
>> [ 12.230287] PM: Adding info for No Bus:devfreq0
>> [ 12.234864] driver: 'imx-ddrc-devfreq': driver_bound: bound to
>> device
>> '3d400000.dram-controller'
>> [ 12.243699] bus: 'platform': really_probe: bound device
>> 3d400000.dram-controller to driver imx-ddrc-devfreq
>>
>> Add seems to run correctly until it tries to adjust the clock to
>> 166MHz
>>
>> [ 19.555482] ddrc checking rate 800000000 166750000
>> [ 19.555489] ddrc checking rate 166750000 166750000
>> [ 19.560442] bus: 'usb-serial': really_probe: bound device ttyUSB0
>> to
>> driver option1
>> [ 19.568751] imx-ddrc-devfreq 3d400000.dram-controller: ddrc about
>> to
>> change freq 800000000 to 166750000
>>
>> And the board hangs there. Any ideas on how to get past this ?
>
> Please try this ATF patch:
>
> https://github.com/cdleonard/arm-trusted-firmware/commit/783fc2b2c4266bfdb5218e4d9b6b2bc90849e0e9
>
Ok applied this to the tree we're using
https://source.puri.sm/Librem5/arm-trusted-firmware/commit/783fc2b2c4266bfdb5218e4d9b6b2bc90849e0e9
> I tested switching on imx8mq-evk with B0 SoC but a few additional
> changes are required in kernel to support switching between rates which
> are both backed by PLL:
>
> * Mark the PLL CLK_GET_RATE_NOCACHE
Is this what you meant ?
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
index 2813884f69c1..e5f50cf8a264 100644
--- a/drivers/clk/imx/clk-imx8mq.c
+++ b/drivers/clk/imx/clk-imx8mq.c
@@ -345,7 +345,7 @@ static int imx8mq_clocks_probe(struct
platform_device *pdev)
clks[IMX8MQ_SYS1_PLL_OUT] = imx_clk_sccg_pll("sys1_pll_out",
sys1_pll_out_sels, ARRAY_SIZE(sys1_pll_out_sels), 0, 0, 0, base + 0x30,
CLK_IS_CRITICAL);
clks[IMX8MQ_SYS2_PLL_OUT] = imx_clk_sccg_pll("sys2_pll_out",
sys2_pll_out_sels, ARRAY_SIZE(sys2_pll_out_sels), 0, 0, 1, base + 0x3c,
CLK_IS_CRITICAL);
clks[IMX8MQ_SYS3_PLL_OUT] = imx_clk_sccg_pll("sys3_pll_out",
sys3_pll_out_sels, ARRAY_SIZE(sys3_pll_out_sels), 0, 0, 1, base + 0x48,
CLK_IS_CRITICAL);
- clks[IMX8MQ_DRAM_PLL_OUT] = imx_clk_sccg_pll("dram_pll_out",
dram_pll_out_sels, ARRAY_SIZE(dram_pll_out_sels), 0, 0, 0, base + 0x60,
CLK_IS_CRITICAL);
+ clks[IMX8MQ_DRAM_PLL_OUT] = imx_clk_sccg_pll("dram_pll_out",
dram_pll_out_sels, ARRAY_SIZE(dram_pll_out_sels), 0, 0, 0, base + 0x60,
CLK_IS_CRITICAL|CLK_GET_RATE_NOCACHE);
/* SYS PLL1 fixed output */
clks[IMX8MQ_SYS1_PLL_40M_CG] = imx_clk_gate("sys1_pll_40m_cg",
"sys1_pll_out", base + 0x30, 9);
> * Set the rate to 166935483 exactly (to match clk_get_rate)
Okay I hacked that in
diff --git a/drivers/devfreq/imx-ddrc.c b/drivers/devfreq/imx-ddrc.c
index 4eed6f50bb8d..a832768a865f 100644
--- a/drivers/devfreq/imx-ddrc.c
+++ b/drivers/devfreq/imx-ddrc.c
@@ -436,6 +436,10 @@ static int imx_ddrc_init_freq_info(struct device
*dev)
return -ENODEV;
}
+ /* B0 hack */
+ if ( freq->rate == 166750000 )
+ freq->rate = 166935483;
+
pr_err( "arm_smcc rate %d %lu\n", index, freq->rate );
}
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -211,7 +211,7 @@
opp-hz = /bits/ 64 <100000000>;
};
opp-166M {
- opp-hz = /bits/ 64 <166750000>;
+ opp-hz = /bits/ 64 <166935483>;
};
opp-800M {
opp-hz = /bits/ 64 <800000000>;
> * Make the rounding in imx-ddrc more generous.
Sorry I don't understand what you mean by this.
Adding the other changes the board no longer hangs when trying to change
frequencies but it also doesn't seem to actually change the frequency.
[ 3.076426] ddrc checking rate 800000000 166935483
[ 3.081290] ddrc checking rate 166935483 166935483
[ 3.086225] imx-ddrc-devfreq 3d400000.dram-controller: ddrc about to
change freq 800000000 to 166935483
[ 3.086891] imx-ddrc-devfreq 3d400000.dram-controller: ddrc changed
freq 800000000 to 166935483
root@pureos:~# cat /sys/class/devfreq/devfreq0/cur_freq
800000000
root@pureos:~# cat /sys/class/devfreq/devfreq0/target_freq
166935483
Is this the missing rounding or is there something else missing ?
Thanks
Angus
>
> I will integrate these changes into the next version.
>
> --
> Regards,
> Leonard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 10:55 [RFCv3 0/3] interconnect: Add imx support via devfreq Leonard Crestez
2019-08-06 10:55 ` [RFCv3 1/3] dt-bindings: interconnect: Add bindings for imx Leonard Crestez
2019-08-07 15:16 ` Georgi Djakov
2019-08-07 22:35 ` Leonard Crestez
2019-08-06 10:55 ` [RFCv3 2/3] interconnect: Add imx core driver Leonard Crestez
2019-08-07 15:16 ` Georgi Djakov
2019-08-06 10:55 ` [RFCv3 3/3] interconnect: imx: Add platform driver for imx8mm Leonard Crestez
2019-08-21 14:02 ` Martin Kepplinger
2019-08-21 14:21 ` Leonard Crestez
2019-08-21 14:26 ` Martin Kepplinger
2019-10-10 14:43 ` Angus Ainslie
2019-10-15 14:05 ` Leonard Crestez
2019-10-16 14:09 ` Angus Ainslie [this message]
2019-10-16 14:54 ` Leonard Crestez
2019-10-17 13:25 ` Angus Ainslie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e456574e2072740f41fac8c9c2377b@akkea.ca \
--to=angus@akkea.ca \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm-owner@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martink@posteo.de \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).