From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6525DC433ED for ; Tue, 11 May 2021 11:44:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE8706117A for ; Tue, 11 May 2021 11:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE8706117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=32Nsh5AxIURsO8b45qVjLIP1cRlFISAT52FrNuA9B2E=; b=Va0KVKNMApPxgLnNdZvpzyel+ 8q9FU6vb7tlf6YRHdS47k7eTBR+9x6mBkWIez+IiDf1ULvAnyHkqZbnOYCffOqaQa0fjE2aTjUl0K zJ6ibMcKDZMPApS83XDLd6tfut7KS/JiQuuJrgHEA85w82nkXBFr7JSOyTgfCbCRTEVBORU5qiUfC Y2UTrvxn0mMaIdB7WApQqunp6SrYvwcFLpsQaM6PotDKxCvJ/OBG7tb7Ph6wCLJT9mKDvYnqx8zC5 /kIJ4VMoCT/r5GHQU1gPdRZwAMlj6QRYF/Pk0ZsX0X3qinf+U90GPXPPx/EwSkMbA131LEig/qOwC FZ2bed8Lg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgQnQ-00HBPR-6q; Tue, 11 May 2021 11:43:29 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgMbg-00GUFD-9I for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 07:15:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=wx90dXV8lGnsELW8Rcz3npcSR1GVu74NkPTQbdweJFg=; b=0S22VzKqXh6sTCfXGW39IFl1sV yKhatuQ5yug39Egazxcaz1g4JZmlNpgpWTVufDvAinzhqzBiHAkPCX00HJnH80n+9X+fcpMH38XyX kjs2Y9RLN4kGT8HJm4Btn6iVYth/Usd+3h8tIwARnqsfZQVM+TY8du2YxC/EGMDmt8eOfIRzfg84/ P0BP8H2Q8DzGWqRDOHlyDcpUz1GMDHqax3GyAComiOajc2HukTk+OCCMGULsZ9OmRIBQLeL/PgFAS 2aN1jedyOZnjblLmd6kEaumd1Xk8zYHtJo25U0Is6Y2IWr7norX5nSOYeOP5qbbkqGpSpo9Km//aL symY2hVw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgMbd-009M90-Hs for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 07:15:03 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A6AF061926; Tue, 11 May 2021 07:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620717301; bh=Ol3Y3NGUoh+XLbyDQdLjaDsjUT2yr2pIhlJoigW1IRI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SlfDAwDlc2JbUfweLW37FbFNwsd086fIdg3r6tNg1yy2Atb8mdRA5xYtDzZfTLv8B YkTocbqXLewhM1i+FjoUHMCDeB7E4e8fBB4z2v7yEEunQZpN/oajGRL3oZIdahCfCk RjusI4cZNFOc2moNCgRsI+ednBAkNf0mHPMGMK4jKU0lObVKtQj/jjmewUuyralaco DZTDWlE5KsCQP3VRvTtUQEW6SG98zBDB7W21cYJQJ08im4JGAbg5fnm5u+PZJ4uW1D LJaPqZfZGXHGQepFlN+7kT99NL/zgrZZHUAjGAob8ZT3T5rWPm8jE6UpE2Ckluty0t BxGZR3ikpflkQ== Subject: Re: [PATCH] arm64: dts: ti: k3-am65|j721e|am64: Map the dma / navigator subsystem via explicit ranges To: Nishanth Menon , vigneshr@ti.com, grygorii.strashko@ti.com Cc: lokeshvutla@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210510145429.8752-1-nm@ti.com> From: Tero Kristo Message-ID: <6efd1297-d174-d915-44f7-a4ad6ff46b52@kernel.org> Date: Tue, 11 May 2021 10:14:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210510145429.8752-1-nm@ti.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_001501_671113_7114ECF7 X-CRM114-Status: GOOD ( 18.09 ) /bin/ln: failed to access 'reaver_cache/texts/20210511_001501_671113_7114ECF7': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_001501_671113_7114ECF7 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/05/2021 17:54, Nishanth Menon wrote: > Instead of using empty ranges property, lets map explicitly the address > range that is mapped onto the dma / navigator subsystems (navss/dmss). > > This is also exposed via the dtbs_check with dt-schema newer than > 2021.03 version by throwing out following: > arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: bus@100000: main-navss: > {'type': 'object'} is not allowed for > {'compatible': ['simple-mfd'], '#address-cells': [[2]], ..... > > This has already been correctly done for J7200, however was missed for > other k3 SoCs. Fix that oversight. > > Signed-off-by: Nishanth Menon Reviewed-by: Tero Kristo > --- > > if possible, I'd like to pick this fixup for 5.13 window.. > > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- > 5 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index a49e41021573..bb19db04a746 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -42,12 +42,12 @@ gic_its: msi-controller@1820000 { > }; > }; > > - dmss: dmss { > + dmss: bus@48000000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > dma-ranges; > - ranges; > + ranges = <0x00 0x48000000 0x00 0x48000000 0x00 0x06400000>; > > ti,sci-dev-id = <25>; > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 037f9776c4c8..fea8260d33a8 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -445,11 +445,11 @@ intr_main_gpio: interrupt-controller@a00000 { > ti,interrupt-ranges = <0 392 32>; > }; > > - main-navss { > + main_navss: bus@30800000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x0 0x30800000 0x0 0x30800000 0x0 0xbc00000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 0388c02c2203..f5b8ef2f5f77 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -116,11 +116,11 @@ adc { > }; > }; > > - mcu-navss { > + mcu_navss: bus@28380000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 512371e36a30..b2d25af872e2 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -88,11 +88,11 @@ main_gpio_intr: interrupt-controller@a00000 { > ti,interrupt-ranges = <8 392 56>; > }; > > - main-navss { > + main_navss: bus@30000000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index ad12a5c9f209..172629fa3c7c 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -250,11 +250,11 @@ adc { > }; > }; > > - mcu-navss { > + mcu_navss: bus@28380000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>; > dma-coherent; > dma-ranges; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel