From: Ray Jui <ray.jui@broadcom.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
"wsa@kernel.org" <wsa@kernel.org>,
"rjui@broadcom.com" <rjui@broadcom.com>,
"sbranden@broadcom.com" <sbranden@broadcom.com>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Laing <Richard.Laing@alliedtelesis.co.nz>
Subject: Re: [PATCH] i2c: bcm-iproc: Add i2c recovery support
Date: Thu, 3 Jun 2021 10:01:08 -0700 [thread overview]
Message-ID: <71f52763-450b-155a-693a-ba37ce98a1e9@broadcom.com> (raw)
In-Reply-To: <d133a136-11c1-1693-6f9b-e6fcf6a448f6@alliedtelesis.co.nz>
[-- Attachment #1.1: Type: text/plain, Size: 1248 bytes --]
On 6/1/2021 7:32 PM, Chris Packham wrote:
>
> On 2/06/21 9:03 am, Ray Jui wrote:
>>
>> On 5/30/2021 3:56 PM, Chris Packham wrote:
>>> From: Richard Laing <richard.laing@alliedtelesis.co.nz>
>>>
>>> The bcm-iproc controller can put the SDA/SCL lines into bit-bang mode,
>>> make use of this to support i2c bus recovery.
>>>
>>> Signed-off-by: Richard Laing <richard.laing@alliedtelesis.co.nz>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>> ---
> <snip>
>> +
>>> +static struct i2c_bus_recovery_info bcm_iproc_recovery_info = {
>> static const struct ...
>
> The kernel test bot doesn't like the suggestion.
>
> >> drivers/i2c/busses/i2c-bcm-iproc.c:1264:26: error: assigning to
> 'struct i2c_bus_recovery_info *' from 'const struct
> i2c_bus_recovery_info *' discards qualifiers
> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>
> adap->bus_recovery_info = &bcm_iproc_recovery_info;
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~
>
> I can see why. Are you happy for me to drop the const in v3? Or perhaps
> you have a better suggestion.
>
Yeah of course. Please drop it. Sorry I missed that while making that
suggestion.
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-03 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 22:56 [PATCH] i2c: bcm-iproc: Add i2c recovery support Chris Packham
2021-06-01 21:03 ` Ray Jui
2021-06-01 21:44 ` Chris Packham
2021-06-01 21:51 ` Ray Jui
2021-06-02 2:32 ` Chris Packham
2021-06-03 17:01 ` Ray Jui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f52763-450b-155a-693a-ba37ce98a1e9@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Richard.Laing@alliedtelesis.co.nz \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).