From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B39C11F64 for ; Thu, 1 Jul 2021 15:02:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE79613E3 for ; Thu, 1 Jul 2021 15:02:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE79613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9BrAIhouU4tb0sVGV6Wn7jl6a+FDSBpPdiK1CizP/SU=; b=ZxVb4eFGgCYqX0JvjDSfQ+wbM/ bcPLzCcXBqZlhO7AmkkM9PQ4NvCHeO1KHaDJeZXbxiKlcKGhsgXDRsEtHJL7jjo8PcLD6igdR0i/q UAoGn03fBAan71LSldai7gGQJ60qtTVD67pX9asF7qLnyDB5qV4VsNwMPVOtFQlMA5hoNIyaxKNpc 35C71MgBULLYrBCexL2RchRC2LpQsWWJhIrRXY78+idDlOU88NTzQJlxDjyx/Fr+hNTYmX+sb4A4/ Kel3/iAZDiH0l0GOOKwZWWeJKxaxjBfizVCBawcuoQCvzUDfZPz0I23QLQ1O6ue5xzRTOQXGIgp0T 79bKs+MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyyAM-0008M5-Sk; Thu, 01 Jul 2021 14:59:47 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyyAI-0008Km-Av for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 14:59:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625151581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IVh85kthu0SpW7UY6smgM11I1yNN5lgiNNeNgndC7x4=; b=MvapEKOmZd7GA2yAqgyTkx9CZbJmVcNwsQ3UKju4AYZT0JxwBRq24vAa6p8HTBK2hxGgfZ lW2KvVeIwaxpgu9PhsJ3BEYzKiMiXdu/N70L80ixiOXk3u6KHyKE3YEB423z1Su5ms5c8l MRk4rsUGsHeZrlctVE6gvBm5fVIEtRg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-VsR1Z-JeMwW7JwxZ5N1h8w-1; Thu, 01 Jul 2021 10:59:38 -0400 X-MC-Unique: VsR1Z-JeMwW7JwxZ5N1h8w-1 Received: by mail-wr1-f71.google.com with SMTP id l12-20020a5d410c0000b029012b4f055c9bso2453842wrp.4 for ; Thu, 01 Jul 2021 07:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IVh85kthu0SpW7UY6smgM11I1yNN5lgiNNeNgndC7x4=; b=cDgpOvgF0Chu4zres1EEOft8KuKimQcLcKQWZ/x/gLcF3T8bs+a3yOOCNdtuL0vfrT X7V1tn47SJP5dE1H814JspMB6Mj51y1IwE7S3eQhaz0pb06YA2LXQtG9kC0xli8Cj0aZ 8adIJCgVdw3HhrT7f9M2/q2R/drfRI48p/WDsvh+DH4bPOCaIBSvYvElFJv6bxFbsEJU tUApbOQJlIlOPbaDM0+N7exLmS/116rljAbwjQoYp65DHb9q3QpFzb4SZgKjtJxg224w brbLAZSqpz1wXikXjWJyNNxwIMc2fuACV8e18uwIhtKRS3ENdVkYkpRIf+VP/XxRO4jN 08Mw== X-Gm-Message-State: AOAM532TQX7t9TW+idE3izEeptL3Y097g+jZox9eaL5FRBP66XMuUt24 TZcqKjfm5ewGOg5BfDghlnVwDbgmucFvBcNHB3QNYq38PbtzO28+UJlvsNyaeahaXiizxmKFlv4 h416Qj+yGZ9C08lizJfeSiewgEsqebiOXGAU= X-Received: by 2002:a7b:c39a:: with SMTP id s26mr123458wmj.115.1625151577070; Thu, 01 Jul 2021 07:59:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeHU3WCUYY7UnaCN/G0uYLtwdgKJ2wXf9QG99tZjlIEUdpQJOc/y9rZPsTlaSCWiCikljylg== X-Received: by 2002:a7b:c39a:: with SMTP id s26mr123429wmj.115.1625151576888; Thu, 01 Jul 2021 07:59:36 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id n19sm277863wms.4.2021.07.01.07.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jul 2021 07:59:36 -0700 (PDT) Subject: Re: [PATCH v2] PCI: rockchip: Avoid accessing PCIe registers with clocks gated To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, Peter Robinson , Shawn Lin , Bjorn Helgaas , Heiko Stuebner , Lorenzo Pieralisi , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Michal Simek , Jingoo Han , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org References: <20210701135949.GA51123@bjorn-Precision-5520> From: Javier Martinez Canillas Message-ID: <747df123-0aa0-7cb7-9fb3-f13c849894e5@redhat.com> Date: Thu, 1 Jul 2021 16:59:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701135949.GA51123@bjorn-Precision-5520> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_075942_479463_C489A577 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/1/21 3:59 PM, Bjorn Helgaas wrote: [snip] >> The IRQ handler is not called when unregistered, but it is called >> when another handler for the shared IRQ is unregistered. In this >> particular driver, both a "pcie-sys" and "pcie-client" handlers are >> registered, then an error leads to "pcie-sys" being unregistered and >> the handler for "pcie-client" being called. > > Is this really true? I think that would mean CONFIG_DEBUG_SHIRQ would > not find this kind of bug unless we actually registered two or more > handlers for the shared IRQ, but it's still a bug even only one > handler is registered. > > Looking at __free_irq() [1], my impression is that "action" is what > we're removing and action->handler() is the IRQ handler we call when > CONFIG_DEBUG_SHIRQ, so it doesn't look like it's calling the remaining > handlers after removing one of them. > Oh, you are completely right. I wrongly assumed that it was for the other registered IRQ handlers but reading the source is clearly how you say it. I now wonder why when debugging this I saw that the "pcie-client" handler was called when "pcie-sys" was unregistered... But anyways, you are correct and I'm OK with the text you shared. Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel