From: Yuehaibing <yuehaibing@huawei.com>
To: <nm@ti.com>, <t-kristo@ti.com>, <ssantosh@kernel.org>,
<s-anna@ti.com>, <santosh.shilimkar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 -next] firmware: ti_sci: remove set but not used variable 'dev'
Date: Sat, 15 Jun 2019 20:46:00 +0800 [thread overview]
Message-ID: <74b6ab2e-09c0-a91d-6339-cb6b72eb4261@huawei.com> (raw)
In-Reply-To: <20190615123823.15708-1-yuehaibing@huawei.com>
Sorry, Pls ignore this, will fix the patch title
On 2019/6/15 20:38, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config:
> drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable]
> drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config:
> drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable]
> drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg:
> drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable]
> drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg:
> drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable]
>
> Use the 'dev' variable instead of 'info->dev' to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: use the 'dev' variable as Suman Anna's suggestion
> ---
> drivers/firmware/ti_sci.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 86b2727..c8da6e2 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -2046,7 +2046,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle,
> sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> - dev_err(info->dev, "RM_RA:Message config failed(%d)\n", ret);
> + dev_err(dev, "RM_RA:Message config failed(%d)\n", ret);
> return ret;
> }
> req = (struct ti_sci_msg_rm_ring_cfg_req *)xfer->xfer_buf;
> @@ -2062,7 +2062,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle,
>
> ret = ti_sci_do_xfer(info, xfer);
> if (ret) {
> - dev_err(info->dev, "RM_RA:Mbox config send fail %d\n", ret);
> + dev_err(dev, "RM_RA:Mbox config send fail %d\n", ret);
> goto fail;
> }
>
> @@ -2071,7 +2071,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle,
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);
> - dev_dbg(info->dev, "RM_RA:config ring %u ret:%d\n", index, ret);
> + dev_dbg(dev, "RM_RA:config ring %u ret:%d\n", index, ret);
> return ret;
> }
>
> @@ -2115,7 +2115,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
> sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> - dev_err(info->dev,
> + dev_err(dev,
> "RM_RA:Message get config failed(%d)\n", ret);
> return ret;
> }
> @@ -2125,7 +2125,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
>
> ret = ti_sci_do_xfer(info, xfer);
> if (ret) {
> - dev_err(info->dev, "RM_RA:Mbox get config send fail %d\n", ret);
> + dev_err(dev, "RM_RA:Mbox get config send fail %d\n", ret);
> goto fail;
> }
>
> @@ -2150,7 +2150,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);
> - dev_dbg(info->dev, "RM_RA:get config ring %u ret:%d\n", index, ret);
> + dev_dbg(dev, "RM_RA:get config ring %u ret:%d\n", index, ret);
> return ret;
> }
>
> @@ -2298,7 +2298,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
> sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> - dev_err(info->dev, "Message TX_CH_CFG alloc failed(%d)\n", ret);
> + dev_err(dev, "Message TX_CH_CFG alloc failed(%d)\n", ret);
> return ret;
> }
> req = (struct ti_sci_msg_rm_udmap_tx_ch_cfg_req *)xfer->xfer_buf;
> @@ -2323,7 +2323,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
>
> ret = ti_sci_do_xfer(info, xfer);
> if (ret) {
> - dev_err(info->dev, "Mbox send TX_CH_CFG fail %d\n", ret);
> + dev_err(dev, "Mbox send TX_CH_CFG fail %d\n", ret);
> goto fail;
> }
>
> @@ -2332,7 +2332,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);
> - dev_dbg(info->dev, "TX_CH_CFG: chn %u ret:%u\n", params->index, ret);
> + dev_dbg(dev, "TX_CH_CFG: chn %u ret:%u\n", params->index, ret);
> return ret;
> }
>
> @@ -2368,7 +2368,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
> sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> - dev_err(info->dev, "Message RX_CH_CFG alloc failed(%d)\n", ret);
> + dev_err(dev, "Message RX_CH_CFG alloc failed(%d)\n", ret);
> return ret;
> }
> req = (struct ti_sci_msg_rm_udmap_rx_ch_cfg_req *)xfer->xfer_buf;
> @@ -2392,7 +2392,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
>
> ret = ti_sci_do_xfer(info, xfer);
> if (ret) {
> - dev_err(info->dev, "Mbox send RX_CH_CFG fail %d\n", ret);
> + dev_err(dev, "Mbox send RX_CH_CFG fail %d\n", ret);
> goto fail;
> }
>
> @@ -2401,7 +2401,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);
> - dev_dbg(info->dev, "RX_CH_CFG: chn %u ret:%d\n", params->index, ret);
> + dev_dbg(dev, "RX_CH_CFG: chn %u ret:%d\n", params->index, ret);
> return ret;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-15 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 15:44 [PATCH -next] firmware: ti_sci: remove set but not used variable 'dev' YueHaibing
2019-06-14 16:26 ` Suman Anna
2019-06-15 12:38 ` [PATCH v2 " YueHaibing
2019-06-15 12:46 ` Yuehaibing [this message]
2019-06-15 12:50 ` [PATCH v3 -next] firmware: ti_sci: Fix gcc unused-but-set-variable warning YueHaibing
2019-06-17 18:41 ` Suman Anna
2019-06-19 4:35 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b6ab2e-09c0-a91d-6339-cb6b72eb4261@huawei.com \
--to=yuehaibing@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-anna@ti.com \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).