From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] iio:adc:lpc32xx Cleanup headers
Date: Fri, 15 Feb 2019 16:42:55 +0100 [thread overview]
Message-ID: <87r2c92h34.fsf@FE-laptop> (raw)
In-Reply-To: <20190209171646.49c75afc@archlinux>
Hi Jonathan,
On sam., févr. 09 2019, Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 8 Feb 2019 17:09:43 +0100
> Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
>
>> A few headers was useless: remove them, and also sort them in alphabetic
>> order.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> Hmm. Given the headers in question are mostly only useless (I think)
> in the sense they are always included by something else, I'm
> not sure this patch is worth the churn.
>
> It's also tricky to see which ones were actually removed
> given the combination with sorting.
> I think it's just kernel.h, device.h, err.h all of which
> are used in various ways and often directly included.
Actually, as I needed to add a header, I wanted to sort the list to put
it in the right place and then some of the header looked superfluous
that why I remove some of them. For example there was no reason to use
slab.h or of.h.
>
> The other one is the iio/sysfs.h file. That one we could
> do to eventually kill off entirely, so happy to see that
> one alone go.
I am nit sure to know what do you want with this patch.
Gregory
>
> Jonathan
>
>> ---
>> drivers/iio/adc/lpc32xx_adc.c | 15 ++++-----------
>> 1 file changed, 4 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
>> index e361c1532a75..f391c1e10136 100644
>> --- a/drivers/iio/adc/lpc32xx_adc.c
>> +++ b/drivers/iio/adc/lpc32xx_adc.c
>> @@ -7,20 +7,13 @@
>> * Copyright (C) 2011, 2012 Roland Stigge <stigge@antcom.de>
>> */
>>
>> -#include <linux/module.h>
>> -#include <linux/platform_device.h>
>> -#include <linux/interrupt.h>
>> -#include <linux/device.h>
>> -#include <linux/kernel.h>
>> -#include <linux/slab.h>
>> -#include <linux/io.h>
>> #include <linux/clk.h>
>> -#include <linux/err.h>
>> #include <linux/completion.h>
>> -#include <linux/of.h>
>> -
>> #include <linux/iio/iio.h>
>> -#include <linux/iio/sysfs.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/io.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>>
>> /*
>> * LPC32XX registers definitions
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-15 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 16:09 [PATCH 0/5] Adding scale support to the lpc32xx ADC driver Gregory CLEMENT
2019-02-08 16:09 ` [PATCH 1/5] dt-bindings: iio: adc: move lpc32xx-adc out of staging Gregory CLEMENT
2019-02-09 17:05 ` Jonathan Cameron
2019-02-08 16:09 ` [PATCH 2/5] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Gregory CLEMENT
2019-02-09 17:09 ` Jonathan Cameron
2019-02-09 18:07 ` Vladimir Zapolskiy
2019-02-15 16:07 ` Gregory CLEMENT
2019-02-20 12:11 ` Sylvain Lemieux
2019-02-25 23:32 ` Rob Herring
2019-02-08 16:09 ` [PATCH 3/5] iio:adc:lpc32xx use SPDX-License-Identifier Gregory CLEMENT
2019-02-09 17:10 ` Jonathan Cameron
2019-02-08 16:09 ` [PATCH 4/5] iio:adc:lpc32xx Cleanup headers Gregory CLEMENT
2019-02-09 17:16 ` Jonathan Cameron
2019-02-15 15:42 ` Gregory CLEMENT [this message]
2019-02-18 14:07 ` Jonathan Cameron
2019-02-08 16:09 ` [PATCH 5/5] iio:adc:lpc32xx Add scale feature Gregory CLEMENT
2019-02-09 17:23 ` Jonathan Cameron
2019-02-15 15:35 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2c92h34.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).