From: Hanjun Guo <guohanjun@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <jroedel@suse.de>,
Eric Auger <eric.auger@redhat.com>, Will Deacon <will@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API
Date: Fri, 14 May 2021 08:42:36 +0800 [thread overview]
Message-ID: <9026d9a3-9f17-6686-d64e-009326ec6e90@huawei.com> (raw)
In-Reply-To: <CAJZ5v0iQA91927-OXWVRu2_yNgTS-7b8ew4uvo+qk8q86vzOsg@mail.gmail.com>
On 2021/5/11 21:51, Rafael J. Wysocki wrote:
> On Tue, May 11, 2021 at 2:55 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
>> The older device property API is going to be removed.
>> Replacing the device_add_properties() call with software
>> node API equivalent device_create_managed_software_node().
>>
>> Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits")
>> Signed-off-by: Heikki Krogerus<heikki.krogerus@linux.intel.com>
>> ---
>> drivers/acpi/arm64/iort.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
>> index 3912a1f6058e5..e34937e11186a 100644
>> --- a/drivers/acpi/arm64/iort.c
>> +++ b/drivers/acpi/arm64/iort.c
>> @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev,
>> FIELD_GET(ACPI_IORT_NC_PASID_BITS,
>> nc->node_flags));
>>
>> - if (device_add_properties(dev, props))
>> + if (device_create_managed_software_node(dev, props, NULL))
>> dev_warn(dev, "Could not add device properties\n");
>> }
>>
>> --
> Thanks!
>
> I can take this through the ACPI tree if there are no objections.
Since this is related to device property API refactor, I'm
fine with it.
Lorenzo, what's your position?
Thanks
Hanjun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-14 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 12:55 [PATCH] ACPI/IORT: Handle device properties with software node API Heikki Krogerus
2021-05-11 13:51 ` Rafael J. Wysocki
2021-05-14 0:42 ` Hanjun Guo [this message]
2021-05-14 10:39 ` Lorenzo Pieralisi
2021-05-14 13:13 ` Heikki Krogerus
2021-05-17 14:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9026d9a3-9f17-6686-d64e-009326ec6e90@huawei.com \
--to=guohanjun@huawei.com \
--cc=eric.auger@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).