From: Joe Perches <joe@perches.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Pascal Paillet <p.paillet@st.com>,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
robh+dt@kernel.org, mark.rutland@arm.com, rui.zhang@intel.com,
edubezval@gmail.com, amit.kucheria@verdurent.com,
david.hernandezsanchez@st.com, wsa+renesas@sang-engineering.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH 2/4] thermal: stm32: fix IRQ flood on low threshold
Date: Tue, 29 Oct 2019 10:24:50 -0700 [thread overview]
Message-ID: <9dd814577107edc42c4469ee7c923e062a2b5368.camel@perches.com> (raw)
In-Reply-To: <026e676e-0a6c-81ca-3af4-2832118b9ddf@linaro.org>
On Tue, 2019-10-29 at 18:21 +0100, Daniel Lezcano wrote:
> On 29/10/2019 18:15, Joe Perches wrote:
> > On Tue, 2019-10-29 at 18:11 +0100, Daniel Lezcano wrote:
> > > On 29/10/2019 17:45, Pascal Paillet wrote:
> > > > Fix IRQ flood on low threshold by too ways:
> > >
> > > Can you state the issue first ?
> > >
> > > > - improve temperature reading resolution,
> > > > - add an hysteresis to the low threshold: on low threshold interrupt,
> > > > it is not possible to get the temperature value that has fired the
> > > > interrupt. The time to acquire a new value is enough for the CPU to
> > > > become hotter than the current low threshold.
> > []
> > > > Signed-off-by: Pascal Paillet <p.paillet@st.com>
> > > > Change-Id: I3b63b8aab38fd651a165c4e69a2d090b3c6f5db3
> > >
> > > Please remove the Change-Id tag.
> > >
> > > Joe, Andy? checkpatch does not see the Change-Id, is it the expected
> > > behavior?
> >
> > Yes. It's after a sign-off so checkpatch doesn't care.
>
> Ah, I guess it is for Gerrit but we don't want those Change-Id in the
> kernel history, right?
So remove it from the patch.
checkpatch is not a perfect tool.
checkpatch will never be a perfect tool.
It's not possible for checkpatch to be a perfect tool.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-29 17:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 16:45 [PATCH 0/4] thermal: stm32: driver improvements Pascal Paillet
2019-10-29 16:45 ` [PATCH 1/4] thermal: stm32: implement set_trips callback Pascal Paillet
2019-10-29 17:34 ` Daniel Lezcano
2019-10-29 16:45 ` [PATCH 2/4] thermal: stm32: fix IRQ flood on low threshold Pascal Paillet
2019-10-29 17:11 ` Daniel Lezcano
2019-10-29 17:15 ` Joe Perches
2019-10-29 17:21 ` Daniel Lezcano
2019-10-29 17:24 ` Joe Perches [this message]
2019-10-29 17:34 ` Daniel Lezcano
2019-10-29 16:45 ` [PATCH 3/4] thermal: stm32: fix engineering calibration value Pascal Paillet
2019-10-29 16:45 ` [PATCH 4/4] ARM: dts: stm32: remove thermal passive trip point on stm32mp157c Pascal Paillet
2019-10-29 17:36 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dd814577107edc42c4469ee7c923e062a2b5368.camel@perches.com \
--to=joe@perches.com \
--cc=alexandre.torgue@st.com \
--cc=amit.kucheria@verdurent.com \
--cc=apw@canonical.com \
--cc=daniel.lezcano@linaro.org \
--cc=david.hernandezsanchez@st.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).