From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
Hulk Robot <hulkci@huawei.com>, Sumit Gupta <sumitg@nvidia.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map
Date: Fri, 24 Jul 2020 16:03:20 +0530 [thread overview]
Message-ID: <9e84050e-d748-5840-128c-2438ac005416@arm.com> (raw)
In-Reply-To: <20200724093528.GB23388@gaia>
On 07/24/2020 03:05 PM, Catalin Marinas wrote:
> On Fri, Jul 24, 2020 at 10:13:52AM +0100, Mark Rutland wrote:
>> On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote:
>>> On 07/24/2020 08:38 AM, Kefeng Wang wrote:
>>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>>>> ---
>>>>> � arch/arm64/kernel/setup.c | 1 +
>>>>> � 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
>>>>> index c793276ec7ad9..3aea05fbb9998 100644
>>>>> --- a/arch/arm64/kernel/setup.c
>>>>> +++ b/arch/arm64/kernel/setup.c
>>>>> @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)
>>>>> � arch_initcall(reserve_memblock_reserved_regions);
>>>>> � � u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
>>>>> +EXPORT_SYMBOL(__cpu_logical_map);
>>
>> If modules are using cpu_logical_map(), this looks sane ot me, but I
>> wonder if we should instead turn cpu_logical_map() into a C wrapper in
>> smp.c, or at least mark __cpu_logical_map as __ro_after_init lest
>> someone have the bright idea to fiddle with it.
>
> I'd go for a C wrapper and also change a couple of instances where we
> assign a value directly to cpu_logical_map(cpu).
Probably also create a set_cpu_logical_map(cpu, hwid) for those instances
as well.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-24 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200724030433.22287-1-wangkefeng.wang@huawei.com>
2020-07-24 3:08 ` [PATCH -next] arm64: Export __cpu_logical_map Kefeng Wang
2020-07-24 8:16 ` Anshuman Khandual
2020-07-24 9:13 ` Mark Rutland
2020-07-24 9:35 ` Catalin Marinas
2020-07-24 10:33 ` Anshuman Khandual [this message]
2020-07-24 9:16 ` Kefeng Wang
2020-07-24 9:30 ` Catalin Marinas
2020-07-24 10:36 ` Anshuman Khandual
2020-07-24 9:43 ` Christoph Hellwig
2020-07-24 13:10 ` Sudeep Holla
2020-07-25 2:00 ` Kefeng Wang
2020-07-26 11:46 ` Sumit Gupta
2020-07-27 16:05 ` Sudeep Holla
2020-08-01 12:16 ` Sumit Gupta
2020-08-10 7:49 ` Sudeep Holla
2020-08-10 10:19 ` Catalin Marinas
2020-08-10 12:11 ` Sudeep Holla
2020-08-11 19:44 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e84050e-d748-5840-128c-2438ac005416@arm.com \
--to=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=hulkci@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).