From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AE4C433B4 for ; Fri, 21 May 2021 06:16:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F15161004 for ; Fri, 21 May 2021 06:16:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F15161004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qsl658bBPBCI4+jrt6GNSSo/lUr7sedTlDd2js5iwFM=; b=fwmPnzto4p+zMFxt5/FtjSd+gd gLtqR3zQ1Z0hHofY2NNXydE96/uVgXtzEoQpNBrrlCYP4Faj8ebXX/F9/2d6MuifS8XAr/oKkP7At gNrVInQgbGKyXUK+9mB9xawe9hlCyXfnHA/5zki1aHBcSgHMMk++23wbVVJvFJyAc+rW16Sy4bVpk 2453NHzu5SvLuK+iELb2ViDPHKVK7MZ3spYN+E507MJsnSP1ZcmN8qwpPKmQsCWeIv/B5eGmQwSuQ syMfsEANncXq+t+pJ6UN7WnQN9lS291PmI6T8wZkcLQZjZe+G9tBFZ/nbcegIye6FIMJquyWhnYFg Je3Ny8yQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljyQT-003xFD-EI; Fri, 21 May 2021 06:14:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljyQP-003xF0-VZ for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 06:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=Uw5uqVpqkLCh42wGjEPyWL3X4e+hh7jQ6qIs0Gpsx8g=; b=A9cmlMzbqzQD6LNZEWUTqWPQfw qy9z4J42nenBMiJcltnhvIx2M1tbcx7Qzitrv3swwlq6yfT6CP7HBNIlcqUEnq9Kzd8Xcceb31/5h sVhJyS7xbdUGwavlKSvof8Rd7VloJQt4Yk5GM26KHG8xORlDARViDHqxdMeBKU2O/BDJHonsjFMlr ASZP1jcZFuAjKnG3WiiJLAZ/64Af04q7VO0Iu/Sbx3D13Eif/FxaPoWCPnCBviZi6HXGRX3rxAD19 UvK7hHK3f8/SiFTpcUHzBUbx5vvdiMqKxbZjVXiJmtZY2SfNKyKUxtVmZV5fj9j8c0VRL4yd+dPjl rmh1c+qA==; Received: from mail-he1eur02on060b.outbound.protection.outlook.com ([2a01:111:f400:fe05::60b] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljyQM-00GrZV-Pz for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 06:14:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V58yGFN8bNoIXE79ipuqPu89je+a7oKQvilEl6eVG8rKc4vuEe021GlRkenvM4AB1MuorbeWIdiNDZzzEGTJwelQuIcMvzcdphi3ziAVN2SzpLe9ATEuL27i8ky7o2tMBYjlt0QEjugyxKioOwCq/wWS0Ejd6avuAKyrrpphtCYeAAUxigathSGZTQyljp3MigjUeBMze8b08eF0im+hQL+qCRxZzYZZodcLBAXPRe01g4De0pHcjTJpcKkdAzyDUuF2eqvqbs1YjCFvk1R9+1iDLVuMw3L09nxYukCo53vqpNL3Fjy15on5FD3BN3ysrQ/UROzY2F+/pVIt0l8kNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uw5uqVpqkLCh42wGjEPyWL3X4e+hh7jQ6qIs0Gpsx8g=; b=e0uP1YlPUicjl2e8kN9nbj0ugjU6zDXZVqwuQ3UhiNgW8T4RulaIh7Ho2Iz2PLfQk95eJHJASh+Lz4QHQynqkE2rqhGEpqMGT9rT2Z1aRjzt0cXP1QmRw6UQhM/6PeS91aR1/Onkt9IfQQoouwiqB1rxLGpzt6HygqX9nAyca5ScVqMgVsBxBBCfcGzXZG8b2JbKiRgaNvc4OG+SJTiCQTR20SsOZixmgtqfImyz06+ZokaLUSByPKVvhsKV8LJwZUb1fQSRjW2mh8V348WWDe+wtIJRxQlTZS05cLBi8zIXXmJf6ucNextk9Tu3OJv88ED8IuJi1ilGYzbLEK76wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uw5uqVpqkLCh42wGjEPyWL3X4e+hh7jQ6qIs0Gpsx8g=; b=hI38/GtNKq14b6Ih7pJdLtu5Vd8wgdbzcvePwElQ5gh82WnDV52kZg0s78Mf1qhrdZo28aIhy0/P4oDGrQI8EJvuqWsYuG9rCTaNGw0uNVK5cXGtLVljrixPPkiFqQkvdZR1H3qhG17F8z6Ha90Vf8OnMdTHxPv7w7aP/dPM8xY= Received: from AM6PR04MB4966.eurprd04.prod.outlook.com (2603:10a6:20b:2::14) by AM7PR04MB7062.eurprd04.prod.outlook.com (2603:10a6:20b:122::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Fri, 21 May 2021 06:14:11 +0000 Received: from AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::b10a:ad0:a6f5:db9b]) by AM6PR04MB4966.eurprd04.prod.outlook.com ([fe80::b10a:ad0:a6f5:db9b%2]) with mapi id 15.20.4129.034; Fri, 21 May 2021 06:14:11 +0000 From: Aisheng Dong To: Clark Wang , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" CC: "kernel@pengutronix.de" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 02/18] i2c: imx-lpi2c: add ipg clk for lpi2c driver Thread-Topic: [PATCH V2 02/18] i2c: imx-lpi2c: add ipg clk for lpi2c driver Thread-Index: AQHXKticx0qJ5yaS/k2HkkC/0NtXCartubDA Date: Fri, 21 May 2021 06:14:11 +0000 Message-ID: References: <20210406113306.2633595-1-xiaoning.wang@nxp.com> <20210406113306.2633595-3-xiaoning.wang@nxp.com> In-Reply-To: <20210406113306.2633595-3-xiaoning.wang@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1f12a34-e909-46d6-b640-08d91c1fa6ba x-ms-traffictypediagnostic: AM7PR04MB7062: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6PK0I9knT6C2OiqhRuP1h3x7vV3ygZu8xUaXU9E8hk9226rZ2JwPdRN2bcmEt25Y024j+dSfXwsBCEW/RA1n1ide2Ijxg751pOFShTtGpFniaqyuLqpVZi4BpKr03OHyNz9W5uEQj5NAjCK2UP7PsDPwKf6n7TDMQNAHqUFM9fzXMNuhYZd4eISxRicOnO4D2TGZKMEjhVrTMRkD3+Hlx2sNtISGyZzRrvQEnphy7y9TUEXJasTZax+j/JBHlZezRPedLhCPLHasxEKbphe2B2aBBkKE1IBGOrd+ZrU1DFe7flV88iAgRHWx6l/9p1DPQo6s7FW07xox1r/L6XqBo9P9Ou0iqM6d1AvyXCeYPr1vz7MKKxuLjqX1/ZNijLnfRI5nFtmmoyj+Hafo/wB8Cck5yTkz4MWkmvh+zE6ZU2vSdHNZf0KAw5TiFXGBcw1ygWjHJvaoaUlWK85mqTj2lJQJcZlCyKlHNKP55AE2srs8PapNj5K6vVqPCmDfx2G6dSQ4CkNzhP2ij3bU4QSRTXgQn4F95ycHshUpNOmWh6bhim0PKjVQqzT8ciAL4TyaMHErQRnlHNapbbqD7BPOrXQD4SHSMXg1dIT6bJsplEg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4966.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(66946007)(33656002)(66476007)(76116006)(55016002)(66446008)(64756008)(186003)(71200400001)(2906002)(66556008)(44832011)(6506007)(110136005)(5660300002)(122000001)(8676002)(9686003)(52536014)(38100700002)(83380400001)(8936002)(478600001)(4326008)(7696005)(26005)(54906003)(86362001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?R2gycng3Q0N1RWYrS0JZNUJIdDZRbExOOXZYUXpSa2JzY1liTS9DaGFTOWxj?= =?utf-8?B?UjlyWVgxV1h0Z2NyV2Q1bTRCSi9ZUndqTkFlS1JqaGxseml1UWM1MlltTFZX?= =?utf-8?B?RTZyZ0s2L2Z5aVUzZ2x2VVU4b1BueFZQdVBiT3NZdlZEUXBKRDBqamg4b1Rp?= =?utf-8?B?NDJpaXNWU016eEQ3a1VVR21SbFc0cWVKVmhOM2VrR0JvYlVramdINHB0Vjh4?= =?utf-8?B?UUVOd1YrTWtOUUN5ZFZYTVNFdVAxUkJVM1FUSEFHbW9nN0VrK3ZHQ2tCaElw?= =?utf-8?B?MnNYM1pRYmIrS2xteGErd3NZZXlvbVpqZFVqYTQ2Q2tjWFpZdm9qNVd6d1hi?= =?utf-8?B?ejl0VGJGL2JIbzd0MG02eEJwMklnaHRwbGs3Qm9JekJuUnhXbDBBLzRxdUNt?= =?utf-8?B?THcrQ3RMN0xicnJ0WHlPK3BTZUdTc0l6aW40aTVjeHM2ZUhGOVVibkI0aXRE?= =?utf-8?B?OUVSMDExS1pKZ1huNHNNSFRwQWVWMGFVd3JSVUpNNVRBWmFTcHU1VFJoWDFt?= =?utf-8?B?Q3dPMG9NNWpSekZGSjErbC93dHgyTlRhaHlySC9iWGJkdksyQUgrUUJwNmpV?= =?utf-8?B?OGxxUDZ4aEVkMVFoWjFJUU1ha3lEWXBrQkN3bXJtMkltdVhPbSthTVM4ZExE?= =?utf-8?B?b3FoR0JDOElHRTV6dzZiSzlnS3dwaTN1Um1BUWNpcUdyU0xxYWxkb3l6d3Ns?= =?utf-8?B?RHM2eGVKR1dzYW42bFkyRlpVNkt1ZTJjRmE1UHY1OXg3ZWVoSVFBbmRrbXl2?= =?utf-8?B?WkFYbGxqQ1pKWjN2MGJ3Vk1SV20vYlVGMUUwN2Q3QkFnSFM0QXlZUHNRZTVW?= =?utf-8?B?STlNRGhlNGs3Uk0rZmtKMXQ4dGFHQkc3SDhsdGF6YU1qQlVZZHlEM1hFbGZi?= =?utf-8?B?NHlORXcwcjFHUnpsUE1wWFlmV0xTZ1RwMlludWxzaVpWREFDM3ZQMnhMSkt1?= =?utf-8?B?RWhXdTJxME9FbVByRHBocytHZm1La3dDWHZmZFhZU2FtdDhRMFQyaFBIRy9E?= =?utf-8?B?dS96ZDBkYWZBMkhMR1BVUmZ4NDk4eE5iOTg5NFRxVDF5OGJ4OTdpVThzZngy?= =?utf-8?B?NWNSdkdKUTBPZjlJNnlZd1dsbkZoeHJubHkrbGpNUHEzWWRpdUZEQXlDS2xi?= =?utf-8?B?NlVINEtsU1ZhTkNWTkpSZzVzamJZMkxuQ0ZlLzdiN1hnMmxxSmg0TWNDTFVP?= =?utf-8?B?MlFJSjNMZ05oMnBqVkZ1bGFhakNrM3V5bCt4cTZKSU51UlBoWnZTOHU2NGtE?= =?utf-8?B?VVNCRTYycC9tdGg5eENrQ3lPVFFBUGtJeDhQSXZRcXFzK0dpc2RhRkVsTitk?= =?utf-8?B?S0t1Ynlsd3RDcnJKOTk3cTNVR2FPbGpxR1I5QWZXTGFwejEra0dlajl1b3NF?= =?utf-8?B?eWI4a3dNR2NZLzRJd1gzSndHNGlKajdyZ1l3RGttY2dsaktuVkdDTVVRTEJH?= =?utf-8?B?dVdhVFJ2cEJWYjBqN0VDNWRIYitCZjlzTDNwUlNFQ3RxWDQwWjV0QU0yTkJl?= =?utf-8?B?S1VlNmFJWm1wSFR4SHVncEdaNVFtWGlOQ2l2WE5lYVVNcGRKRjl6K2RSdWZ0?= =?utf-8?B?dTFteElGYjRPcnJYblpxUjFTdzV1dWlHTy8zb0RhQ1IxY3J2Sy92ZEF2ckwr?= =?utf-8?B?ZTV5WnllZHh0aG5xc2ZLN2JYbDh1Q3RManQ1NXJ3Q3kzZVY4L1ZwbEtETnpQ?= =?utf-8?B?UHhkZncyL2gzNi83MmYrTk9FKzdJWm94d0szazFqRW1lVnRML3lPSWRnOEpz?= =?utf-8?Q?KRt+H4kSLOBdgZXIR7zfKU8ojeFniqd9W/QjSPD?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4966.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f12a34-e909-46d6-b640-08d91c1fa6ba X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 06:14:11.5804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PfjuL0rlP5jl9YyHP2ttQem1oCjm94FrxmNyKzPttdXlo2cvy1NZYicm7c0Egby/7YAutKGrUD/RKptBAa5Dbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7062 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_231418_948268_A4F3B024 X-CRM114-Status: GOOD ( 26.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Clark Wang > Sent: Tuesday, April 6, 2021 7:33 PM > > The lpi2c IP needs two clks: ipg clk and per clk. The old lpi2c driver missed ipg > clk. This patch adds ipg clk for lpi2c driver. > > Signed-off-by: Gao Pan > Signed-off-by: Clark Wang > Acked-by: Fugang Duan You can drop the original Ack or signed-off if there're significant changes BTW, please move the binding doc change before this patch. > --- > V2 changes: > - Merge two clocks' prepare funtions to lpi2c_imx_clocks_prepare(). > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 61 +++++++++++++++++++++--------- > 1 file changed, 44 insertions(+), 17 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > b/drivers/i2c/busses/i2c-imx-lpi2c.c > index bbf44ac95021..89b7b0795f51 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -94,7 +94,8 @@ enum lpi2c_imx_pincfg { > > struct lpi2c_imx_struct { > struct i2c_adapter adapter; > - struct clk *clk; > + struct clk *clk_per; > + struct clk *clk_ipg; > void __iomem *base; > __u8 *rx_buf; > __u8 *tx_buf; > @@ -207,7 +208,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct > *lpi2c_imx) > > lpi2c_imx_set_mode(lpi2c_imx); > > - clk_rate = clk_get_rate(lpi2c_imx->clk); > + clk_rate = clk_get_rate(lpi2c_imx->clk_per); > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) > filt = 0; > else > @@ -538,6 +539,34 @@ static const struct of_device_id lpi2c_imx_of_match[] > = { }; MODULE_DEVICE_TABLE(of, lpi2c_imx_of_match); > > +static int lpi2c_imx_clocks_prepare(struct lpi2c_imx_struct *lpi2c_imx) > +{ > + int ret = 0; Unnecessary initialization > + > + ret = clk_prepare_enable(lpi2c_imx->clk_per); > + if (ret) { > + dev_err(lpi2c_imx->adapter.dev.parent, > + "can't enable I2C per clock, ret=%d\n", ret); > + return ret; > + } > + > + ret = clk_prepare_enable(lpi2c_imx->clk_ipg); > + if (ret) { > + clk_disable_unprepare(lpi2c_imx->clk_per); > + dev_err(lpi2c_imx->adapter.dev.parent, > + "can't enable I2C ipg clock, ret=%d\n", ret); > + return ret; > + } > + > + return ret; Return 0 > +} > + > +static void lpi2c_imx_clocks_unprepare(struct lpi2c_imx_struct > +*lpi2c_imx) { > + clk_disable_unprepare(lpi2c_imx->clk_ipg); > + clk_disable_unprepare(lpi2c_imx->clk_per); > +} > + > static int lpi2c_imx_probe(struct platform_device *pdev) { > struct lpi2c_imx_struct *lpi2c_imx; > @@ -563,10 +592,16 @@ static int lpi2c_imx_probe(struct platform_device > *pdev) > strlcpy(lpi2c_imx->adapter.name, pdev->name, > sizeof(lpi2c_imx->adapter.name)); > > - lpi2c_imx->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(lpi2c_imx->clk)) { > + lpi2c_imx->clk_per = devm_clk_get(&pdev->dev, "per"); > + if (IS_ERR(lpi2c_imx->clk_per)) { > dev_err(&pdev->dev, "can't get I2C peripheral clock\n"); > - return PTR_ERR(lpi2c_imx->clk); > + return PTR_ERR(lpi2c_imx->clk_per); > + } Will this patch break imx7ulp which doesn't have per clock? > + > + lpi2c_imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > + if (IS_ERR(lpi2c_imx->clk_ipg)) { > + dev_err(&pdev->dev, "can't get I2C ipg clock\n"); > + return PTR_ERR(lpi2c_imx->clk_ipg); > } > > ret = of_property_read_u32(pdev->dev.of_node, > @@ -584,11 +619,9 @@ static int lpi2c_imx_probe(struct platform_device > *pdev) > i2c_set_adapdata(&lpi2c_imx->adapter, lpi2c_imx); > platform_set_drvdata(pdev, lpi2c_imx); > > - ret = clk_prepare_enable(lpi2c_imx->clk); > - if (ret) { > - dev_err(&pdev->dev, "clk enable failed %d\n", ret); > + ret = lpi2c_imx_clocks_prepare(lpi2c_imx); > + if (ret) > return ret; > - } > > pm_runtime_set_autosuspend_delay(&pdev->dev, I2C_PM_TIMEOUT); > pm_runtime_use_autosuspend(&pdev->dev); > @@ -635,7 +668,7 @@ static int __maybe_unused > lpi2c_runtime_suspend(struct device *dev) { > struct lpi2c_imx_struct *lpi2c_imx = dev_get_drvdata(dev); > > - clk_disable_unprepare(lpi2c_imx->clk); > + lpi2c_imx_clocks_unprepare(lpi2c_imx); > pinctrl_pm_select_sleep_state(dev); > > return 0; > @@ -644,16 +677,10 @@ static int __maybe_unused > lpi2c_runtime_suspend(struct device *dev) static int __maybe_unused > lpi2c_runtime_resume(struct device *dev) { > struct lpi2c_imx_struct *lpi2c_imx = dev_get_drvdata(dev); > - int ret; > > pinctrl_pm_select_default_state(dev); > - ret = clk_prepare_enable(lpi2c_imx->clk); > - if (ret) { > - dev_err(dev, "failed to enable I2C clock, ret=%d\n", ret); > - return ret; > - } > > - return 0; > + return lpi2c_imx_clocks_prepare(lpi2c_imx); > } > > static const struct dev_pm_ops lpi2c_pm_ops = { > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel