From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A97C4338F for ; Mon, 2 Aug 2021 14:56:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DA5460F5A for ; Mon, 2 Aug 2021 14:56:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3DA5460F5A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qn3knZeuf/QiiF+eJPctHraQx9EfkDS/tYVjsKLQzAQ=; b=t8SUmoUJJrsvXv mpiWj10tDUs0UYnJONngOEIbiV5NRXSAyxx7zLzTK10ICMIM8SfziFtCB01FJXc8rjSVnbmdQHdRA N1LFCeggyuJr6b0lbpGF57gVjNcJAd3OzpZFK6maywwGQkn+t6wzcSyVX11cuKrqCii+rJfq8/TJw VfFPy4oXdHnYj6uD6wCvdoN+yI8UkyebLCVcn2w+KBELdQHgeCJO7Wc0CmtFl0nqBDFPkLzaY59rR ry5EKb0z3bcRmI8YqNWdU3q8xYH9jqEsSGWCbjmp4bUK34SFzHTW4pJz4jVipzjNaSxpNNvSecsfq OrTRmmBeehQquP2T5y4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZKh-00Glma-HX; Mon, 02 Aug 2021 14:54:24 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZJq-00GlUE-5H for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 14:53:31 +0000 Received: by mail-ej1-x62e.google.com with SMTP id h9so15881898ejs.4 for ; Mon, 02 Aug 2021 07:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E6FWmVZfDjLa3Evt0Fn+50V6XguYMilIcMj6+S8hDhM=; b=oqcZv0fOKw49s1dfDkn3QFtKKh7kUyBUbZ8eUoFgJ8Wew0rRh0D53TByBe7u1Ny/Tj rb3WFV1VdhGjk1pcruAVZ06h17QB8sUxhevCi8xak9Z0Ap0gUaM19wLcNfV3aj1tT4ls dmbSsjIPjjl1kvegq73ZdqYxSiXVKOjJaFAc+SPfwWX5Oqh81C38ksHRFoV44ner6ZNI eQLlk7/f0CdxexEgNQJEsQIgc/GEoN4UrvzsjQi4CqiQo/X0mQDk1xSmt/6bPj/UXoJ8 dZhPBljGPMHWCY+wJVDL7dAnrjNFKP6Sm682gzLvtxgaXxjHJ1sETrB/tRrSQlnnrfqV KO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E6FWmVZfDjLa3Evt0Fn+50V6XguYMilIcMj6+S8hDhM=; b=gg/Yr0xYqhz+zt0Aldr++5PjeZrh3HNQb1+SjganegoEt737cmFbAUJ9QWXRPFCXr0 hn3RFr+qTaQAp7zU6G3Nck6+puLEGknMgBU5n6cO89Hmu2K19P1Hn+TsrqpTaqaXzddn 4qpexpkSF8GYHhjRJljfIdoWA9lZSsyRD9oCeJc+LNCT80vNL1Gr4tUkLsf39+wUPWY+ O8RvT4B7h0N1TgsKTTm8y/rP2uN1PKOMvNSEUOtmsyzToqQ75z33S/qhYoCoJZiNtjN0 8ieU10lkFnB1iS5tuCafhwBY0+OVhpKqIz2iSUtnjkn6XcPod1RhgN72PAFqVw1oeoxk J4Dw== X-Gm-Message-State: AOAM531OLsHuiHYUejy4DTP22mHES9H7Pbvtm9fiLwcJtmk+mksjmi3f nthwM31puQ1WVngFmSOIh6hUnAOMSxRUJOQc22Vv8A== X-Google-Smtp-Source: ABdhPJwPorqtqpze/8XQ3IeLdPsZ4jw4SoXKq7dwTegBWGeXoiFEXZRNPE+1Z17aC6tvi1oLm0ZA4BY5mG/BOH9M7fQ= X-Received: by 2002:a17:906:cd1a:: with SMTP id oz26mr15845091ejb.101.1627916005678; Mon, 02 Aug 2021 07:53:25 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-17-qperret@google.com> In-Reply-To: <20210729132818.4091769-17-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 16:52:49 +0200 Message-ID: Subject: Re: [PATCH v3 16/21] KVM: arm64: Enable retrieving protections attributes of PTEs To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_075330_287799_F4B76EAE X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin, On Thu, Jul 29, 2021 at 3:29 PM Quentin Perret wrote: > > Introduce helper functions in the KVM stage-2 and stage-1 page-table > manipulation library allowing to retrieve the enum kvm_pgtable_prot of a > PTE. This will be useful to implement custom walkers outside of > pgtable.c. > > Signed-off-by: Quentin Perret > --- > arch/arm64/include/asm/kvm_pgtable.h | 20 +++++++++++++++ > arch/arm64/kvm/hyp/pgtable.c | 37 ++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h > index d5ca9b6ce241..7ff9f52239ba 100644 > --- a/arch/arm64/include/asm/kvm_pgtable.h > +++ b/arch/arm64/include/asm/kvm_pgtable.h > @@ -505,4 +505,24 @@ int kvm_pgtable_walk(struct kvm_pgtable *pgt, u64 addr, u64 size, > */ > int kvm_pgtable_get_leaf(struct kvm_pgtable *pgt, u64 addr, > kvm_pte_t *ptep, u32 *level); > + > +/** > + * kvm_pgtable_stage2_pte_prot() - Retrieve the protection attributes of a > + * stage-2 Page-Table Entry. > + * @pte: Page-table entry > + * > + * Return: protection attributes of the page-table entry in the enum > + * kvm_pgtable_prot format. > + */ > +enum kvm_pgtable_prot kvm_pgtable_stage2_pte_prot(kvm_pte_t pte); > + > +/** > + * kvm_pgtable_hyp_pte_prot() - Retrieve the protection attributes of a stage-1 > + * Page-Table Entry. > + * @pte: Page-table entry > + * > + * Return: protection attributes of the page-table entry in the enum > + * kvm_pgtable_prot format. > + */ > +enum kvm_pgtable_prot kvm_pgtable_hyp_pte_prot(kvm_pte_t pte); > #endif /* __ARM64_KVM_PGTABLE_H__ */ > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 1915489bb127..a6eda8f23cb6 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -363,6 +363,26 @@ static int hyp_set_prot_attr(enum kvm_pgtable_prot prot, kvm_pte_t *ptep) > return 0; > } > > +enum kvm_pgtable_prot kvm_pgtable_hyp_pte_prot(kvm_pte_t pte) > +{ > + enum kvm_pgtable_prot prot = pte & KVM_PTE_LEAF_ATTR_HI_SW; > + u32 ap; > + > + if (!kvm_pte_valid(pte)) > + return prot; > + > + if (!(pte & KVM_PTE_LEAF_ATTR_HI_S1_XN)) > + prot |= KVM_PGTABLE_PROT_X; > + > + ap = FIELD_GET(KVM_PTE_LEAF_ATTR_LO_S1_AP, pte); > + if (ap == KVM_PTE_LEAF_ATTR_LO_S1_AP_RO) > + prot |= KVM_PGTABLE_PROT_R; > + else if (ap == KVM_PTE_LEAF_ATTR_LO_S1_AP_RW) > + prot |= KVM_PGTABLE_PROT_R | KVM_PGTABLE_PROT_W; nit: why not use the freshly minted KVM_PGTABLE_PROT_RW? Thanks, /fuad > + > + return prot; > +} > + > static bool hyp_pte_needs_update(kvm_pte_t old, kvm_pte_t new) > { > /* > @@ -565,6 +585,23 @@ static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot p > return 0; > } > > +enum kvm_pgtable_prot kvm_pgtable_stage2_pte_prot(kvm_pte_t pte) > +{ > + enum kvm_pgtable_prot prot = pte & KVM_PTE_LEAF_ATTR_HI_SW; > + > + if (!kvm_pte_valid(pte)) > + return prot; > + > + if (pte & KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R) > + prot |= KVM_PGTABLE_PROT_R; > + if (pte & KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W) > + prot |= KVM_PGTABLE_PROT_W; > + if (!(pte & KVM_PTE_LEAF_ATTR_HI_S2_XN)) > + prot |= KVM_PGTABLE_PROT_X; > + > + return prot; > +} > + > static bool stage2_pte_needs_update(kvm_pte_t old, kvm_pte_t new) > { > if (!kvm_pte_valid(old) || !kvm_pte_valid(new)) > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel