From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE91C432BE for ; Mon, 2 Aug 2021 14:56:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 601B760F70 for ; Mon, 2 Aug 2021 14:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 601B760F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=85wSmla/hTaqnS9Sm/Y9ByTFlN8kCc5VvHniXH92o9w=; b=NUtOmShOB4CUXj 7Cj/Wt7oRn8lus6G8BBG93Qn6qfIBIFcEhIAYSDJCLq4lFJo9g61EKwTc+F03f9Mu5i+WLNM1GLYb fHgmf4LqK8qpeMvu9LU72+cgIbkVoMjewZROxX9qVkFc9srS2yiOVGhALTYgINDZ9eXPPnW9jNYVY 8yHG9OA+kmp2Cw1l5aKekcbZCJD3+iz8uiGWKd/Hi9zpqruBM09oYeLvYhcGQlFlAQkr67jAJPlrQ t2ftVoiK9jxB06OODX6aOPHixUE5O515gDdZ5HS1UAcUqATYoMhlgO80wWs+3hJnEgX2xjVgGQaVO 1xA2mphn0mZZJxIekK/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZK9-00Glbd-OM; Mon, 02 Aug 2021 14:53:50 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAZJV-00GlOa-Jh for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 14:53:11 +0000 Received: by mail-ej1-x62a.google.com with SMTP id hw6so17426958ejc.10 for ; Mon, 02 Aug 2021 07:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h2IiuJBcGGHlU+MZOjJcOdM9TvLs3ZLSnxY+XqABa0c=; b=USbbLnzqSe8hzqWM6MzvtVB4fSWYo4OClr3p9ww33ZPRsdM8MzcX/U7glKcc5rddND HlSvxeOH4qaLa+CbTy62XQzUpI6/GDhqUl3Raf1NKZgSSj4fDDUpHr9+1sEAiWsAenaZ IBPwEAMHf+4PBDzd/06RF7q5oYEOW7F5tjLioL8BXQqxLT2JB3YZO5VAOO+7xMcUSnwj 9cTNw/c9HMe1miCLXfK2CBsy/RZu7J95iOEwE1oEVe6xo6m+akJWMQaqeX5IMLAh+6n5 rv8uMfOYFTwjNgdDV016+hPQsaISP6NMFbMPdKBd4w6jZLjvmQ/Q4s1zdushGvo6wIYT rRkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h2IiuJBcGGHlU+MZOjJcOdM9TvLs3ZLSnxY+XqABa0c=; b=ozQVP9AXWoysOaoArLE6SJ3yCci9+5GhB6VGExJXyiC6ECxUKMrAi+R+BzRMWwaWgW SYV+fV9D+pFu2mJ8supGpdr6XtREBvSK6ZCWtvwjbYTba0y6UNKo3FcYOJOzCyk8wcDw H8jUhSUGHfqRXngPRE3fNy7gNFgDM6s3Y5nwHXAq9H7Vjv/ri057v5GqRKbXrURHJH3M VxK6s94mr2XtgUOyNPBgZr1L7ftGqzlrGiKy7kh3XZZgxsLfYU3uzD26oCU/5glS6Xlb nVeyp7LndSsMfwoRtge+9UaChlaD/+egVo5ss2nIlKH7fYB90xkI9mLNXCtA7SmevG99 uLjA== X-Gm-Message-State: AOAM530rsTGTVM3Wl1yeYifHQa3I4HS2Ya0EL8053jPZPxLPLM91qKn+ FWW9Kv/6RhS4Nvf46TcpDCbIj0M0hwi+A1iniGZpRA== X-Google-Smtp-Source: ABdhPJyBbigDvWGHVWOmQazVw8pxVXKqhiol21T3Dx4QXWONixp+CbjlyQf4i6I2RwpRHQdtWK86vFVNoEXF75wGOZc= X-Received: by 2002:a17:907:7895:: with SMTP id ku21mr15674328ejc.265.1627915987486; Mon, 02 Aug 2021 07:53:07 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-16-qperret@google.com> In-Reply-To: <20210729132818.4091769-16-qperret@google.com> From: Fuad Tabba Date: Mon, 2 Aug 2021 16:52:31 +0200 Message-ID: Subject: Re: [PATCH v3 15/21] KVM: arm64: Introduce addr_is_memory() To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_075309_705849_46391CD2 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin. On Thu, Jul 29, 2021 at 3:28 PM Quentin Perret wrote: > > Introduce a helper usable in nVHE protected mode to check whether a > physical address is in a RAM region or not. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 1 + > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > index cc86598654b9..5968fbbb3514 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h > @@ -51,6 +51,7 @@ extern const u8 pkvm_hyp_id; > int __pkvm_prot_finalize(void); > int __pkvm_mark_hyp(phys_addr_t start, phys_addr_t end); > > +bool addr_is_memory(phys_addr_t phys); I'm just wondering about the naming of the function. I understand what you're trying to achieve with it, but an address without a unit that conveys size or type seems to be missing something. Would memregion_addr_is_memory or something like that be a better description, since it is what find_mem_range finds? Thanks, /fuad > int host_stage2_idmap_locked(u64 start, u64 end, enum kvm_pgtable_prot prot); > int host_stage2_set_owner_locked(u64 start, u64 end, u8 owner_id); > int kvm_host_prepare_stage2(void *pgt_pool_base); > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index bb18940c3d12..4532f3d55a1a 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -196,6 +196,13 @@ static bool find_mem_range(phys_addr_t addr, struct kvm_mem_range *range) > return false; > } > > +bool addr_is_memory(phys_addr_t phys) > +{ > + struct kvm_mem_range range; > + > + return find_mem_range(phys, &range); > +} > + > static bool range_is_memory(u64 start, u64 end) > { > struct kvm_mem_range r1, r2; > -- > 2.32.0.432.gabb21c7263-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel