From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6AAC4338F for ; Tue, 3 Aug 2021 10:53:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E25DA60F94 for ; Tue, 3 Aug 2021 10:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E25DA60F94 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kKpIijmDjAYDpKE7GjOpHw6q84nyqE1MAZDZTWW1Ksw=; b=Fhc3L68QDTk5fL OaiOpnzTbp9Zu5HrIv6XIO7/tkslXWfk4Rz0cEQocpjXNdgRlZZLzC+F/Yp/oB3yilzhlHwkGmY11 Kv8gOYU6CA0Rh/TOimOILSjVRXYC1FsI8Afs3GAFaClIf1fAa6lWYUWUu19Z5d2gk+YntTLe6kLM9 dV+Q7cQmv0h2J4IX8VPojKqUxmbjVT3BeckR6TliPBD2kjr7y7VqYPhj9guJqfZeYbLSGtNo0U1Nh PsgzBcijNDMQkJtEwUMnjT8ESbBmz9pxM/Ikz/F/vMl7VQCI+YBs1tuu3EGOkWtl34baJWBXzGc4t RNbKSS03GcXkAxYXvKHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAs1g-002AxD-Ux; Tue, 03 Aug 2021 10:52:01 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAs1Y-002AvT-Ui for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 10:51:54 +0000 Received: by mail-ot1-x331.google.com with SMTP id 68-20020a9d0f4a0000b02904b1f1d7c5f4so20283717ott.9 for ; Tue, 03 Aug 2021 03:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WUxc5MB+Tq9hVrzE0x/FFFlgnTm10UXPxyV+GzRqkrU=; b=vEGntt1HAENdzj7VnMWn1fUB6jPHul3UT5wMP8S8Tb6a+ytZly9lG4RVFX/gfhuAng ARWKq53znmro8GS9NNAmLHkaTgkUuO8k85Ag/VbXZ5iKHpWVFt8fNh0VsYs8yV+MajiF uZjAnHsvi4AAm23IdbL96IZgZiQD6pEwQL4Fn3RgacC2PeQSLzbsDE8Q62jSHkvDXiBa FfSlcBIYI0w7/26HnO32BO3oEaMEXEQ4mxW+EibsRnAW7vinAxjvGtG+i2uYkASGVUTK fxG1ViAkBlY5o5sKtV7ntAKMPOsk0mJ/HbArVU1/HIgiDGYHsGaQwGWoHDIH3gxp9o20 SUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WUxc5MB+Tq9hVrzE0x/FFFlgnTm10UXPxyV+GzRqkrU=; b=H8TokuTIkkG0X2CasI1rhqT4HAVM+kYwWXTNMrSd5iTwURq7dkL505hJrM7h1hDa1J AifU9YSD6d1mhbNDpA0xbXIaPWOt/wxKxk7d7FffQCjLWX83AG0eTPhHWqap02XdNn9J DJz27eUaNCHbpTjXO6clzdsjE8msa4hySzPpZviCRM6WelvofP3f+kycP6ji/J/58np4 kvWBJEco1Ul+t0FT+rpUxc6qTVWELXErB6DR5hYwRpgZB+ZxsCoI26tPMVGXkEV1p4wd Xh/E0c+5CDux8mNfzUCU5+Mn3LHledwEVoAdYvvOuDDeIUhuRsMz8/4pzR0ihS68l77k hq5w== X-Gm-Message-State: AOAM5336i+LfXY1JROs9ddmEfIHiIRvcvJwS/29Ut0tyVDgIlF25A8oH aC5/u0dCLuNyARHsMNmWY/mG8ksYk0cYZLrGlbY90Q== X-Google-Smtp-Source: ABdhPJxvZT6TZfQaKjA6ySTyD8WZ6X/uh3f6kHY+xaZ5tPnSjzoDuCwt+rtQflv2skumMaQuDNbtoJ1oPtX8ZEwIuV4= X-Received: by 2002:a9d:202d:: with SMTP id n42mr1249812ota.52.1627987911567; Tue, 03 Aug 2021 03:51:51 -0700 (PDT) MIME-Version: 1.0 References: <20210729132818.4091769-1-qperret@google.com> <20210729132818.4091769-20-qperret@google.com> In-Reply-To: From: Fuad Tabba Date: Tue, 3 Aug 2021 12:51:14 +0200 Message-ID: Subject: Re: [PATCH v3 19/21] KVM: arm64: Refactor protected nVHE stage-1 locking To: Quentin Perret Cc: maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, ardb@kernel.org, qwandor@google.com, dbrazdil@google.com, kernel-team@android.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_035153_068406_BD8AB812 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Quentin, > > > +int pkvm_create_mappings(void *from, void *to, enum kvm_pgtable_prot prot) > > > +{ > > > + int ret; > > > + > > > + hyp_spin_lock(&pkvm_pgd_lock); > > > + ret = pkvm_create_mappings_locked(from, to, prot); > > > + hyp_spin_unlock(&pkvm_pgd_lock); > > > + > > > + return ret; > > > +} > > > + > > > > I'm wondering whether this patch should also refactor > > __pkvm_create_mappings. It doesn't quite do the exact same thing and > > has different parameters. > > Sorry, not sure I'm understanding your suggestion here. What do you > think should be done to __pkvm_create_mappings? Sorry, my comment wasn't very clear, and "refactor" is the wrong word. I think it should probably be renamed, because __pkvm_create_mappings isn't called by pkvm_create_mappings nor by pkvm_create_mappings_locked. It also has different parameters and behaves slightly differently. Thanks, /fuad > Cheers, > Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel