From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7434CA9EC9 for ; Mon, 4 Nov 2019 23:42:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B73D220717 for ; Mon, 4 Nov 2019 23:42:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VAeTPWEj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="oGPkCL7M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B73D220717 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ooC8NdMIov8ETMglUMqgYqZ8EQuBgwTOMirn/4Pxbw=; b=VAeTPWEjW3Fqod NUImjwMKCKqxwicI6I2um5OvpWIhFAojD/J+7VpmMvWMk2dLiF/rdIDwBlEtby75k9UQoOyfin0YE uilgcAXEui+H17hDXhwiT1c50R6EPc3JFhq5qqL/cdo1IbqAYYJDFrpQH57448gRXXzE7e74FItef +SQbiTKgHziYj/7pDpjrKw0LOrtuFZ99JhBF9jAHdu4ozgr8m3goXMYZM3vghRbS/VB6FrYEYudPx uzg2wQSRltnRQZfvoxed6xKA3Ivdisyp5BI1Nukgwxyw8yS8bwdwDLpeJu/P9SPBR20JrSE4ERSvD PZjx0n8KyiLyj5LrWDxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRlzO-00085A-Sm; Mon, 04 Nov 2019 23:42:26 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRlzL-00084J-9J for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 23:42:24 +0000 Received: by mail-ua1-x942.google.com with SMTP id z9so1803875uan.3 for ; Mon, 04 Nov 2019 15:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r7KXOloQM0IlfDWd2ZmUfquqt9+rdW/LWeVsYzZS5Yo=; b=oGPkCL7MQlhqPwAizXy81wfFgmEWqswSVaJ070q7QSMUHV4rPFEYIVwwPUoI9JzQsV tjGNPbiNdqm3wtOwdKjIJhkvEjEXR8IE1Pm1iGuTui1lsJ+zyZeDnmwaGc2e6IpIiC7j 9DxB+dahbSm/W3s0bm4fZ+Ya8dVCfIpGNF7eIHGT9X8eK1ysYtT0Awoo+UNrLzgXT1M8 6lCULIQcB4PBf/VReN8veBI+zOWkOCacAf5D4mMyNLo05/F1kRUX0ZUZHRqR65q2ltF0 9f1oEkjctFu+UunQvKHg6uh6X+4dlnVuWcEQ+Q7Gr/HjdzHoxvC8WHhHXsbWPLqqmzQT XpXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r7KXOloQM0IlfDWd2ZmUfquqt9+rdW/LWeVsYzZS5Yo=; b=Ar+70Cb9UVf6H1BJ/Un3UuSRh76lTpVzP1U4xI77GwKGDQoNd5Wbgntpxd8AHOoJpS JiGkQB8aSO497V3rwX5NA0wIOxGjIh3+WHdz3SCeL/8g2f0r3QnyTiC/ei72Jd/ueJ7S qQursux9jMTDORLIXpXtM3iQbNbhWGC7NOMDCCNco+prK6A8gAtFrxdDUpLE955sT4lc HeslctSW4CSLfQBAW15PrDe/mnoKtehphzZMqwKit7zPaglXGzGzwzF1Gt3NFaxLZbey patp7f1kdKu7uCP9dBTwfZ6sS1iDfXNHxgkFmLBeZ3II9zMNScg6FBLNFimkr+/iCEM+ lPKg== X-Gm-Message-State: APjAAAU6XQZyHgjUFnl6VfhKS/QT61t2LnbU6iDIaZSEgjgaPKXyvsic 8JEYS7YfvYHUZGIC4saCOodyV6BQNxOE/5rydYSByg== X-Google-Smtp-Source: APXvYqz8I4cRB5IWTivRJgxux0uUc15gQK8/fyRxTXKNu37vOixhqfpx8UpDAvilaBEvuvDWvryENhED0MHmtPoojeg= X-Received: by 2002:ab0:1451:: with SMTP id c17mr4197520uae.110.1572910941690; Mon, 04 Nov 2019 15:42:21 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-11-samitolvanen@google.com> <20191104170454.GA2024@lakrids.cambridge.arm.com> In-Reply-To: <20191104170454.GA2024@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 15:42:09 -0800 Message-ID: Subject: Re: [PATCH v4 10/17] arm64: disable kretprobes with SCS To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_154223_358572_365ED4E8 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 4, 2019 at 9:05 AM Mark Rutland wrote: > I'm a bit confused as to why that's the case -- could you please > elaborate on how this is incompatible? > > IIUC kretrobes works by patching the function entry point with a BRK, so > that it can modify the LR _before_ it is saved to the stack. I don't see > how SCS affects that. You're correct. While this may not be optimal for reducing attack surface, I just tested this to confirm that there's no functional conflict. I'll drop this and related patches from v5. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel