From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88705C4338F for ; Tue, 10 Aug 2021 13:38:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4987C60F41 for ; Tue, 10 Aug 2021 13:38:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4987C60F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MiKbho8RBMeFNnpmUoLJU2po36//HkPDxl09yQ8pU9s=; b=uRSXGA9lgA8Atw eBJoz/J81ZXI4O8vbvzNnl6p84woaQqcF/ESH/Jx7XHIiYGkxXkQmYubThaZ5oqm7tVm54XfcEHog Qh1307esoRO5U6Dd2TbHp0+pnfcCBrNcHVoSR+0MOsqPiCdjqb0QbOzNNFSAbriowHI6YCBaY6EwW cZ7aKfbyF3M2KuUD6XuxLqQrz9cF/MFjakrXEFgkB5KlpyC5Dlx7VsgM7JTaOfz3HnGKbf/mkM66V 6Mxi8dhFcpuH4/F3uKZmYUOc1jJn6wzAFHzBUK5Y8GCZOV4zLd+OBdVk82+8IfxBxKtpXW6SCMheT jSpXvZU72rgz0P6WM66g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDRuH-00405K-0y; Tue, 10 Aug 2021 13:35:01 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDRu8-004039-GN for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 13:34:56 +0000 Received: by mail-lj1-x22c.google.com with SMTP id l4so14459471ljq.4 for ; Tue, 10 Aug 2021 06:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=weC7sDSz7PzZbDSqoiKFHyafe+0MyeXAiBAfK1qKcS4=; b=ZkMvWvxM4pvYUqy5fI/4E/yYTR8XZ9e8pydJ6+ayXV+l/hEgGcg9Ypw9CVe+FUTQ2v /houmtJqyVgq02TKQ6a746nHq4/i+0VpeDz9l/1d2CpGOlFO38Q1vpU6i7sO+p2s3tMI DUlynGX/7LZqhwkoGdQ1I52fAp7G+fpqh10/pb1NMYjXvJSVuesWsHOSGtrvkuPxriNc jvVf677JQLZxYssZpEuMQaobwk4MEkUKrGAGiABlPkeOE1bm7qE+ceiIrkU9NvaF3v3R LaSTJbXjQcT785+AN9Ak3xvACeT3zp4mEp3Lyn0uUHq+VwXoC16GbDvi0V6XITOL18RG FEBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=weC7sDSz7PzZbDSqoiKFHyafe+0MyeXAiBAfK1qKcS4=; b=JEmC1R9jxEFrYSCJCYfEydVBCnDmXuJCyxQXzhQcOPCk2AnMatY3bmDbYkjpYX81yQ kI3UEnzVWZ+Nkyplw6/mcJ2hrsT2W3an+2MCoj+sMqncw4mdrjLbfEsdOzBwT92QCWTr 6IKyUlvlBtQNDe2G9C3H/BltJRxsa9LrgFexfhnxjZ2ADM2w2cjXkr1S55xWao80jKuB PZgM/2f7D+EV2a3Mh7MqTjG570r7i6uTP26z6qlTJA6claMvB6R+4Qdekq5/qu5RIwZS pHokoi5OlPJ6V3glm0/z+sLvkdNjrAE91kjro33DfoVQCFCKDynNrdA3EOrsevDWBOan J/zg== X-Gm-Message-State: AOAM531JU1+AWzXvg29iIgRtjvlgS96bqYjVsNG5SLiOcERlj9bG+tNQ kfx+ZtFDHfYayYdteE1KCkLhzc2VFt4/2h1F36Fefw== X-Google-Smtp-Source: ABdhPJxTxTJieZbnaNjRPZUIvrVUDFyycbbX1QvFSIH1cQRHK81GI3c7N6EJyS6zlrZ5d2BhxV7i2qX73NcqQoP17mQ= X-Received: by 2002:a2e:888f:: with SMTP id k15mr19671128lji.326.1628602490522; Tue, 10 Aug 2021 06:34:50 -0700 (PDT) MIME-Version: 1.0 References: <20210723075858.376378-1-andrew@aj.id.au> <20210723075858.376378-2-andrew@aj.id.au> In-Reply-To: <20210723075858.376378-2-andrew@aj.id.au> From: Linus Walleij Date: Tue, 10 Aug 2021 15:34:39 +0200 Message-ID: Subject: Re: [RFC PATCH 1/6] pinctrl: Add pinctrl_gpio_as_pin() To: Andrew Jeffery Cc: Linux LED Subsystem , "open list:GPIO SUBSYSTEM" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Rob Herring , Joel Stanley , Pavel Machek , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-aspeed , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_063452_634408_D10A21FA X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 9:59 AM Andrew Jeffery wrote: > Allow gpiochips to map the GPIO numberspace onto a pin numberspace when > the register layout for GPIO control is implemented in terms of the > pin numberspace. > > This requirement sounds kind of strange, but the patch is driven by > trying to resolve a bug in the leds-pca955x driver where this mapping is > not correctly performed. > > Signed-off-by: Andrew Jeffery (...) Hm this looks a bit strange... > +int pinctrl_gpio_as_pin(struct pinctrl_dev *pctldev, unsigned int gpio) This is not a good name for this function. Try to come up with a name that says exactly what the function does. E.g. "apple pear as apple slice" isn't very helpful, the use case for this is really hard to understand. > +EXPORT_SYMBOL_GPL(pinctrl_find_gpio_range_from_pin); This looks completely wrong. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel